Add a test suite to cover refactoring the module.
authorGunnar Wrobel <p@rdus.de>
Wed, 3 Mar 2010 00:40:24 +0000 (01:40 +0100)
committerGunnar Wrobel <p@rdus.de>
Wed, 3 Mar 2010 00:40:24 +0000 (01:40 +0100)
commit181f07abd4017196fb4fd95da742806a281b339c
treec7adf221f5ffa3d75795e53b15f8c10ec40f78ca
parentf7389c5d7c3cd845ee3274ac39e2225ca13fe4b3
Add a test suite to cover refactoring the module.

This time the test suite concentrates on the external interface. The
way the Horde_Notification test suite was set up was indeed quite
problematic.

The next step for the refactoring would be to extract the Horde specific Elements into a Horde_LoginTasks_Backend_Horde class. This should provide links into the preferences system, session storage, authentication, etc.

The test suite covers one bug: The recurrence calculation for weekly recurring tasks.

There are two tests that are marked as incomplete: I currently still fail to understand the LoginTasks_Tasklist logic that uses the private _addTask variable. Depending on the task order some tasks will get displayed or not. But I don't see the rationale behind it. But the area should see no modifications during refactoring.
framework/LoginTasks/test/Horde/LoginTasks/AllTests.php [new file with mode: 0644]
framework/LoginTasks/test/Horde/LoginTasks/Autoload.php [new file with mode: 0644]
framework/LoginTasks/test/Horde/LoginTasks/LoginTasksTest.php [new file with mode: 0644]
framework/LoginTasks/test/Horde/LoginTasks/Stubs.php [new file with mode: 0644]
framework/LoginTasks/test/Horde/LoginTasks/phpunit.xml [new file with mode: 0644]