Have Horde handle PHP legacy error handling.
authorMichael M Slusarz <slusarz@curecanti.org>
Tue, 30 Nov 2010 19:19:43 +0000 (12:19 -0700)
committerMichael M Slusarz <slusarz@curecanti.org>
Tue, 30 Nov 2010 20:45:39 +0000 (13:45 -0700)
commit1bcc96de0496c8f28ce0945183f2d83c8d36c1d2
tree470833bbb1204301c5585041fed7cefa6a1402d7
parent84de7bb593417155e4794e6c339f5441e45c0019
Have Horde handle PHP legacy error handling.

First - no need to use error_reporting() wrapper anymore - my tests
indicate that as of PHP 5.3, using @foo() is twice as fast.

Next, have all error messages be caught by Horde.  For now, this means
all PHP warnings are output to the Horde DEBUG log rather than to the
screen.  We can play with the various output options in
Horde::errorHandler().

Still need to go through and remove "@" from many function calls.  These
suppressions can result in the WSOD and make for difficult debugging.
Going forward, we should only be concerned with suppressing warnings
that we know aren't critical (e.g. unserialize(), htmlspecialchars()).
21 files changed:
framework/Core/lib/Horde.php
framework/Core/lib/Horde/Core/Log/Logger.php
framework/Db/lib/Horde/Db/Adapter/Mysql.php
framework/Db/lib/Horde/Db/Adapter/Mysqli.php
framework/Db/lib/Horde/Db/Adapter/Pdo/Base.php
framework/Feed/lib/Horde/Feed/Entry/Atom.php
framework/Image/lib/Horde/Image/Gd.php
framework/Imap_Client/lib/Horde/Imap/Client/Cclient.php
framework/Imap_Client/lib/Horde/Imap/Client/Socket.php
framework/Imap_Client/lib/Horde/Imap/Client/Socket/Pop3.php
framework/Imap_Client/lib/Horde/Imap/Client/Utf7imap.php
framework/Memcache/lib/Horde/Memcache.php
framework/Text_Filter/lib/Horde/Text/Filter/Text2html.php
framework/Util/lib/Horde/String.php
framework/Xml_Element/lib/Horde/Xml/Element.php
horde/docs/CODING_STANDARDS
horde/lib/core.php
imp/config/hooks.php.dist
imp/lib/Compose.php
imp/lib/Ui/Mailbox.php
kronolith/lib/Event.php