Do not let Crypt_Blowfish die on exceptions.
authorGunnar Wrobel <p@rdus.de>
Wed, 17 Nov 2010 16:30:50 +0000 (17:30 +0100)
committerGunnar Wrobel <p@rdus.de>
Tue, 30 Nov 2010 12:48:26 +0000 (13:48 +0100)
commit8788576ba057f7b67c1e402271cd02d701ddda39
treed1bbe561c1216019be4825ac5187d0637e76c0ba
parent6ee5466c678513071352b231e6eb4e761c37fa6a
Do not let Crypt_Blowfish die on exceptions.

I'm not 100% certain this commit introduces the best way of dealing
with Crypt_Blowfish errors. As far as I can see there are four
situations that Crypt_Blowfish considers to be an error. In each of
these cases the library will unconditionally raise a PEAR error with
the mode "PEAR_ERROR_DIE". Which will unconditionally kill us.

Apparently one such situation has already been hit (commit
271ce27ceee4749c667b3d0b51be8947c915472d).

Now we are double checking input in both Horde_Secret and
Crypt_Blowfish but on the other hand we don't have to check the return
values anymore.
framework/Secret/lib/Horde/Secret.php
framework/Secret/lib/Horde/Secret/Exception.php
framework/Secret/test/Horde/Secret/Autoload.php
framework/Secret/test/Horde/Secret/Stub/Message.php [new file with mode: 0644]
framework/Secret/test/Horde/Secret/Unit/SecretTest.php