Need IMAP port to produce truly unique cache ID

diff --git a/framework/Imap_Client/lib/Horde/Imap/Client/Base.php b/framework/Imap_Client/lib/Horde/Imap/Client/Base.php
index 9a6028b..0ffb03f 100644 (file)
--- a/framework/Imap_Client/lib/Horde/Imap/Client/Base.php
+++ b/framework/Imap_Client/lib/Horde/Imap/Client/Base.php
@@ -215,6 +215,7 @@ abstract class Horde_Imap_Client_Base
             $this->_cache = Horde_Imap_Client_Cache::singleton(array_merge($p['cache'], array(
                 'debug' => $this->_debug,
                 'hostspec' => $p['hostspec'],
+                'port' => $p['port'],
                 'username' => $p['username']
             )));
         }

diff --git a/framework/Imap_Client/lib/Horde/Imap/Client/Cache.php b/framework/Imap_Client/lib/Horde/Imap/Client/Cache.php
index e527418..9343c56 100644 (file)
--- a/framework/Imap_Client/lib/Horde/Imap/Client/Cache.php
+++ b/framework/Imap_Client/lib/Horde/Imap/Client/Cache.php
@@ -10,6 +10,7 @@
  * 'driver' - (string) The Horde_Cache driver to use.
  * 'driver_params' - (string) The params to pass to the Horde_Cache driver.
  * 'hostspec' - (string) The IMAP hostspec.
+ * 'port' - (string) The IMAP port.
  * 'username' - (string) The IMAP username.
  *
  * Optional Parameters:
@@ -115,8 +116,9 @@ class Horde_Imap_Client_Cache
     {
         if (empty($params['driver']) ||
             empty($params['driver_params']) ||
-            empty($params['username']) ||
-            empty($params['hostspec'])) {
+            empty($params['hostspec']) ||
+            empty($params['port']) ||
+            empty($params['username'])) {
             throw new Horde_Imap_Client_Exception('Missing required parameters to Horde_Imap_Client_Cache.');
         }
 
@@ -152,6 +154,7 @@ class Horde_Imap_Client_Cache
             'debug' => empty($params['debug']) ? false : $params['debug'],
             'hostspec' => $params['hostspec'],
             'lifetime' => empty($params['lifetime']) ? 604800 : intval($params['lifetime']),
+            'port' => $params['port'],
             'slicesize' => empty($params['slicesize']) ? 50 : intval($params['slicesize']),
             'username' => $params['username']
         );
@@ -207,8 +210,8 @@ class Horde_Imap_Client_Cache
      */
     protected function _getCID($mailbox, $slice)
     {
-        /* Cache ID = "prefix | username | mailbox | hostspec | slice" */
-        return 'horde_imap_client|' . $this->_params['username'] . '|' . $mailbox . '|' . $this->_params['hostspec'] . '|' . $slice;
+        /* Cache ID = prefix | username | mailbox | hostspec | port | slice */
+        return implode('|', array('horde_imap_client', $this->_params['username'], $mailbox, $this->_params['hostspec'], $this->_params['port'], $slice));
     }
 
     /**