Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51588

Make it easier to extend the AccessLogValve to add support for custom elements.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1152601 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/java/org/apache/catalina/valves/AccessLogValve.java b/java/org/apache/catalina/valves/AccessLogValve.java
index e737649..0b6e8e5 100644 (file)
--- a/java/org/apache/catalina/valves/AccessLogValve.java
+++ b/java/org/apache/catalina/valves/AccessLogValve.java
@@ -1912,7 +1912,7 @@ public class AccessLogValve extends ValveBase implements AccessLog {
     /**
      * create an AccessLogElement implementation which needs header string
      */
-    private AccessLogElement createAccessLogElement(String header, char pattern) {
+    protected AccessLogElement createAccessLogElement(String header, char pattern) {
         switch (pattern) {
         case 'i':
             return new HeaderElement(header);
@@ -1934,7 +1934,7 @@ public class AccessLogValve extends ValveBase implements AccessLog {
     /**
      * create an AccessLogElement implementation
      */
-    private AccessLogElement createAccessLogElement(char pattern) {
+    protected AccessLogElement createAccessLogElement(char pattern) {
         switch (pattern) {
         case 'a':
             return new RemoteAddrElement();

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 72c2222..2a99a4b 100644 (file)
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -105,6 +105,10 @@
         recoverable (or might be recoverable) when loading classes during
         HandlesTypes processing. (markt)
       </fix>
+      <fix>
+        <bug>51588</bug>: Make it easier to extend the AccessLogValve to add
+        support for custom elements. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">