Review from kkolinko

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1101018 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/java/org/apache/catalina/valves/RemoteIpValve.java b/java/org/apache/catalina/valves/RemoteIpValve.java
index 6fb329b..0d2d18a 100644 (file)
--- a/java/org/apache/catalina/valves/RemoteIpValve.java
+++ b/java/org/apache/catalina/valves/RemoteIpValve.java
@@ -700,9 +700,11 @@ public class RemoteIpValve extends ValveBase {
                 try {
                     port = Integer.parseInt(portHeaderValue);
                 } catch (NumberFormatException nfe) {
-                    log.debug(sm.getString(
-                            "remoteIpValve.invalidPortHeader",
-                            portHeaderValue, portHeader), nfe);
+                    if (log.isDebugEnabled()) {
+                        log.debug(sm.getString(
+                                "remoteIpValve.invalidPortHeader",
+                                portHeaderValue, portHeader), nfe);
+                    }
                 }
             }
         }