Don't leak Horde_Http_Client exceptions
authorMichael J. Rubinsky <mrubinsk@horde.org>
Mon, 20 Jul 2009 22:32:36 +0000 (18:32 -0400)
committerMichael J. Rubinsky <mrubinsk@horde.org>
Mon, 20 Jul 2009 22:33:01 +0000 (18:33 -0400)
framework/Oauth/lib/Horde/Oauth/Consumer.php

index f4d8720..baf4ebd 100644 (file)
@@ -68,10 +68,14 @@ class Horde_Oauth_Consumer
 
         $client = new Horde_Http_Client;
 
-        $response = $client->post(
-            $this->requestTokenUrl,
-            $request->buildHttpQuery()
-        );
+        try {
+            $response = $client->post(
+                $this->requestTokenUrl,
+                $request->buildHttpQuery()
+            );
+        } catch (Horde_Http_Client_Exception $e) {
+            throw new Horde_Oauth_Exception($e->getMessage());
+        }
 
         return Horde_Oauth_Token::fromString($response->getBody());
     }
@@ -108,10 +112,14 @@ class Horde_Oauth_Consumer
         $request->sign($this->signatureMethod, $this, $token);
 
         $client = new Horde_Http_Client;
-        $response = $client->post(
-            $this->accessTokenUrl,
-            $request->buildHttpQuery()
-        );
+        try {
+            $response = $client->post(
+                $this->accessTokenUrl,
+                $request->buildHttpQuery()
+            );
+        } catch (Horde_Http_Client_Exception $e) {
+            throw new Horde_Oauth_Exception($e->getMessage());
+        }
 
         return Horde_Oauth_Token::fromString($response->getBody());
     }