Fix FindBugs warnings in StandardHost

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1057246 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/java/org/apache/catalina/core/StandardHost.java b/java/org/apache/catalina/core/StandardHost.java
index fc442e8..bda6008 100644 (file)
--- a/java/org/apache/catalina/core/StandardHost.java
+++ b/java/org/apache/catalina/core/StandardHost.java
@@ -711,28 +711,27 @@ public class StandardHost extends ContainerBase implements Host {
     protected synchronized void startInternal() throws LifecycleException {
         
         // Set error report valve
-        if ((errorReportValveClass != null)
-            && (!errorReportValveClass.equals(""))) {
+        String errorValve = getErrorReportValveClass();
+        if ((errorValve != null) && (!errorValve.equals(""))) {
             try {
                 boolean found = false;
                 Valve[] valves = getPipeline().getValves();
                 for (Valve valve : valves) {
-                    if (errorReportValveClass.equals(
-                            valve.getClass().getName())) {
+                    if (errorValve.equals(valve.getClass().getName())) {
                         found = true;
                         break;
                     }
                 }
                 if(!found) {
-                    Valve valve = (Valve) Class.forName(errorReportValveClass).
-                            newInstance();
+                    Valve valve =
+                        (Valve) Class.forName(errorValve).newInstance();
                     getPipeline().addValve(valve);
                 }
             } catch (Throwable t) {
                 ExceptionUtils.handleThrowable(t);
-                log.error(sm.getString
-                    ("standardHost.invalidErrorReportValveClass", 
-                     errorReportValveClass), t);
+                log.error(sm.getString(
+                        "standardHost.invalidErrorReportValveClass",
+                        errorValve), t);
             }
         }
         super.startInternal();

diff --git a/res/findbugs/filter-false-positives.xml b/res/findbugs/filter-false-positives.xml
index 141f5a1..e8dee4c 100644 (file)
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -1,6 +1,11 @@
 <FindBugsFilter>
   <!--  Considered to be false positives -->
   <Match>
+    <Class name="org.apache.catalina.core.StandardHost" />
+    <Method name="findReloadedContextMemoryLeaks" />
+    <Bug code="Dm" />
+  </Match>
+  <Match>
     <Class name="org.apache.catalina.startup.HostConfig" />
     <Method name="checkResources" />
     <Bug code="SWL" />