setPermission() already saves the share.

diff --git a/ansel/lib/Storage.php b/ansel/lib/Storage.php
index 3fff108..d38365d 100644 (file)
--- a/ansel/lib/Storage.php
+++ b/ansel/lib/Storage.php
@@ -213,7 +213,7 @@ class Ansel_Storage
                 }
             }
         }
-        $gallery->setPermission($perm, true);
+        $gallery->setPermission($perm);
 
         /* Initial tags */
         if (count($tags)) {

diff --git a/ansel/perms.php b/ansel/perms.php
index 1e8662d..82510b6 100644 (file)
--- a/ansel/perms.php
+++ b/ansel/perms.php
@@ -233,7 +233,6 @@ case 'editforminherit':
         }
 
         $share->setPermission($perm);
-        $share->save();
 
         /* If we were asked to, push permissions to all child shares
          * to. */

diff --git a/kronolith/lib/Kronolith.php b/kronolith/lib/Kronolith.php
index 0fe7c1c..e843aaa 100644 (file)
--- a/kronolith/lib/Kronolith.php
+++ b/kronolith/lib/Kronolith.php
@@ -1151,7 +1151,6 @@ class Kronolith
                             $perm->addGroupPermission($group_id, $perm_value, false);
                         }
                         $share->setPermission($perm);
-                        $share->save();
                         $GLOBALS['notification']->push(sprintf(_("New calendar created and automatically shared with the following group(s): %s."), implode(', ', $group_list)), 'horde.success');
                     }
                 } catch (Horde_Group_Exception $e) {}
@@ -1940,8 +1939,7 @@ class Kronolith
             }
         }
         try {
-            $share->setPermission($perm, false);
-            $share->save();
+            $share->setPermission($perm);
         } catch (Horde_Share_Exception $e) {
             throw new Kronolith_Exception($e);
         }

diff --git a/trean/perms.php b/trean/perms.php
index 61190e3..df97ad8 100644 (file)
--- a/trean/perms.php
+++ b/trean/perms.php
@@ -217,7 +217,6 @@ case 'editforminherit':
         }
 
         $share->setPermission($perm);
-        $share->save();
 
         /* If we were asked to, push permissions to all child shares
          * to. */