Fix some IMP preferences UI issues

diff --git a/imp/lib/Prefs/Ui.php b/imp/lib/Prefs/Ui.php
index fd4e442..915c52c 100644 (file)
--- a/imp/lib/Prefs/Ui.php
+++ b/imp/lib/Prefs/Ui.php
@@ -789,7 +789,6 @@ class IMP_Prefs_Ui
         $t->set('nofolder', IMP::PREF_NO_FOLDER);
         $t->set('flist', IMP::flistSelect(array(
             'filter' => array('INBOX'),
-            'heading' => _("Create a new drafts folder"),
             'new_folder' => true,
             'selected' => IMP::folderPref($GLOBALS['prefs']->getValue('drafts_folder'), true)
         )));
@@ -1439,7 +1438,6 @@ class IMP_Prefs_Ui
         $t->set('nofolder', IMP::PREF_NO_FOLDER);
         $t->set('flist', IMP::flistSelect(array(
             'filter' => array('INBOX'),
-            'heading' => _("Create a new Spam folder"),
             'new_folder' => true,
             'selected' => IMP::folderPref($GLOBALS['prefs']->getValue('spam_folder'), true)
         )));
@@ -1591,7 +1589,6 @@ class IMP_Prefs_Ui
         $t->set('vtrash_select', $use_vtrash);
         $t->set('flist', IMP::flistSelect(array(
             'filter' => array('INBOX'),
-            'heading' => _("Create a new trash folder"),
             'new_folder' => true,
             'selected' => ($use_vtrash ? null : IMP::folderPref($GLOBALS['prefs']->getValue('trash_folder'), true))
         )));
@@ -1657,18 +1654,19 @@ class IMP_Prefs_Ui
         if ($folder == IMP::PREF_NO_FOLDER) {
             $prefs->setValue($pref, '');
         } else {
-            if (empty($folder) && !empty($new)) {
+            if (!empty($new)) {
                 $folder = $GLOBALS['imp_imap']->appendNamespace($new);
-                if (!$GLOBALS['injector']->getInstance('IMP_Folder')->create($folder, $GLOBALS['prefs']->getValue('subscribe'))) {
+                if (!$GLOBALS['injector']->getInstance('IMP_Folder')->create($folder, $prefs->getValue('subscribe'))) {
                     $folder = null;
                 }
             }
 
-            if (!empty($folder)) {
-                $prefs->setValue($pref, IMP::folderPref($folder, false));
-                return true;
+            if (strlen($folder)) {
+                return $prefs->setValue($pref, IMP::folderPref($folder, false));
             }
         }
+
+        return false;
     }
 
 }

diff --git a/imp/templates/prefs/drafts.html b/imp/templates/prefs/drafts.html
index dc253dc..f471799 100644 (file)
--- a/imp/templates/prefs/drafts.html
+++ b/imp/templates/prefs/drafts.html
@@ -3,7 +3,6 @@
   <tag:label />
  </div>
  <div>
-  <input type="hidden" name="drafts_new" id="drafts_new" value="" />
   <select id="drafts" name="drafts">
    <option value="<tag:nofolder />"><gettext>None</gettext></option>
    <tag:flist />

diff --git a/imp/templates/prefs/spam.html b/imp/templates/prefs/spam.html
index 963ea08..d3d9ae6 100644 (file)
--- a/imp/templates/prefs/spam.html
+++ b/imp/templates/prefs/spam.html
@@ -3,7 +3,6 @@
   <tag:label />
  </div>
  <div>
-  <input type="hidden" name="spam_new" id="spam_new" value="" />
   <select id="spam" name="spam">
    <option value="<tag:nofolder />"><gettext>None</gettext></option>
    <tag:flist />

diff --git a/imp/templates/prefs/trash.html b/imp/templates/prefs/trash.html
index b78db8c..3706418 100644 (file)
--- a/imp/templates/prefs/trash.html
+++ b/imp/templates/prefs/trash.html
@@ -3,7 +3,6 @@
   <tag:label />
  </div>
  <div>
-  <input type="hidden" name="trash_new" id="trash_new" value="" />
   <select id="trash" name="trash">
    <option value="<tag:nofolder />"><gettext>None</gettext></option>
    <option value="<tag:vtrash />"<if:vtrash_select> selected="selected"</if:vtrash_select>><gettext>Use Virtual Trash</gettext></option>