Unused global variable
authorMichael J. Rubinsky <mrubinsk@horde.org>
Wed, 19 May 2010 15:45:02 +0000 (11:45 -0400)
committerMichael J. Rubinsky <mrubinsk@horde.org>
Wed, 19 May 2010 15:45:02 +0000 (11:45 -0400)
framework/Image/lib/Horde/Image/Exif/Parser/Canon.php
framework/Image/lib/Horde/Image/Exif/Parser/Olympus.php

index ad43d1f..5a68b4c 100644 (file)
@@ -516,11 +516,7 @@ class Horde_Image_Exif_Parser_Canon extends Horde_Image_Exif_Parser_Base
                     $value = Horde_Image_Exif::intel2Moto($value);
                 }
                 $v = fseek($seek, $globalOffset+hexdec($value));  //offsets are from TIFF header which is 12 bytes from the start of the file
-                if (isset($GLOBALS['exiferFileSize'])) {
-                    $exiferFileSize = $GLOBALS['exiferFileSize'];
-                } else {
-                    $exiferFileSize = 0;
-                }
+                $exiferFileSize = 0;
                 if ($v == 0 && $bytesofdata < $exiferFileSize) {
                     $data = fread($seek, $bytesofdata);
                 } elseif ($v == -1) {
index 6e63936..5da09e1 100644 (file)
@@ -179,12 +179,9 @@ class Horde_Image_Exif_Parser_Olympus extends Horde_Image_Exif_Parser_Base
                 $value = bin2hex($value);
                 if($intel==1) $value = Horde_Image_Exif::intel2Moto($value);
                 $v = fseek($seek,$globalOffset+hexdec($value));  //offsets are from TIFF header which is 12 bytes from the start of the file
-                if(isset($GLOBALS['exiferFileSize']) && $v == 0 && $bytesofdata < $GLOBALS['exiferFileSize']) {
-                    $data = fread($seek, $bytesofdata);
-                } else {
-                    $result['Errors'] = $result['Errors']++;
-                    $data = '';
-                }
+                $result['Errors'] = $result['Errors']++;
+                $data = '';
+
             }
             $formated_data = self::_formatData($type,$tag,$intel,$data);
             $result['SubIFD']['MakerNote'][$tag_name] = $formated_data;