Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51467

start() not run()
Patch provided by Felix Schumacher

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1142643 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/java/org/apache/catalina/core/StandardContext.java b/java/org/apache/catalina/core/StandardContext.java
index b285820..41f0617 100644 (file)
--- a/java/org/apache/catalina/core/StandardContext.java
+++ b/java/org/apache/catalina/core/StandardContext.java
@@ -5478,7 +5478,7 @@ public class StandardContext extends ContainerBase
             
             Thread t = new Thread(stop);
             t.setName("stop children - " + getObjectName().toString());
-            t.run();
+            t.start();
             try {
                 t.join();
             } catch (InterruptedException e) {

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 8ffd9a7..1aba284 100644 (file)
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -65,6 +65,11 @@
         <bug>51466</bug>: Correct comment typos in HostManagerServlet. Patch
         provided by Felix Schumacher. (markt)
       </fix>
+      <fix>
+        <bug>51467</bug>: Invoke Thread.start() rather than Thread.run() so that
+        listeners and filters are stopped in a separate thread rather than the
+        current thread. Patch provided by Felix Schumacher. (markt)  
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Other">