No need to return anything.

diff --git a/framework/Share/lib/Horde/Share/Object.php b/framework/Share/lib/Horde/Share/Object.php
index c9c1153..9c100cf 100644 (file)
--- a/framework/Share/lib/Horde/Share/Object.php
+++ b/framework/Share/lib/Horde/Share/Object.php
@@ -246,8 +246,6 @@ abstract class Horde_Share_Object implements Serializable
      * @param Horde_Perms_Permission $perm  Permission object.
      * @param boolean $update               Should the share be saved
      *                                      after this operation?
-     *
-     * @return boolean
      */
     abstract public function setPermission($perm, $update = true);
 

diff --git a/framework/Share/lib/Horde/Share/Object/Sql.php b/framework/Share/lib/Horde/Share/Object/Sql.php
index b76b9b6..c5c75bf 100644 (file)
--- a/framework/Share/lib/Horde/Share/Object/Sql.php
+++ b/framework/Share/lib/Horde/Share/Object/Sql.php
@@ -236,16 +236,13 @@ class Horde_Share_Object_Sql extends Horde_Share_Object implements Serializable
      * @param Horde_Perms_Permission $perm  Permission object.
      * @param boolean $update               Should the share be saved
      *                                      after this operation?
-     *
-     * @return boolean
      */
     public function setPermission($perm, $update = true)
     {
         $this->data['perm'] = $perm->getData();
         if ($update) {
-            return $this->save();
+            $this->save();
         }
-        return true;
     }
 
     /**