Findbugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060772 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/res/findbugs/filter-post-7.0.x-fixes.xml b/res/findbugs/filter-post-7.0.x-fixes.xml
index 015dcad..84d2a50 100644 (file)
--- a/res/findbugs/filter-post-7.0.x-fixes.xml
+++ b/res/findbugs/filter-post-7.0.x-fixes.xml
@@ -38,10 +38,18 @@
     <Method name="writeObject" />
     <Bug code="Se" />
   </Match>
-  <!-- Refactor Integer constants to an enum -->
+  <!-- Re-factor Integer constants to an enum -->
   <Match>
     <Class name="org.apache.catalina.startup.ClassLoaderFactory" />
     <Method name="createClassLoader" />
     <Bug code="RC" />
   </Match>
+  <!-- Re-factor to only have the thread running when an instance of the     -->
+  <!-- handler is active -->
+  <Match>
+    <Class name="org.apache.juli.AsyncFileHandler$LoggerThread"/>
+    <Method name="run"/>
+    <Bug code="IL"/>
+  </Match>
+  
 </FindBugsFilter>
\ No newline at end of file

diff --git a/webapps/examples/WEB-INF/classes/async/Stockticker.java b/webapps/examples/WEB-INF/classes/async/Stockticker.java
index efe404c..889d06f 100644 (file)
--- a/webapps/examples/WEB-INF/classes/async/Stockticker.java
+++ b/webapps/examples/WEB-INF/classes/async/Stockticker.java
@@ -99,7 +99,7 @@ public class Stockticker implements Runnable {
         public void tick(Stock stock);
     }
     
-    public static class Stock {
+    public static final class Stock implements Cloneable {
         protected static DecimalFormat df = new DecimalFormat("0.00");
         protected String symbol = "";
         protected double value = 0.0d;