things can go wrong if substr converts an empty string to false

diff --git a/framework/Vcs/lib/Horde/Vcs/Git.php b/framework/Vcs/lib/Horde/Vcs/Git.php
index 7bb1087..cad8a43 100644 (file)
--- a/framework/Vcs/lib/Horde/Vcs/Git.php
+++ b/framework/Vcs/lib/Horde/Vcs/Git.php
@@ -353,7 +353,7 @@ class Horde_Vcs_Directory_Git extends Horde_Vcs_Directory
 
         $dir = $this->queryDir();
         if (substr($dir, 0, 1) == '/') {
-            $dir = substr($dir, 1);
+            $dir = (string)substr($dir, 1);
         }
         if (strlen($dir) && substr($dir, -1) != '/') {
             $dir .= '/';