Clarify error messages in *.sh files to mention that if a script is not found it...

that it does exist but does not have the execute permission.
http://markmail.org/message/k2ynjwbqjcver6ka

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1088179 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/bin/configtest.sh b/bin/configtest.sh
index f854b92..597d915 100755 (executable)
--- a/bin/configtest.sh
+++ b/bin/configtest.sh
@@ -56,6 +56,7 @@ if $os400; then
 else
   if [ ! -x "$PRGDIR"/"$EXECUTABLE" ]; then
     echo "Cannot find $PRGDIR/$EXECUTABLE"
+    echo "The file is absent or does not have execute permission"
     echo "This file is needed to run this program"
     exit 1
   fi

diff --git a/bin/digest.sh b/bin/digest.sh
index 4845c20..2bffe2a 100755 (executable)
--- a/bin/digest.sh
+++ b/bin/digest.sh
@@ -40,6 +40,7 @@ EXECUTABLE=tool-wrapper.sh
 # Check that target executable exists
 if [ ! -x "$PRGDIR"/"$EXECUTABLE" ]; then
   echo "Cannot find $PRGDIR/$EXECUTABLE"
+  echo "The file is absent or does not have execute permission"
   echo "This file is needed to run this program"
   exit 1
 fi

diff --git a/bin/shutdown.sh b/bin/shutdown.sh
index 36fd211..0aa93ef 100755 (executable)
--- a/bin/shutdown.sh
+++ b/bin/shutdown.sh
@@ -40,6 +40,7 @@ EXECUTABLE=catalina.sh
 # Check that target executable exists
 if [ ! -x "$PRGDIR"/"$EXECUTABLE" ]; then
   echo "Cannot find $PRGDIR/$EXECUTABLE"
+  echo "The file is absent or does not have execute permission"
   echo "This file is needed to run this program"
   exit 1
 fi

diff --git a/bin/startup.sh b/bin/startup.sh
index 4e4e9fe..1e2e76f 100755 (executable)
--- a/bin/startup.sh
+++ b/bin/startup.sh
@@ -56,6 +56,7 @@ if $os400; then
 else
   if [ ! -x "$PRGDIR"/"$EXECUTABLE" ]; then
     echo "Cannot find $PRGDIR/$EXECUTABLE"
+    echo "The file is absent or does not have execute permission"
     echo "This file is needed to run this program"
     exit 1
   fi

diff --git a/bin/version.sh b/bin/version.sh
index b6ed1c6..07ee7f3 100755 (executable)
--- a/bin/version.sh
+++ b/bin/version.sh
@@ -40,6 +40,7 @@ EXECUTABLE=catalina.sh
 # Check that target executable exists
 if [ ! -x "$PRGDIR"/"$EXECUTABLE" ]; then
   echo "Cannot find $PRGDIR/$EXECUTABLE"
+  echo "The file is absent or does not have execute permission"
   echo "This file is needed to run this program"
   exit 1
 fi

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 1a7af07..280f27b 100644 (file)
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -59,6 +59,14 @@
       </update>
     </changelog>
   </subsection>
+  <subsection name="Other">
+    <changelog>
+      <update>
+        Clarify error messages in *.sh files to mention that if a script is
+        not found it might be because execute permission is needed. (kkolinko)
+      </update>
+    </changelog>
+  </subsection>
 </section>
 <section name="Tomcat 7.0.12 (markt)">
   <subsection name="Catalina">