Use parens to make negation more clear with instanceof.

diff --git a/imp/folders.php b/imp/folders.php
index 8975dd9..c6dad36 100644 (file)
--- a/imp/folders.php
+++ b/imp/folders.php
@@ -155,7 +155,7 @@ case 'import_mbox':
     $import_folder = Horde_Util::getFormData('import_folder');
     if (!empty($import_folder)) {
         $res = $browser->wasFileUploaded('mbox_upload', _("mailbox file"));
-        if (!$res instanceof PEAR_Error) {
+        if (!($res instanceof PEAR_Error)) {
             $res = $imp_folder->importMbox(Horde_String::convertCharset($import_folder, $charset, 'UTF7-IMAP'), $_FILES['mbox_upload']['tmp_name']);
             $mbox_name = basename(Horde_Util::dispelMagicQuotes($_FILES['mbox_upload']['name']));
             if ($res === false) {

diff --git a/imp/lib/IMP.php b/imp/lib/IMP.php
index c428ea4..c15924e 100644 (file)
--- a/imp/lib/IMP.php
+++ b/imp/lib/IMP.php
@@ -152,7 +152,7 @@ class IMP
         $escapeName = htmlspecialchars($newName, ENT_COMPAT, Horde_Nls::getCharset());
         error_reporting($old_error);
 
-        return (!empty($contact_link) && !$contact_link instanceof PEAR_Error)
+        return (!empty($contact_link) && !($contact_link instanceof PEAR_Error))
             ? Horde::link(Horde::url($contact_link), sprintf(_("Go to address book entry of \"%s\""), $newName)) . $escapeName . '</a>'
             : $escapeName;
     }