Misc clean-up

- remove unused code
- suppress FindBugs false positives
- add javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075083 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/java/org/apache/catalina/authenticator/AuthenticatorBase.java b/java/org/apache/catalina/authenticator/AuthenticatorBase.java
index 2983fca..877d269 100644 (file)
--- a/java/org/apache/catalina/authenticator/AuthenticatorBase.java
+++ b/java/org/apache/catalina/authenticator/AuthenticatorBase.java
@@ -92,12 +92,6 @@ public abstract class AuthenticatorBase extends ValveBase
 
 
     /**
-     * The number of random bytes to include when generating a
-     * session identifier.
-     */
-    protected static final int SESSION_ID_BYTES = 16;
-
-    /**
      * Authentication header
      */
     protected static final String AUTH_HEADER_NAME = "WWW-Authenticate";
@@ -789,6 +783,15 @@ public abstract class AuthenticatorBase extends ValveBase
 
     protected abstract String getAuthMethod();
 
+    /**
+     * Process the login request.
+     * 
+     * @param request   Associated request
+     * @param username  The user
+     * @param password  The password
+     * @return          The authenticated Principal
+     * @throws ServletException
+     */
     protected Principal doLogin(Request request, String username,
             String password) throws ServletException {
         Principal p = context.getRealm().authenticate(username, password);

diff --git a/res/findbugs/filter-false-positives.xml b/res/findbugs/filter-false-positives.xml
index 04a1ce3..fb8dfe8 100644 (file)
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -37,6 +37,11 @@
     <Bug code="REC"/>
   </Match>
   <Match>
+    <Class name="org.apache.catalina.authenticator.AuthenticatorBase"/>
+    <Field name="sessionIdGenerator"/>
+    <Bug code="IS"/>
+  </Match>
+  <Match>
     <!-- JNI library can only be loaded once so statics are appropriate -->
     <Class name="org.apache.catalina.core.AprLifecycleListener" />
     <Bug code="ST" />