Too many htmlspecialchars in link() for title attribute

For example, things like '<' should be specified as '&lt;', NOT
'&amp;&lt;'

diff --git a/framework/Core/lib/Horde.php b/framework/Core/lib/Horde.php
index f764f8b..16aa953 100644 (file)
--- a/framework/Core/lib/Horde.php
+++ b/framework/Core/lib/Horde.php
@@ -1293,9 +1293,8 @@ HTML;
                 $old_error = error_reporting(0);
                 $title = str_replace(
                     array("\r", "\n"), '',
-                    htmlspecialchars(
-                        nl2br(htmlspecialchars($title, ENT_QUOTES, $charset)),
-                        ENT_QUOTES, $charset));
+                    nl2br(htmlspecialchars($title, ENT_QUOTES, $charset))
+                );
                 error_reporting($old_error);
             }
             $attributes['title.raw'] = $title;