Only show backtrace if logging at DEBUG level

Otherwise, things like framework libraries that throw exceptions and
provide way of logging exceptions (e.g. Horde_Imap_Client) give
backtraces for items that should not need to be logged (e.g.
authentication failures).

diff --git a/framework/Core/lib/Horde/Core/Log/Logger.php b/framework/Core/lib/Horde/Core/Log/Logger.php
index 5e88909..b62b9c6 100644 (file)
--- a/framework/Core/lib/Horde/Core/Log/Logger.php
+++ b/framework/Core/lib/Horde/Core/Log/Logger.php
@@ -131,10 +131,9 @@ class Horde_Core_Log_Logger extends Horde_Log_Logger
         parent::log($eventob);
 
         /* If logging an exception, log the backtrace too. */
-        if ($event instanceof Exception) {
-            if (class_exists('Horde_Support_Backtrace')) {
-                parent::log((string)new Horde_Support_Backtrace($event), $priority);
-            }
+        if (($event instanceof Exception) &&
+            class_exists('Horde_Support_Backtrace')) {
+            parent::log((string)new Horde_Support_Backtrace($event), Horde_Log::DEBUG);
         }
 
         /* Restore original locale and timezone. */