Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48983

Additional debug logging for when RemoteIp(Valve|Filter) is not invoked

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930657 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/.classpath b/.classpath
index fd02953..2175b66 100644 (file)
--- a/.classpath
+++ b/.classpath
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
        <classpathentry kind="src" path="java"/>
-       <classpathentry kind="src" path="test"/>
+       <classpathentry excluding="org/apache/catalina/tribes/|org/apache/catalina/valves/Benchmarks.java" kind="src" path="test"/>
        <classpathentry kind="src" path="webapps/examples/WEB-INF/classes"/>
        <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
        <classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/3"/>

diff --git a/java/org/apache/catalina/filters/RemoteIpFilter.java b/java/org/apache/catalina/filters/RemoteIpFilter.java
index e54a5ef..b6f9dfc 100644 (file)
--- a/java/org/apache/catalina/filters/RemoteIpFilter.java
+++ b/java/org/apache/catalina/filters/RemoteIpFilter.java
@@ -789,6 +789,10 @@ public class RemoteIpFilter implements Filter {
             }
             chain.doFilter(xRequest, response);
         } else {
+            if (log.isDebugEnabled()) {
+                log.debug("Skip RemoteIpFilter for request " + request.getRequestURI() + " with originalRemoteAddr '"
+                        + request.getRemoteAddr() + "'");
+            }
             chain.doFilter(request, response);
         }
         

diff --git a/java/org/apache/catalina/valves/RemoteIpValve.java b/java/org/apache/catalina/valves/RemoteIpValve.java
index 795693b..7c0c258 100644 (file)
--- a/java/org/apache/catalina/valves/RemoteIpValve.java
+++ b/java/org/apache/catalina/valves/RemoteIpValve.java
@@ -627,6 +627,11 @@ public class RemoteIpValve extends ValveBase {
                           + originalScheme + "' will be seen as newRemoteAddr='" + request.getRemoteAddr() + "', newRemoteHost='"
                           + request.getRemoteHost() + "', newScheme='" + request.getScheme() + "', newSecure='" + request.isSecure() + "'");
             }
+        } else {
+            if (log.isDebugEnabled()) {
+                log.debug("Skip RemoteIpValve for request " + request.getRequestURI() + " with originalRemoteAddr '"
+                        + request.getRemoteAddr() + "'");
+            }
         }
         try {
             getNext().invoke(request, response);