use less CVS-ish constant names, and use a constant for modified instead of hardcoding 0

diff --git a/chora/patchsets.php b/chora/patchsets.php
index e880a61..3dfea65 100644 (file)
--- a/chora/patchsets.php
+++ b/chora/patchsets.php
@@ -67,7 +67,7 @@ while (list($id, $patchset) = each($patchsets)) {
 
         $file['file'] = Horde::link(Chora::url('patchsets', $member['file'])) . htmlspecialchars($member['file']) . '</a>';
 
-        if ($member['status'] == Horde_Vcs_Patchset::INITIAL) {
+        if ($member['status'] == Horde_Vcs_Patchset::ADDED) {
             $file['from'] = '<ins>' . _("New File") . '</ins>';
             $file['diff'] = '';
         } else {
@@ -75,7 +75,7 @@ while (list($id, $patchset) = each($patchsets)) {
             $file['diff'] = Horde::link(Chora::url('diff', $member['file'], array('r1' => $member['from'], 'r2' => $member['to']))) . ' ' . $diff_img . '</a>';
         }
 
-        if ($member['status'] == Horde_Vcs_Patchset::DEAD) {
+        if ($member['status'] == Horde_Vcs_Patchset::DELETED) {
             $file['to'] = '<del>' . _("Deleted") . '</del>';
             $file['diff'] = '';
         } else {

diff --git a/framework/Vcs/lib/Horde/Vcs.php b/framework/Vcs/lib/Horde/Vcs.php
index 24d3b64..c0de842 100644 (file)
--- a/framework/Vcs/lib/Horde/Vcs.php
+++ b/framework/Vcs/lib/Horde/Vcs.php
@@ -1164,8 +1164,9 @@ abstract class Horde_Vcs_Log
  */
 abstract class Horde_Vcs_Patchset
 {
-    const INITIAL = 1;
-    const DEAD = 2;
+    const MODIFIED = 0;
+    const ADDED = 1;
+    const DELETED = 2;
 
     /**
      * @var array

diff --git a/framework/Vcs/lib/Horde/Vcs/Cvs.php b/framework/Vcs/lib/Horde/Vcs/Cvs.php
index 3ead7a1..33ff5a0 100644 (file)
--- a/framework/Vcs/lib/Horde/Vcs/Cvs.php
+++ b/framework/Vcs/lib/Horde/Vcs/Cvs.php
@@ -797,14 +797,14 @@ class Horde_Vcs_Patchset_Cvs extends Horde_Vcs_Patchset
                 if (!empty($line)) {
                     $parts = explode(':', $line);
                     list($from, $to) = explode('->', $parts[1], 2);
-                    $status = 0;
+                    $status = self::MODIFIED;
 
                     if ($from == 'INITIAL') {
                         $from = null;
-                        $status = self::INITIAL;
+                        $status = self::ADDED;
                     } elseif (substr($to, -6) == '(DEAD)') {
                         $to = null;
-                        $status = self::DEAD;
+                        $status = self::DELETED;
                     }
 
                     $this->_patchsets[$id]['members'][] = array(

diff --git a/framework/Vcs/lib/Horde/Vcs/Git.php b/framework/Vcs/lib/Horde/Vcs/Git.php
index fafccdc..3721f26 100644 (file)
--- a/framework/Vcs/lib/Horde/Vcs/Git.php
+++ b/framework/Vcs/lib/Horde/Vcs/Git.php
@@ -766,18 +766,18 @@ class Horde_Vcs_Patchset_Git extends Horde_Vcs_Patchset
 
             foreach ($log->queryFiles() as $file) {
                 $to = $rev;
-                $status = 0;
+                $status = self::MODIFIED;
 
                 switch ($file['status']) {
                 case 'A':
                     $from = null;
-                    $status = self::INITIAL;
+                    $status = self::ADDED;
                     break;
 
                 case 'D':
                     $from = $to;
                     $to = null;
-                    $status = self::DEAD;
+                    $status = self::DELETED;
                     break;
 
                 default: