From: markt <markt@13f79535-47bb-0310-9956-ffa450edef68>
Date: Sat, 27 Sep 2008 13:12:07 +0000 (+0000)
Subject: Fix HTML decoding bug reported by Find Bugs
X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=019c97406133fc72567b54a75b29231c940d89fc;p=tomcat7.0

Fix HTML decoding bug reported by Find Bugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699635 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/java/org/apache/catalina/ssi/SSIMediator.java b/java/org/apache/catalina/ssi/SSIMediator.java
index 3c9ce97df..561fd5450 100644
--- a/java/org/apache/catalina/ssi/SSIMediator.java
+++ b/java/org/apache/catalina/ssi/SSIMediator.java
@@ -211,10 +211,10 @@ public class SSIMediator {
         if (val.indexOf('$') < 0 && val.indexOf('&') < 0) return val;
         
         // HTML decoding
-        val.replace("&lt;", "<");
-        val.replace("&gt;", ">");
-        val.replace("&quot;", "\"");
-        val.replace("&amp;", "&");
+        val = val.replace("&lt;", "<");
+        val = val.replace("&gt;", ">");
+        val = val.replace("&quot;", "\"");
+        val = val.replace("&amp;", "&");
 
         StringBuffer sb = new StringBuffer(val);
         int charStart = sb.indexOf("&#");