From: markt Date: Fri, 1 Jul 2011 13:41:25 +0000 (+0000) Subject: Fix faulty test X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=3e5f8a2a67fd38964f61d05f5588483b42f79001;p=tomcat7.0 Fix faulty test git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1141935 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/test/org/apache/catalina/core/TestStandardWrapper.java b/test/org/apache/catalina/core/TestStandardWrapper.java index 397a77401..e43be0eb5 100644 --- a/test/org/apache/catalina/core/TestStandardWrapper.java +++ b/test/org/apache/catalina/core/TestStandardWrapper.java @@ -332,8 +332,13 @@ public class TestStandardWrapper extends TomcatBaseTest { public static final int BUG51445_THREAD_COUNT = 5; + + public static CountDownLatch latch = null; public void testBug51445AddServlet() throws Exception { + + latch = new CountDownLatch(BUG51445_THREAD_COUNT); + Tomcat tomcat = getTomcatInstance(); // Must have a real docBase - just use temp @@ -358,19 +363,25 @@ public class TestStandardWrapper extends TomcatBaseTest { } Set servlets = new HashSet(); + // Output the result + for (int i = 0; i < BUG51445_THREAD_COUNT; i ++) { + System.out.println(threads[i].getResult()); + } + // Check the result for (int i = 0; i < BUG51445_THREAD_COUNT; i ++) { String[] results = threads[i].getResult().split(","); assertEquals(2, results.length); assertEquals("10", results[0]); - System.out.println(results[1]); assertFalse(servlets.contains(results[1])); servlets.add(results[1]); } - } public void testBug51445AddChild() throws Exception { + + latch = new CountDownLatch(BUG51445_THREAD_COUNT); + Tomcat tomcat = getTomcatInstance(); // Must have a real docBase - just use temp @@ -398,16 +409,18 @@ public class TestStandardWrapper extends TomcatBaseTest { } Set servlets = new HashSet(); + // Output the result + for (int i = 0; i < BUG51445_THREAD_COUNT; i ++) { + System.out.println(threads[i].getResult()); + } // Check the result for (int i = 0; i < BUG51445_THREAD_COUNT; i ++) { String[] results = threads[i].getResult().split(","); assertEquals(2, results.length); assertEquals("10", results[0]); - System.out.println(results[1]); assertFalse(servlets.contains(results[1])); servlets.add(results[1]); } - } private static class Bug51445Thread extends Thread { @@ -443,9 +456,6 @@ public class TestStandardWrapper extends TomcatBaseTest { private static final long serialVersionUID = 1L; - private static final CountDownLatch latch = - new CountDownLatch(BUG51445_THREAD_COUNT); - private int data = 0; @Override