From: Gunnar Wrobel <p@rdus.de>
Date: Sun, 9 Jan 2011 21:03:33 +0000 (+0100)
Subject: The cached query type must replace the default query.
X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=3f70ec79d7300be2340fcc5f6d203a8f0d46a134;p=horde.git

The cached query type must replace the default query.
---

diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Base.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Base.php
index 98529c7fc..99c23ec26 100644
--- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Base.php
+++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Base.php
@@ -69,7 +69,9 @@ implements Horde_Kolab_Storage
             $this->_master,
             $this->_factory
         );
-        $this->_factory->createListQuery('Base', $list);
+        $list->registerQuery(
+            'Base', $this->_factory->createListQuery('Base', $list)
+        );
         return $list;
     }
 
diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Decorator/Cache.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Decorator/Cache.php
index d9327a0bf..c3155eb9d 100644
--- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Decorator/Cache.php
+++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Decorator/Cache.php
@@ -81,8 +81,11 @@ implements Horde_Kolab_Storage
             $this->_storage->getList(),
             $list_cache
         );
-        $this->_factory->createListQuery(
-            'Cache', $list, array('cache' => $list_cache)
+        $list->registerQuery(
+            'Base',
+            $this->_factory->createListQuery(
+                'Cache', $list, array('cache' => $list_cache)
+            )
         );
         return $list;
     }
diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Factory.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Factory.php
index 53a930646..65db2fe96 100644
--- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Factory.php
+++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Factory.php
@@ -184,7 +184,6 @@ class Horde_Kolab_Storage_Factory
         } else {
             throw new Horde_Kolab_Storage_Exception(sprintf('No such query "%s"!', $name));
         }
-        $list->registerQuery($name, $query);
         return $query;
     }
 
diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/BaseTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/BaseTest.php
index ff3f32078..f2224a4f1 100644
--- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/BaseTest.php
+++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/BaseTest.php
@@ -110,6 +110,7 @@ extends Horde_Kolab_Storage_TestCase
             'Horde_Kolab_Storage_Stub_FactoryQuery',
             $list
         );
+        $list->registerQuery('Horde_Kolab_Storage_Stub_FactoryQuery', $query);
         $this->assertInstanceOf(
             'Horde_Kolab_Storage_Stub_FactoryQuery',
             $list->getQuery('Horde_Kolab_Storage_Stub_FactoryQuery')
diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/CacheTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/CacheTest.php
index cb5169a81..2e630abe4 100644
--- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/CacheTest.php
+++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/CacheTest.php
@@ -347,7 +347,8 @@ extends Horde_Kolab_Storage_TestCase
                 $cache
             )
         );
-        $factory->createListQuery('Base', $list);
+        $query = $factory->createListQuery('Base', $list);
+        $list->registerQuery('Base', $query);
         $this->assertInstanceOf(
             'Horde_Kolab_Storage_Query',
             $list->getQuery('Base')
diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/LogTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/LogTest.php
index 046288577..cff207afc 100644
--- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/LogTest.php
+++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Unit/List/Decorator/LogTest.php
@@ -84,7 +84,8 @@ extends Horde_Kolab_Storage_TestCase
             $this->getNullList($factory),
             $this->getMockLogger()
         );
-        $factory->createListQuery('Base', $list);
+        $query = $factory->createListQuery('Base', $list);
+        $list->registerQuery('Base', $query);
         $this->assertInstanceOf(
             'Horde_Kolab_Storage_Query',
             $list->getQuery('Base')