From: rjung <rjung@13f79535-47bb-0310-9956-ffa450edef68>
Date: Mon, 13 Jun 2011 11:19:23 +0000 (+0000)
Subject: Remove superfluous quotes from thread names for
X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=6f9a9f0098b7a62c437087f6903e28e1bacf3570;p=tomcat7.0

Remove superfluous quotes from thread names for
connection pools.

Example broken thread name: "http-apr-8001"-exec-2
(including leading and intermediate quotes).

Since we never use the names as a full ObjectName,
only as a part of an ObjectName, it is safe to
remove the surrounding quotes from the Protocol name.


git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1135088 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/java/org/apache/coyote/AbstractProtocol.java b/java/org/apache/coyote/AbstractProtocol.java
index e6a6f42b4..8cbc31c80 100644
--- a/java/org/apache/coyote/AbstractProtocol.java
+++ b/java/org/apache/coyote/AbstractProtocol.java
@@ -229,7 +229,8 @@ public abstract class AbstractProtocol implements ProtocolHandler,
             name.append('-');
         }
         name.append(endpoint.getPort());
-        return ObjectName.quote(name.toString());
+        String quotedName = ObjectName.quote(name.toString());
+        return quotedName.substring(1, quotedName.length()-1);
     }
 
     
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e98e9dce6..d598de5e2 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -53,6 +53,10 @@
         Fix unit test for bindOnInit which was failing for APR on some
         platforms. (rjung)
       </fix>
+      <fix>
+        Remove superfluous quotes from thread names for connection pools.
+        (rjung)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Cluster">