From: markt <markt@13f79535-47bb-0310-9956-ffa450edef68>
Date: Sat, 1 Dec 2007 18:26:13 +0000 (+0000)
Subject: Fix bug 43611. Provide an error message if user tries to upload a war for a context... 
X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=72d2815e000d7e7c3ef8beacdd520bc14baacb9c;p=tomcat7.0

Fix bug 43611. Provide an error message if user tries to upload a war for a context defined in server.xml rather than failing silently.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@600177 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/java/org/apache/catalina/manager/HTMLManagerServlet.java b/java/org/apache/catalina/manager/HTMLManagerServlet.java
index 49afafecc..b1d0300c4 100644
--- a/java/org/apache/catalina/manager/HTMLManagerServlet.java
+++ b/java/org/apache/catalina/manager/HTMLManagerServlet.java
@@ -228,6 +228,12 @@ public final class HTMLManagerServlet extends ManagerServlet {
                     path = "/" + basename;
                 }
 
+                if ((host.findChild(path) != null) && !isDeployed(path)) {
+                    message = sm.getString
+                        ("htmlManagerServlet.deployUploadInServerXml", war);
+                    break;
+                }
+
                 if (!isServiced(path)) {
                     addServiced(path);
                     try {
diff --git a/java/org/apache/catalina/manager/LocalStrings.properties b/java/org/apache/catalina/manager/LocalStrings.properties
index d220750b8..eae6fc6e6 100644
--- a/java/org/apache/catalina/manager/LocalStrings.properties
+++ b/java/org/apache/catalina/manager/LocalStrings.properties
@@ -38,6 +38,7 @@ htmlManagerServlet.deployTitle=Deploy
 htmlManagerServlet.deployUpload=WAR file to deploy
 htmlManagerServlet.deployUploadFail=FAIL - Deploy Upload Failed, Exception: {0}
 htmlManagerServlet.deployUploadFile=Select WAR file to upload
+htmlManagerServlet.deployUploadInServerXml=FAIL - War file \"{0}\" cannot be uploaded if context is defined in server.xml 
 htmlManagerServlet.deployUploadNotWar=FAIL - File uploaded \"{0}\" must be a .war
 htmlManagerServlet.deployUploadNoFile=FAIL - File upload failed, no file
 htmlManagerServlet.deployUploadWarExists=FAIL - War file \"{0}\" already exists on server