From: Michael J. Rubinsky Date: Tue, 21 Dec 2010 16:52:20 +0000 (-0500) Subject: even better, no need to pass the charset param if it's utf-8 ... thanks, Jan X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=d5cf1488e12372f7b38c0e88972d8d9666bb772f;p=horde.git even better, no need to pass the charset param if it's utf-8 ... thanks, Jan --- diff --git a/framework/Core/lib/Horde/Core/Ui/VarRenderer/Html.php b/framework/Core/lib/Horde/Core/Ui/VarRenderer/Html.php index 767094da3..d3231fa1b 100644 --- a/framework/Core/lib/Horde/Core/Ui/VarRenderer/Html.php +++ b/framework/Core/lib/Horde/Core/Ui/VarRenderer/Html.php @@ -19,7 +19,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInputDefault($form, &$var, &$vars) { return 'Warning: Unknown variable type ' . - @htmlspecialchars($var->getTypeName(), ENT_QUOTES, 'UTF-8'); + @htmlspecialchars($var->getTypeName(), ENT_QUOTES); } protected function _renderVarInput_number($form, &$var, &$vars) @@ -34,7 +34,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer if (!empty($linfo['mon_decimal_point'])) { $value = str_replace('.', $linfo['mon_decimal_point'], $value); } - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, @@ -45,18 +45,18 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_int($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $this->_getActionScripts($form, $var) ); } protected function _renderVarInput_octal($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, @@ -67,11 +67,11 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_intlist($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $this->_getActionScripts($form, $var) ); } @@ -79,47 +79,47 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_text($form, &$var, &$vars) { $maxlength = $var->type->getMaxLength(); - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, $var->type->getSize(), - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $var->isDisabled() ? ' disabled="disabled" ' : '', empty($maxlength) ? '' : ' maxlength="' . $maxlength . '"', - $this->_getActionScripts($form, $var) + $this->_getActionScripts($form, $var) ); } protected function _renderVarInput_stringlist($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $this->_getActionScripts($form, $var) ); } protected function _renderVarInput_stringarray($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars(implode(', ', $var->getValue($vars)), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars(implode(', ', $var->getValue($vars)), ENT_QUOTES), $this->_getActionScripts($form, $var) ); } protected function _renderVarInput_phone($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $var->isDisabled() ? ' disabled="disabled" ' : '', $this->_getActionScripts($form, $var) ); @@ -132,11 +132,11 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_ipaddress($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $var->isDisabled() ? ' disabled="disabled" ' : '', $this->_getActionScripts($form, $var) ); @@ -144,11 +144,11 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_ip6address($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $var->isDisabled() ? ' disabled="disabled" ' : '', $this->_getActionScripts($form, $var) ); @@ -156,7 +156,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_file($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, @@ -279,7 +279,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer { global $browser; - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); $html = sprintf('', $varname, $varname, @@ -287,7 +287,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer (int)$var->type->getRows(), $this->_getActionScripts($form, $var), $var->isDisabled() ? ' disabled="disabled"' : '', - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8')); + @htmlspecialchars($var->getValue($vars), ENT_QUOTES)); if ($var->type->hasHelper('rte')) { $GLOBALS['injector']->getInstance('Horde_Editor')->initialize( @@ -327,7 +327,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_countedtext($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, @@ -335,12 +335,12 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer (int)$var->type->getRows(), $this->_getActionScripts($form, $var), $var->isDisabled() ? ' disabled="disabled"' : '', - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8')); + @htmlspecialchars($var->getValue($vars), ENT_QUOTES)); } protected function _renderVarInput_address($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, @@ -348,7 +348,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer (int)$var->type->getRows(), $this->_getActionScripts($form, $var), $var->isDisabled() ? ' disabled="disabled"' : '', - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8')); + @htmlspecialchars($var->getValue($vars), ENT_QUOTES)); } protected function _renderVarInput_addresslink($form, &$var, &$vars) @@ -373,27 +373,27 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_date($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $this->_getActionScripts($form, $var)); } protected function _renderVarInput_time($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); return sprintf('', $varname, $varname, - @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'), + @htmlspecialchars($var->getValue($vars), ENT_QUOTES), $this->_getActionScripts($form, $var)); } protected function _renderVarInput_hourminutesecond($form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); $time = $var->type->getTimeParts($var->getValue($vars)); /* Output hours. */ @@ -512,7 +512,7 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer $html = ''; $date_parts = array('month', 'day', 'year'); foreach ($date_parts as $part) { - $varname = @htmlspecialchars($var->getVarName() . '[' . $part . ']', ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName() . '[' . $part . ']', ENT_QUOTES); $html .= sprintf('', $varname, $varname, @@ -546,14 +546,14 @@ class Horde_Core_Ui_VarRenderer_Html extends Horde_Core_Ui_VarRenderer protected function _renderVarInput_sound(&$form, &$var, &$vars) { - $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES, 'UTF-8'); - $value = @htmlspecialchars($var->getValue($vars), ENT_QUOTES, 'UTF-8'); + $varname = @htmlspecialchars($var->getVarName(), ENT_QUOTES); + $value = @htmlspecialchars($var->getValue($vars), ENT_QUOTES); $html = '