From: Gunnar Wrobel <p@rdus.de>
Date: Tue, 30 Nov 2010 05:49:46 +0000 (+0100)
Subject: Add initial steps of the token validation.
X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=e372f6df888f279718320b5561a24a53298f08c3;p=horde.git

Add initial steps of the token validation.
---

diff --git a/framework/Token/lib/Horde/Token/Base.php b/framework/Token/lib/Horde/Token/Base.php
index aac281a38..7be77b077 100644
--- a/framework/Token/lib/Horde/Token/Base.php
+++ b/framework/Token/lib/Horde/Token/Base.php
@@ -108,17 +108,43 @@ abstract class Horde_Token_Base
      *
      * @param string $seed  A unique ID to be included in the token.
      *
-     * @return string A string of 6 bytes.
+     * @return string The new token.
      */
     public function get($seed = '')
     {
         $nonce = $this->getNonce();
         return Horde_Url::uriB64Encode(
-            $nonce . hash('sha256', $nonce . $this->_params['secret'] . $seed, true)
+            $nonce . $this->_hash($nonce . $seed)
         );
     }
 
     /**
+     * Validate a signed token.
+     *
+     * @param string  $token    The signed token.
+     * @param string  $seed     The unique ID of the token.
+     * @param int     $timeout  Timout of the token in seconds.
+     * @param boolean $unique   Can the token be used more than once?
+     *
+     * @return boolean True if the token was valid.
+     */
+    public function validate($token, $seed = '', $timeout = 0, $unique = false)
+    {
+        $b = Horde_Url::uriB64Decode($token);
+        $nonce = substr($b, 0, 6);
+        $hash = substr($b, 6);
+        if ($hash != $this->_hash($nonce . $seed)) {
+            return false;
+        }
+        return true;
+    }
+
+    private function _hash($text)
+    {
+        return hash('sha256', $text . $this->_params['secret'], true);
+    }
+
+    /**
      * Return a "number used once" (a concatenation of a timestamp and a random
      * numer).
      *
diff --git a/framework/Token/test/Horde/Token/Unit/FileTest.php b/framework/Token/test/Horde/Token/Unit/FileTest.php
index 3e4ac81f1..a458bed9f 100644
--- a/framework/Token/test/Horde/Token/Unit/FileTest.php
+++ b/framework/Token/test/Horde/Token/Unit/FileTest.php
@@ -45,6 +45,36 @@ class Horde_Token_Unit_Storage_FileTest extends PHPUnit_Framework_TestCase
         $this->assertEquals(51, strlen($t->get()));
     }
 
+    public function testValidation()
+    {
+        $t = new Horde_Token_File(array('secret' => 'abc'));
+        $this->assertTrue($t->validate($t->get()));
+    }
+
+    public function testValidationWithSeed()
+    {
+        $t = new Horde_Token_File(array('secret' => 'abc'));
+        $this->assertTrue($t->validate($t->get('a'), 'a'));
+    }
+
+    public function testInvalidToken()
+    {
+        $t = new Horde_Token_File(array('secret' => 'abc'));
+        $this->assertFalse($t->validate('something'));
+    }
+
+    public function testInvalidEmptyToken()
+    {
+        $t = new Horde_Token_File(array('secret' => 'abc'));
+        $this->assertFalse($t->validate(''));
+    }
+
+    public function testInvalidSeed()
+    {
+        $t = new Horde_Token_File(array('secret' => 'abc'));
+        $this->assertFalse($t->validate($t->get('a'), 'b'));
+    }
+
     public function testNonces()
     {
         $t = new Horde_Token_File(array('secret' => 'abc'));