From: Chuck Hagenbuch <chuck@horde.org>
Date: Sun, 22 Aug 2010 03:11:19 +0000 (-0400)
Subject: Make getRandomGallery() actually random
X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=f47d1052eae37d542155791fb06a127c4b553f36;p=horde.git

Make getRandomGallery() actually random
---

diff --git a/ansel/lib/Storage.php b/ansel/lib/Storage.php
index 123ed4ee1..6dd5c3582 100644
--- a/ansel/lib/Storage.php
+++ b/ansel/lib/Storage.php
@@ -938,18 +938,13 @@ class Ansel_Storage
     public function getRandomGallery($params = array())
     {
         $params = new Horde_Support_Array($params);
-        $num_galleries = $this->countGalleries($GLOBALS['registry']->getAuth(),
-                                               $params->perm,
-                                               $params->filter,
-                                               $params->parent,
-                                               $params->allLevels);
-        if (!$num_galleries) {
-            return $num_galleries;
-        }
         $galleries = $this->listGalleries($params);
-        $gallery = array_pop($galleries);
+        if (!$galleries) {
+            return false;
+        }
 
-        return $gallery;
+        $gallery_key = array_rand($galleries);
+        return $galleries[$gallery_key];
     }
 
     /**