From: markt Date: Tue, 29 Dec 2009 20:19:44 +0000 (+0000) Subject: Don't override method that has a more complete implementation (handles more edge... X-Git-Url: https://git.internetallee.de/?a=commitdiff_plain;h=fbde5684c1c14f0dbe36f75cebe02c502f38360e;p=tomcat7.0 Don't override method that has a more complete implementation (handles more edge cases) in RealmBase git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@894475 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/java/org/apache/catalina/realm/JAASMemoryLoginModule.java b/java/org/apache/catalina/realm/JAASMemoryLoginModule.java index 0ba939e9b..bb91042c4 100644 --- a/java/org/apache/catalina/realm/JAASMemoryLoginModule.java +++ b/java/org/apache/catalina/realm/JAASMemoryLoginModule.java @@ -22,7 +22,6 @@ package org.apache.catalina.realm; import java.io.File; import java.io.IOException; import java.security.Principal; -import java.util.ArrayList; import java.util.Map; import javax.security.auth.Subject; @@ -36,11 +35,7 @@ import javax.security.auth.login.FailedLoginException; import javax.security.auth.login.LoginException; import javax.security.auth.spi.LoginModule; -import org.apache.catalina.Context; import org.apache.catalina.authenticator.Constants; -import org.apache.catalina.connector.Request; -import org.apache.catalina.deploy.SecurityConstraint; -import org.apache.catalina.util.RequestUtil; import org.apache.tomcat.util.res.StringManager; import org.apache.juli.logging.Log; import org.apache.juli.logging.LogFactory; @@ -210,56 +205,6 @@ public class JAASMemoryLoginModule extends MemoryRealm implements LoginModule { /** - * Return the SecurityConstraints configured to guard the request URI for - * this request, or null if there is no such constraint. - * - * @param request Request we are processing - * @param context Context the Request is mapped to - */ - @Override - public SecurityConstraint [] findSecurityConstraints(Request request, - Context context) { - ArrayList results = null; - // Are there any defined security constraints? - SecurityConstraint constraints[] = context.findConstraints(); - if ((constraints == null) || (constraints.length == 0)) { - if (context.getLogger().isDebugEnabled()) - context.getLogger().debug(" No applicable constraints defined"); - return (null); - } - - // Check each defined security constraint - String uri = request.getDecodedRequestURI(); - String contextPath = request.getContextPath(); - if (contextPath.length() > 0) - uri = uri.substring(contextPath.length()); - uri = RequestUtil.URLDecode(uri); // Before checking constraints - String method = request.getMethod(); - for (int i = 0; i < constraints.length; i++) { - if (context.getLogger().isDebugEnabled()) - context.getLogger().debug(" Checking constraint '" + constraints[i] + - "' against " + method + " " + uri + " --> " + - constraints[i].included(uri, method)); - if (constraints[i].included(uri, method)) { - if(results == null) { - results = new ArrayList(); - } - results.add(constraints[i]); - } - } - - // No applicable security constraint was found - if (context.getLogger().isDebugEnabled()) - context.getLogger().debug(" No applicable constraint located"); - if(results == null) - return null; - SecurityConstraint [] array = new SecurityConstraint[results.size()]; - System.arraycopy(results.toArray(), 0, array, 0, array.length); - return array; - } - - - /** * Initialize this LoginModule with the specified * configuration information. *