horde.git
15 years agoOmit warning during autoloading when an included file does not exist.
Gunnar Wrobel [Thu, 11 Feb 2010 13:48:13 +0000 (14:48 +0100)]
Omit warning during autoloading when an included file does not exist.

Otherwise some test may fail under strict conditions since
class_exists() and new ReflectionClass() suddenly emit a warning for
non-existant classes. See tests in Horde_Injector that test for
reactions on specifying non existing Instances.

15 years agoUpdate the package.xml using the Packaging script.
Gunnar Wrobel [Thu, 11 Feb 2010 12:15:51 +0000 (13:15 +0100)]
Update the package.xml using the Packaging script.

15 years agoTypo
Gunnar Wrobel [Thu, 11 Feb 2010 11:32:09 +0000 (12:32 +0100)]
Typo

15 years agoComplete exception testing.
Gunnar Wrobel [Thu, 11 Feb 2010 11:11:48 +0000 (12:11 +0100)]
Complete exception testing.

15 years agoSupport previous exceptions in PHP < 5.3.0.
Gunnar Wrobel [Thu, 11 Feb 2010 10:56:27 +0000 (11:56 +0100)]
Support previous exceptions in PHP < 5.3.0.

Taken from http://framework.zend.com/wiki/display/ZFPROP/previous+Exception+on+Zend_Exception+-+Marc+Bennewitz

15 years agoFix tests.
Jan Schneider [Thu, 11 Feb 2010 10:50:19 +0000 (11:50 +0100)]
Fix tests.

15 years agoExtract PEAR and exception handling into a separate class.
Gunnar Wrobel [Thu, 11 Feb 2010 10:07:15 +0000 (11:07 +0100)]
Extract PEAR and exception handling into a separate class.

Again we always know when we throw a PEAR Error or an exception at
Horde_Exception. It is not necessary to have the class trying to
determine what the arguments might have been.

15 years agoDo not convert incorrect code types to integer automatically.
Gunnar Wrobel [Thu, 11 Feb 2010 08:29:43 +0000 (09:29 +0100)]
Do not convert incorrect code types to integer automatically.

If $code is null it will be converted to 0 by the default Exception
anyhow.

If $code contains a string it will elicit a Fatal Error. But that is
okay and should not be hidden. In nearly all cases where we provided a
string as $code it was a simple coding error that needs to be fixed.

There may be cases where the code is a value returned from another
library. If it is uncertain that the library ensures that the return
value is an integer then it can be cast into an integer before
providing it to the exception.

15 years agoExtract the error_get_last() handling into a separate Exception class.
Gunnar Wrobel [Thu, 11 Feb 2010 08:09:59 +0000 (09:09 +0100)]
Extract the error_get_last() handling into a separate Exception class.

In all cases (Horde_Feed, Horde_Xml_Element, Horde_Yaml, and Horde_Http) where
we throw the result from error_get_last() into the exception class we know
exactly that we are doing so.

Rather than having the Exception class trying to determine what kind of
parameters it might have received we can use a separate class for that.

15 years agoUse Horde_Exception_PermissionDenied.
Jan Schneider [Thu, 11 Feb 2010 09:51:45 +0000 (10:51 +0100)]
Use Horde_Exception_PermissionDenied.

15 years agoFix dragging in the month view.
Jan Schneider [Wed, 10 Feb 2010 23:42:17 +0000 (00:42 +0100)]
Fix dragging in the month view.

15 years agoDon't wrap HTML->Text reply data
Michael M Slusarz [Wed, 10 Feb 2010 20:21:22 +0000 (13:21 -0700)]
Don't wrap HTML->Text reply data

15 years agoMove filter interface into Horde_Text_Filter_Base class.
Michael M Slusarz [Wed, 10 Feb 2010 20:20:32 +0000 (13:20 -0700)]
Move filter interface into Horde_Text_Filter_Base class.

15 years agoTweaks to reply quote styling
Michael M Slusarz [Wed, 10 Feb 2010 19:54:45 +0000 (12:54 -0700)]
Tweaks to reply quote styling

15 years agoImprovements to the Html2Text filter.
Michael M Slusarz [Wed, 10 Feb 2010 19:20:03 +0000 (12:20 -0700)]
Improvements to the Html2Text filter.

15 years agoAdd ability to define filters to use with preg_replace_callback().
Michael M Slusarz [Wed, 10 Feb 2010 18:59:58 +0000 (11:59 -0700)]
Add ability to define filters to use with preg_replace_callback().

15 years agoFix undefined error warning.
Michael M Slusarz [Wed, 10 Feb 2010 18:49:27 +0000 (11:49 -0700)]
Fix undefined error warning.

15 years agoThis can all be done in one call in PHP 4.3.0+
Michael M Slusarz [Wed, 10 Feb 2010 18:14:22 +0000 (11:14 -0700)]
This can all be done in one call in PHP 4.3.0+

15 years agoMove from main() to init() in the AllTests.php files.
Gunnar Wrobel [Thu, 11 Feb 2010 07:59:57 +0000 (08:59 +0100)]
Move from main() to init() in the AllTests.php files.

15 years agoFix adding events via the API.
Michael J. Rubinsky [Wed, 10 Feb 2010 21:06:29 +0000 (16:06 -0500)]
Fix adding events via the API.

Sneaky little bug. Can't catch a Kronolith_Exception here, since
Kronolith_Driver#getByUID can also throw a Horde_Exception_NotFound now too.

15 years agoFix variable name
Michael J. Rubinsky [Wed, 10 Feb 2010 19:37:54 +0000 (14:37 -0500)]
Fix variable name

15 years agospelling
Michael J. Rubinsky [Wed, 10 Feb 2010 19:14:56 +0000 (14:14 -0500)]
spelling

15 years agocast the lat/lon values to floats since we evidently can't use DB's placeholders
Michael J. Rubinsky [Wed, 10 Feb 2010 19:11:26 +0000 (14:11 -0500)]
cast the lat/lon values to floats since we evidently can't use DB's placeholders

15 years agouse placeholders where possible, can't use them in the POINT() spatial function, as
Michael J. Rubinsky [Wed, 10 Feb 2010 18:57:18 +0000 (13:57 -0500)]
use placeholders where possible, can't use them in the POINT() spatial function, as
this seems to break the query.

15 years agotypos, fix variable names
Michael J. Rubinsky [Wed, 10 Feb 2010 18:56:39 +0000 (13:56 -0500)]
typos, fix variable names

15 years agoUse exceptions and a bit other H4 stuff along the way.
Jan Schneider [Wed, 10 Feb 2010 18:28:36 +0000 (19:28 +0100)]
Use exceptions and a bit other H4 stuff along the way.

15 years agofix variable name
Michael J. Rubinsky [Wed, 10 Feb 2010 18:22:58 +0000 (13:22 -0500)]
fix variable name

15 years agoFix display of duplicate attachments
Michael M Slusarz [Wed, 10 Feb 2010 18:00:17 +0000 (11:00 -0700)]
Fix display of duplicate attachments

15 years agoDon't display PGP armored text data as separate part.
Michael M Slusarz [Wed, 10 Feb 2010 17:58:00 +0000 (10:58 -0700)]
Don't display PGP armored text data as separate part.

15 years agoDon't display S/MIME signature data inline.
Michael M Slusarz [Wed, 10 Feb 2010 17:36:44 +0000 (10:36 -0700)]
Don't display S/MIME signature data inline.

15 years agoUse placeholders instead of interpolation - and fix logic in setLocation()
Michael J. Rubinsky [Wed, 10 Feb 2010 17:13:16 +0000 (12:13 -0500)]
Use placeholders instead of interpolation - and fix logic in setLocation()

15 years agoMark tests as skipped if the sqlite extension is not available.
Gunnar Wrobel [Wed, 10 Feb 2010 16:53:41 +0000 (17:53 +0100)]
Mark tests as skipped if the sqlite extension is not available.

15 years agoUse the main method from the parent class to avoid strict warnings.
Gunnar Wrobel [Wed, 10 Feb 2010 16:45:19 +0000 (17:45 +0100)]
Use the main method from the parent class to avoid strict warnings.

15 years agoEnsure we dont include the AllTests.php from the Test package.
Gunnar Wrobel [Wed, 10 Feb 2010 16:37:35 +0000 (17:37 +0100)]
Ensure we dont include the AllTests.php from the Test package.

15 years agoMake test_framework run again.
Gunnar Wrobel [Wed, 10 Feb 2010 16:35:44 +0000 (17:35 +0100)]
Make test_framework run again.

Disabled some Kolab tests from H3 that were not yet ported to H4.
Removed the init() call. Either all AllTests.php use this or none.

Without the init() call in the AllTests.php the suite() yields no test cases
so the only tests being run are currently from the Db package.

15 years agoRemove unused rename() method.
Jan Schneider [Wed, 10 Feb 2010 16:31:25 +0000 (17:31 +0100)]
Remove unused rename() method.

15 years agoRemove redundant method.
Jan Schneider [Tue, 9 Feb 2010 23:31:12 +0000 (00:31 +0100)]
Remove redundant method.

15 years agoAdd Horde_Exception_NotFound.
Jan Schneider [Tue, 9 Feb 2010 17:53:20 +0000 (18:53 +0100)]
Add Horde_Exception_NotFound.

15 years agoSet default exception message.
Jan Schneider [Tue, 9 Feb 2010 11:52:07 +0000 (12:52 +0100)]
Set default exception message.

15 years agoAdd Horde_Exception_PermissionDenied.
Jan Schneider [Tue, 9 Feb 2010 11:46:44 +0000 (12:46 +0100)]
Add Horde_Exception_PermissionDenied.

15 years agoUpdate history in base class.
Jan Schneider [Tue, 9 Feb 2010 11:27:36 +0000 (12:27 +0100)]
Update history in base class.

15 years agoCorrect the error message and keep the command line information.
Gunnar Wrobel [Wed, 10 Feb 2010 15:11:10 +0000 (16:11 +0100)]
Correct the error message and keep the command line information.

The command line was originally reported as user information on a PEAR Error object. During the
import to git the PEAR Error was exchanged with an exception and the command line provided as
the second argument to the exception. As strings in this position get reset the information will
be lost. I assume that concatenating the command line to the error might actually be what was
desired.

15 years agoReadd sprintf() that got lost with the import to git.
Gunnar Wrobel [Wed, 10 Feb 2010 15:03:56 +0000 (16:03 +0100)]
Readd sprintf() that got lost with the import to git.

15 years agoFix typo that crept in with commit cdc9a1b.
Gunnar Wrobel [Wed, 10 Feb 2010 14:58:47 +0000 (15:58 +0100)]
Fix typo that crept in with commit cdc9a1b.

15 years agoRemove second exception parameter if it is a string.
Gunnar Wrobel [Wed, 10 Feb 2010 14:45:50 +0000 (15:45 +0100)]
Remove second exception parameter if it is a string.

Having a string as  does not have any effect as it gets set to zero in the Exception constructor.

15 years agoAdd tests for the current exception class.
Gunnar Wrobel [Wed, 10 Feb 2010 10:49:17 +0000 (11:49 +0100)]
Add tests for the current exception class.

15 years agoAdd the possibility to initialize a test suite with a static init() method
Gunnar Wrobel [Wed, 10 Feb 2010 08:39:29 +0000 (09:39 +0100)]
Add the possibility to initialize a test suite with a static init() method
rather than using the main() method.

It is not sufficient to setup the static AllTests class via the main method.
This only allows to directly execute the AllTests.php file by parsing it
with php. Using phpunit is not possible as this will only use the suite()
method to grab the test suite.

It would still be better to use late static binding here but the added
method should be enough to allow running the tests in both ways.

The AllTests.php in Kolab_Session demonstrates how to use the init() method.

15 years agoFix Horde_Mime::isChild() for X.0 type MIME IDs
Michael M Slusarz [Wed, 10 Feb 2010 08:42:02 +0000 (01:42 -0700)]
Fix Horde_Mime::isChild() for X.0 type MIME IDs

15 years agoUse content-disposition filename to get/set name of part
Michael M Slusarz [Wed, 10 Feb 2010 08:15:05 +0000 (01:15 -0700)]
Use content-disposition filename to get/set name of part

15 years agoFix constant name.
Michael M Slusarz [Wed, 10 Feb 2010 08:12:02 +0000 (01:12 -0700)]
Fix constant name.

15 years agoFix display of certain attachments
Michael M Slusarz [Wed, 10 Feb 2010 07:58:39 +0000 (00:58 -0700)]
Fix display of certain attachments

15 years agoFix undefined error
Michael M Slusarz [Wed, 10 Feb 2010 07:58:16 +0000 (00:58 -0700)]
Fix undefined error

15 years agoMove contextmenu styles to horde
Michael M Slusarz [Wed, 10 Feb 2010 07:08:42 +0000 (00:08 -0700)]
Move contextmenu styles to horde

15 years agoClose submenu and trigger current element on click
Michael M Slusarz [Wed, 10 Feb 2010 06:59:37 +0000 (23:59 -0700)]
Close submenu and trigger current element on click

15 years agoModest improvements to the prefs UI templates
Michael M Slusarz [Wed, 10 Feb 2010 06:50:50 +0000 (23:50 -0700)]
Modest improvements to the prefs UI templates

15 years agoMake $app optional to Horde::getServiceLink().
Michael M Slusarz [Wed, 10 Feb 2010 06:50:17 +0000 (23:50 -0700)]
Make $app optional to Horde::getServiceLink().

15 years agoSet inferred attributes if using LIST-EXTENDED
Michael M Slusarz [Wed, 10 Feb 2010 06:07:31 +0000 (23:07 -0700)]
Set inferred attributes if using LIST-EXTENDED

15 years agoMake sure all special mailboxes are sent when rebuilding mailbox tree
Michael M Slusarz [Wed, 10 Feb 2010 05:59:13 +0000 (22:59 -0700)]
Make sure all special mailboxes are sent when rebuilding mailbox tree

15 years agoOnly show unsubscribed style if viewing unsubscribed mailboxes
Michael M Slusarz [Wed, 10 Feb 2010 05:55:52 +0000 (22:55 -0700)]
Only show unsubscribed style if viewing unsubscribed mailboxes

15 years agoMore improvements to mailbox tree generation.
Michael M Slusarz [Wed, 10 Feb 2010 05:49:48 +0000 (22:49 -0700)]
More improvements to mailbox tree generation.

Leverage recent improvements in IMAP library that allow more consistent
handling of things like attributes across various IMAP servers.
Use attribute information to more intelligently create the mailbox tree.
Saves an IMAP LIST call on initial build if subscribed only mailboxes
are shown.
Fixes special labels if they appear in a mailbox below the first level.
Fixes Bug #8859

15 years agoFix label determination for INBOX.
Michael M Slusarz [Wed, 10 Feb 2010 04:19:12 +0000 (21:19 -0700)]
Fix label determination for INBOX.

If namespace is INBOX., and mailbox is INBOX.INBOX, this mailbox should
not have a translated label name.

15 years agoAdd IMP_Folder binder class.
Michael M Slusarz [Tue, 9 Feb 2010 23:54:13 +0000 (16:54 -0700)]
Add IMP_Folder binder class.

Cache ID for folder list must include server key - or else logging into
different servers will give server list from last server.

15 years agoMove init() to a better location in the file
Michael M Slusarz [Tue, 9 Feb 2010 23:37:29 +0000 (16:37 -0700)]
Move init() to a better location in the file

15 years agoFix several options argument issues
Michael M Slusarz [Tue, 9 Feb 2010 22:18:15 +0000 (15:18 -0700)]
Fix several options argument issues

15 years agoBug #8858: Auto-determine charset for text attachments
Michael M Slusarz [Tue, 9 Feb 2010 20:29:43 +0000 (13:29 -0700)]
Bug #8858: Auto-determine charset for text attachments

15 years agoHorde_Mime_Magic improvements.
Michael M Slusarz [Tue, 9 Feb 2010 20:15:37 +0000 (13:15 -0700)]
Horde_Mime_Magic improvements.

Add 'nostrip' option to prevent stripping MIME parameter information
from the return.
Improve phpdoc.
Remove unused variable.

15 years agoUpdate MIME mapping data file.
Michael M Slusarz [Tue, 9 Feb 2010 20:09:36 +0000 (13:09 -0700)]
Update MIME mapping data file.

15 years agoAdd Horde_Registry::getAppDrivers()
Michael M Slusarz [Tue, 9 Feb 2010 18:49:31 +0000 (11:49 -0700)]
Add Horde_Registry::getAppDrivers()

15 years agoConversions to H4 formats
Michael M Slusarz [Tue, 9 Feb 2010 18:34:20 +0000 (11:34 -0700)]
Conversions to H4 formats

16 years agome != jan
Michael M Slusarz [Tue, 9 Feb 2010 17:17:53 +0000 (10:17 -0700)]
me != jan

16 years agoFix logic
Michael M Slusarz [Tue, 9 Feb 2010 07:03:42 +0000 (00:03 -0700)]
Fix logic

16 years agoTweak default HTML UI font
Michael M Slusarz [Tue, 9 Feb 2010 06:46:54 +0000 (23:46 -0700)]
Tweak default HTML UI font

16 years agoMove quicksearch sizing into CSS
Michael M Slusarz [Tue, 9 Feb 2010 06:16:14 +0000 (23:16 -0700)]
Move quicksearch sizing into CSS

16 years agoIE 7+ JS fix
Michael M Slusarz [Tue, 9 Feb 2010 06:15:44 +0000 (23:15 -0700)]
IE 7+ JS fix

16 years agoAlso remove Safari 2 support for DIMP
Michael M Slusarz [Tue, 9 Feb 2010 05:23:52 +0000 (22:23 -0700)]
Also remove Safari 2 support for DIMP

16 years agoRemove IE 6 support for DIMP
Michael M Slusarz [Tue, 9 Feb 2010 05:17:06 +0000 (22:17 -0700)]
Remove IE 6 support for DIMP

16 years agoProvide basic checking to prevent switching between mimp/imp/dimp during session
Michael M Slusarz [Tue, 9 Feb 2010 05:16:49 +0000 (22:16 -0700)]
Provide basic checking to prevent switching between mimp/imp/dimp during session

16 years agoRemove move PEAR_Error usage in IMP
Michael M Slusarz [Tue, 9 Feb 2010 04:22:23 +0000 (21:22 -0700)]
Remove move PEAR_Error usage in IMP

16 years agoDon't attach events to listeners by default (attach when notify() is
Michael M Slusarz [Tue, 9 Feb 2010 03:52:45 +0000 (20:52 -0700)]
Don't attach events to listeners by default (attach when notify() is
called on a listener).

Remove _initNotification() workaround.
Since the notification system no longer attaches events to listeners
until notify() is called, it is safe to change notification listeners as
needed directly within _init() calls.

16 years agoUnneeed tests
Michael M Slusarz [Tue, 9 Feb 2010 03:10:21 +0000 (20:10 -0700)]
Unneeed tests

16 years agoStore notifications events as Horde_Notification_Event objects
Michael M Slusarz [Tue, 9 Feb 2010 01:37:46 +0000 (18:37 -0700)]
Store notifications events as Horde_Notification_Event objects

16 years agophpdoc; coding standards
Michael M Slusarz [Mon, 8 Feb 2010 23:36:56 +0000 (16:36 -0700)]
phpdoc; coding standards

16 years agoSet timeout.
Jan Schneider [Mon, 8 Feb 2010 22:45:50 +0000 (23:45 +0100)]
Set timeout.

16 years agoCatch exceptions.
Jan Schneider [Mon, 8 Feb 2010 22:39:37 +0000 (23:39 +0100)]
Catch exceptions.

16 years agoSet remote calendar timeout also when retrieving calendar information.
Jan Schneider [Mon, 8 Feb 2010 22:16:44 +0000 (23:16 +0100)]
Set remote calendar timeout also when retrieving calendar information.

16 years agoFix race condition when new alarms arrive faster than growlers are created.
Jan Schneider [Mon, 8 Feb 2010 22:06:59 +0000 (23:06 +0100)]
Fix race condition when new alarms arrive faster than growlers are created.

16 years agoThese are strings now.
Jan Schneider [Mon, 8 Feb 2010 22:01:43 +0000 (23:01 +0100)]
These are strings now.

16 years agoDesign tweaks.
Jan Schneider [Mon, 8 Feb 2010 21:31:06 +0000 (22:31 +0100)]
Design tweaks.

16 years agoFix argument passing (Bug #8846).
Jan Schneider [Mon, 8 Feb 2010 09:15:59 +0000 (10:15 +0100)]
Fix argument passing (Bug #8846).

16 years agoMake this smaller.
Jan Schneider [Fri, 5 Feb 2010 11:25:54 +0000 (12:25 +0100)]
Make this smaller.

16 years agoRemove unused icons.
Jan Schneider [Fri, 5 Feb 2010 11:25:39 +0000 (12:25 +0100)]
Remove unused icons.

16 years agoAdd timeobjects too.
Jan Schneider [Fri, 5 Feb 2010 10:39:32 +0000 (11:39 +0100)]
Add timeobjects too.

16 years agoUse a more useful error handling.
Jan Schneider [Wed, 3 Feb 2010 18:45:30 +0000 (19:45 +0100)]
Use a more useful error handling.

16 years agoAdd debug logging for Horde_Prefs::setValue()
Michael M Slusarz [Fri, 5 Feb 2010 21:24:51 +0000 (14:24 -0700)]
Add debug logging for Horde_Prefs::setValue()

16 years agoTicket #8805: Optimize folder tree initialization
Michael M Slusarz [Fri, 5 Feb 2010 21:21:09 +0000 (14:21 -0700)]
Ticket #8805: Optimize folder tree initialization

16 years agoAdmin login provided by appInit()
Michael M Slusarz [Fri, 5 Feb 2010 21:03:29 +0000 (14:03 -0700)]
Admin login provided by appInit()

16 years agoThrow exception if admin auth requested but no admins defined
Michael M Slusarz [Fri, 5 Feb 2010 21:03:15 +0000 (14:03 -0700)]
Throw exception if admin auth requested but no admins defined

16 years agoUse personal info of from address if reply-to address is missing it
Michael M Slusarz [Fri, 5 Feb 2010 20:09:32 +0000 (13:09 -0700)]
Use personal info of from address if reply-to address is missing it

16 years agoFix determination of reply_all usage
Michael M Slusarz [Fri, 5 Feb 2010 20:09:10 +0000 (13:09 -0700)]
Fix determination of reply_all usage

16 years agoMissed a spot to add additional maillog actions
Michael M Slusarz [Fri, 5 Feb 2010 18:48:14 +0000 (11:48 -0700)]
Missed a spot to add additional maillog actions