tomcat7.0
14 years agoDon't start NamingResources multiple times
markt [Thu, 24 Feb 2011 17:03:27 +0000 (17:03 +0000)]
Don't start NamingResources multiple times

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074215 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd documentation for the Crawler Session Manager Valve.
markt [Thu, 24 Feb 2011 16:01:38 +0000 (16:01 +0000)]
Add documentation for the Crawler Session Manager Valve.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074192 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix comment typo
markt [Thu, 24 Feb 2011 14:39:39 +0000 (14:39 +0000)]
Fix comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074168 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid NPE if no u-a header
markt [Thu, 24 Feb 2011 14:15:34 +0000 (14:15 +0000)]
Avoid NPE if no u-a header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074159 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRestore the CrawlerSessionManagerValve
markt [Thu, 24 Feb 2011 13:11:17 +0000 (13:11 +0000)]
Restore the CrawlerSessionManagerValve
Local testing with Jira 4.2.4 shows it works.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074132 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd security listener
markt [Wed, 23 Feb 2011 19:25:17 +0000 (19:25 +0000)]
Add security listener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073893 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd the SecurityListener (disabled by default) that prevents Tomcat from starting...
markt [Wed, 23 Feb 2011 19:23:59 +0000 (19:23 +0000)]
Add the SecurityListener (disabled by default) that prevents Tomcat from starting if configured insecurely.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073891 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBetter handling in acceptor threads if server hits ulimit for open files
markt [Wed, 23 Feb 2011 11:58:47 +0000 (11:58 +0000)]
Better handling in acceptor threads if server hits ulimit for open files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073711 13f79535-47bb-0310-9956-ffa450edef68

14 years agodoco update bug 50805
fhanik [Tue, 22 Feb 2011 22:45:43 +0000 (22:45 +0000)]
doco update bug 50805

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073532 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50805
fhanik [Tue, 22 Feb 2011 22:42:44 +0000 (22:42 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50805
Make sure we only call borrowConnection once per connection per checkout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073531 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest before generating debug log messages
markt [Tue, 22 Feb 2011 16:38:39 +0000 (16:38 +0000)]
Test before generating debug log messages
Fix FindBugs issues for File.delete() return value

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073393 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code, fix FindBugs warning
markt [Tue, 22 Feb 2011 12:55:56 +0000 (12:55 +0000)]
Remove unused code, fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073320 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=21669
markt [Tue, 22 Feb 2011 11:48:09 +0000 (11:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=21669
Add the ability to specify the roleBase for the JNDI Realm as relative to the users DN. Based on a patch by Art W.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073301 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=19444
markt [Tue, 22 Feb 2011 11:08:42 +0000 (11:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=19444
Add an option to the JNDI realm to allow role searches to be performed by the authenticated user.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073296 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRefactoring to remove duplicate code
markt [Tue, 22 Feb 2011 10:46:02 +0000 (10:46 +0000)]
Refactoring to remove duplicate code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073289 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConvert to Javadoc comment and add some additional info
markt [Mon, 21 Feb 2011 23:21:09 +0000 (23:21 +0000)]
Convert to Javadoc comment and add some additional info

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073184 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSmarter solution for bug 48863
markt [Mon, 21 Feb 2011 16:23:05 +0000 (16:23 +0000)]
Smarter solution for bug 48863

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073047 13f79535-47bb-0310-9956-ffa450edef68

14 years agoServletapi-2.3 appears to have disappeared from the maven1 repo.
markt [Mon, 21 Feb 2011 13:15:53 +0000 (13:15 +0000)]
Servletapi-2.3 appears to have disappeared from the maven1 repo.
Switch everything to maven2 repo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072962 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix javadoc
markt [Mon, 21 Feb 2011 12:59:50 +0000 (12:59 +0000)]
Fix javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072960 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix indentation
markt [Fri, 18 Feb 2011 21:45:49 +0000 (21:45 +0000)]
Fix indentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072161 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
markt [Fri, 18 Feb 2011 21:44:13 +0000 (21:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
Re-factor to remove parallel arrays.
Modify fix for 48863 to remove use of StringManager as it is not available in Bootstrap

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072160 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
markt [Fri, 18 Feb 2011 20:58:16 +0000 (20:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
Better logging when specifying an invalid directory for a class loader.
Based on a patch by Ralf Hauser.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072145 13f79535-47bb-0310-9956-ffa450edef68

14 years agoExclude a check
markt [Fri, 18 Feb 2011 20:48:56 +0000 (20:48 +0000)]
Exclude a check

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072144 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code, fix a Findbugs warning
markt [Fri, 18 Feb 2011 20:44:55 +0000 (20:44 +0000)]
Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072140 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code, fix a Findbugs warning
markt [Fri, 18 Feb 2011 20:43:46 +0000 (20:43 +0000)]
Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072138 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code, fix a Findbugs warning
markt [Fri, 18 Feb 2011 20:39:48 +0000 (20:39 +0000)]
Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072136 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50743
markt [Fri, 18 Feb 2011 16:53:08 +0000 (16:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50743
Cache CheckStyle results between builds to speed up validation. Patch provided by Oliver.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072057 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50189
markt [Fri, 18 Feb 2011 16:24:36 +0000 (16:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50189
Once the application has finished writing to the response, prevent further reads from the request since this causes various problems in the connectors which do not expect this.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072042 13f79535-47bb-0310-9956-ffa450edef68

14 years agoline length
markt [Fri, 18 Feb 2011 15:30:57 +0000 (15:30 +0000)]
line length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072024 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50802
markt [Thu, 17 Feb 2011 20:38:49 +0000 (20:38 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50802
Ensure that ServletContext.getResourcePaths() includes static resources packaged in JAR files in its output.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071774 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate ignore list with the full set
fhanik [Thu, 17 Feb 2011 19:42:05 +0000 (19:42 +0000)]
Update ignore list with the full set

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071757 13f79535-47bb-0310-9956-ffa450edef68

14 years agoignore list
fhanik [Thu, 17 Feb 2011 18:22:23 +0000 (18:22 +0000)]
ignore list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071735 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate version numbers
fhanik [Thu, 17 Feb 2011 18:16:22 +0000 (18:16 +0000)]
Update version numbers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071734 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrectly use the readFully method. Add a utility method to sort absolute order
fhanik [Thu, 17 Feb 2011 16:23:44 +0000 (16:23 +0000)]
Correctly use the readFully method. Add a utility method to sort absolute order

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071677 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50780
markt [Thu, 17 Feb 2011 16:08:08 +0000 (16:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50780
Fix memory leak in APR implementation of AJP connector introduced by the refactoring for bug 49884

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071671 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code.
markt [Thu, 17 Feb 2011 14:11:41 +0000 (14:11 +0000)]
Remove unnecessary code.
I don't see a code path that could result in the socket being in the map at this point

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071617 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code.
markt [Thu, 17 Feb 2011 14:04:37 +0000 (14:04 +0000)]
Remove unnecessary code.
I don't see a code path that could result in the socket being in the map at this point

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071614 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix NPEs on shutdown. Loop is prevented above when the child is removed.
markt [Thu, 17 Feb 2011 13:10:36 +0000 (13:10 +0000)]
Fix NPEs on shutdown. Loop is prevented above when the child is removed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071601 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTypo? Copy and paste error?
markt [Thu, 17 Feb 2011 12:11:36 +0000 (12:11 +0000)]
Typo? Copy and paste error?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071592 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo
markt [Thu, 17 Feb 2011 12:10:32 +0000 (12:10 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071591 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50789
markt [Thu, 17 Feb 2011 10:32:07 +0000 (10:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50789
Provide an option to enable ServletRequestListeners for forwards as required by some CDI frameworks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071565 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50790
markt [Thu, 17 Feb 2011 09:59:30 +0000 (09:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50790
Improve method resolution in EL expressions
Add test cases for this bug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071561 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove duplicate code.
rjung [Thu, 17 Feb 2011 09:51:17 +0000 (09:51 +0000)]
Remove duplicate code.

The implementation in the base class is identical and all other http11 implementations also inherit it from there.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071560 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent NPE in unit tests as a result of r1067718
markt [Thu, 17 Feb 2011 09:46:52 +0000 (09:46 +0000)]
Prevent NPE in unit tests as a result of r1067718

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071559 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix test failure now r1069056 has added stricter checks for state transitions
markt [Thu, 17 Feb 2011 09:29:58 +0000 (09:29 +0000)]
Fix test failure now r1069056 has added stricter checks for state transitions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071557 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent NPE in unit tests as a result of r1067718
markt [Thu, 17 Feb 2011 09:20:16 +0000 (09:20 +0000)]
Prevent NPE in unit tests as a result of r1067718

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071556 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrep for next release
markt [Wed, 16 Feb 2011 17:56:03 +0000 (17:56 +0000)]
Prep for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071329 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50793
markt [Wed, 16 Feb 2011 17:35:24 +0000 (17:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50793
Correctly fire request init/destroy events for astnc requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071321 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove test outside the loop
markt [Wed, 16 Feb 2011 14:18:12 +0000 (14:18 +0000)]
Move test outside the loop

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071262 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50713
markt [Wed, 16 Feb 2011 13:43:39 +0000 (13:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50713
Remove roles command from Manager application

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071243 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Tue, 15 Feb 2011 17:00:05 +0000 (17:00 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070967 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50700
markt [Mon, 14 Feb 2011 19:05:25 +0000 (19:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50700
Ensure that the override attribute of context parameters is correctly followed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070609 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrectly test for no attributes
markt [Mon, 14 Feb 2011 09:53:24 +0000 (09:53 +0000)]
Correctly test for no attributes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070420 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50771
kfujino [Mon, 14 Feb 2011 08:47:49 +0000 (08:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50771
Ensure HttpServletRequest#getAuthType() returns the name of the authentication scheme
if request has already been authenticated.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070409 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1069836
kfujino [Mon, 14 Feb 2011 02:04:06 +0000 (02:04 +0000)]
Followup to r1069836
Remove unused managerClassName attribute from mbeans-descriptors.xml.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070365 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50726
markt [Sat, 12 Feb 2011 19:35:26 +0000 (19:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50726
Ensure that the use of the genStringAsCharArray does not result in String constants that are too long for valid Java code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070139 13f79535-47bb-0310-9956-ffa450edef68

14 years agodoco and version update
fhanik [Fri, 11 Feb 2011 16:42:05 +0000 (16:42 +0000)]
doco and version update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069876 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50759
fhanik [Fri, 11 Feb 2011 16:32:41 +0000 (16:32 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50759
Update validation timestamp if using an external validator.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069864 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove deprecated code
markt [Fri, 11 Feb 2011 15:39:52 +0000 (15:39 +0000)]
Remove deprecated code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069844 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove deprecated code
markt [Fri, 11 Feb 2011 15:29:34 +0000 (15:29 +0000)]
Remove deprecated code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069836 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused deprecated method
markt [Fri, 11 Feb 2011 15:27:06 +0000 (15:27 +0000)]
Remove unused deprecated method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069835 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd additional information to assist with tracking down the root cause of https:...
markt [Fri, 11 Feb 2011 15:21:54 +0000 (15:21 +0000)]
Add additional information to assist with tracking down the root cause of https://issues.apache.org/bugzilla/show_bug.cgi?id=50737

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069832 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
markt [Fri, 11 Feb 2011 14:49:41 +0000 (14:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
Don't try to retrieve attributes if we don't need to. If anonymous bind is not allowed, the login will always fail.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069824 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
markt [Fri, 11 Feb 2011 12:24:47 +0000 (12:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
Correct typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069770 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Fri, 11 Feb 2011 12:16:31 +0000 (12:16 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069768 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd unit test that demonstrates use of a custom SSL implementation that extends the...
markt [Fri, 11 Feb 2011 12:08:55 +0000 (12:08 +0000)]
Add unit test that demonstrates use of a custom SSL implementation that extends the default JSSE implementation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069766 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a test case (already passes) for bug50753
markt [Thu, 10 Feb 2011 19:42:34 +0000 (19:42 +0000)]
Add a test case (already passes) for bug50753

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069540 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50720
markt [Thu, 10 Feb 2011 18:59:43 +0000 (18:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50720
Ensure that the use of non-ISO-8859-1 character sets for web.xml does not trigger an error when Jasper parses the web.xml file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069531 13f79535-47bb-0310-9956-ffa450edef68

14 years agoremove retry from the API.
fhanik [Thu, 10 Feb 2011 18:59:08 +0000 (18:59 +0000)]
remove retry from the API.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069530 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Javadoc warnings
markt [Thu, 10 Feb 2011 18:40:37 +0000 (18:40 +0000)]
Fix Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069516 13f79535-47bb-0310-9956-ffa450edef68

14 years agoremove unused import
markt [Thu, 10 Feb 2011 18:38:50 +0000 (18:38 +0000)]
remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069514 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50721
markt [Wed, 9 Feb 2011 23:41:32 +0000 (23:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50721
Correctly handle URL decoding where the URL ends in %nn.
Patch (for fix) provided by Christof Marti.
Additional test cases added.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069170 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnsure NamingResources follows correct lifecycle
markt [Wed, 9 Feb 2011 23:13:00 +0000 (23:13 +0000)]
Ensure NamingResources follows correct lifecycle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069166 13f79535-47bb-0310-9956-ffa450edef68

14 years agoThe bug number changed
markt [Wed, 9 Feb 2011 22:00:08 +0000 (22:00 +0000)]
The bug number changed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069135 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
markt [Wed, 9 Feb 2011 21:56:14 +0000 (21:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
Allow the content length header to be set up to the point the response is committed when a writer is used.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069131 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect the package name
markt [Wed, 9 Feb 2011 19:50:37 +0000 (19:50 +0000)]
Correct the package name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069060 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd further checks that LifecycleBase sub-classes are correctly changing state.
markt [Wed, 9 Feb 2011 19:46:49 +0000 (19:46 +0000)]
Add further checks that LifecycleBase sub-classes are correctly changing state.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069056 13f79535-47bb-0310-9956-ffa450edef68

14 years agoadd some arrows to the diagram
markt [Wed, 9 Feb 2011 19:01:20 +0000 (19:01 +0000)]
add some arrows to the diagram

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069032 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBetter comments
markt [Wed, 9 Feb 2011 18:25:48 +0000 (18:25 +0000)]
Better comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069016 13f79535-47bb-0310-9956-ffa450edef68

14 years agoremove loop that should not be used at all.
fhanik [Wed, 9 Feb 2011 17:47:13 +0000 (17:47 +0000)]
remove loop that should not be used at all.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068996 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50667
fhanik [Wed, 9 Feb 2011 17:39:24 +0000 (17:39 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
Move the callback outside try/catch to avoid duplicate callbacks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068989 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent duplicate event messages
markt [Wed, 9 Feb 2011 12:26:24 +0000 (12:26 +0000)]
Prevent duplicate event messages

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068862 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1068549 - add annotations.
kkolinko [Wed, 9 Feb 2011 09:35:16 +0000 (09:35 +0000)]
Followup to r1068549 - add annotations.

I thought about moving ErrorHandler instance creation outside the retry loop, but actually that is not needed: looping happens only when asyncReply==false and ErrorHandler is created only when asyncReply==true. Thus it is created only once.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068808 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd release date. Move recent changes into the new version.
kkolinko [Wed, 9 Feb 2011 06:39:25 +0000 (06:39 +0000)]
Add release date. Move recent changes into the new version.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068762 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStart a new version, place fix in correct version
fhanik [Tue, 8 Feb 2011 22:49:35 +0000 (22:49 +0000)]
Start a new version, place fix in correct version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068658 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog with latest tribes fixes
fhanik [Tue, 8 Feb 2011 20:34:16 +0000 (20:34 +0000)]
Update changelog with latest tribes fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068560 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50667
fhanik [Tue, 8 Feb 2011 20:18:19 +0000 (20:18 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
Allow a replier to get confirmation if the reply message was sent successfully or if it failed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068549 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo - thanks Konstantin
markt [Tue, 8 Feb 2011 17:05:56 +0000 (17:05 +0000)]
Fix typo - thanks Konstantin

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068480 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove ServerLifecycleListener
markt [Tue, 8 Feb 2011 14:32:38 +0000 (14:32 +0000)]
Remove ServerLifecycleListener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068420 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake NamingResources implement MBeanLifecycle
markt [Tue, 8 Feb 2011 14:30:17 +0000 (14:30 +0000)]
Make NamingResources implement MBeanLifecycle
Environments, Resources and ResourceLinks are once again available via JMX

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068416 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove comments
markt [Tue, 8 Feb 2011 14:28:30 +0000 (14:28 +0000)]
Improve comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068415 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove for now since I can't get it working with Jira (my primary motivation for...
markt [Sun, 6 Feb 2011 23:18:02 +0000 (23:18 +0000)]
Remove for now since I can't get it working with Jira (my primary motivation for writing it)
It will return once I find the time to do the detailed debugging with Jira to figure out why it doesn't work.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067804 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest a quick hack to get this working with Jira
markt [Sun, 6 Feb 2011 22:56:22 +0000 (22:56 +0000)]
Test a quick hack to get this working with Jira

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067797 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReview from kkolinko
markt [Sun, 6 Feb 2011 21:00:52 +0000 (21:00 +0000)]
Review from kkolinko
1. Matcher not thread safe
2. >1 UA header -> not a bot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067759 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIt isn't working. Add some debug logging.
markt [Sun, 6 Feb 2011 20:30:38 +0000 (20:30 +0000)]
It isn't working. Add some debug logging.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067747 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix the expiration logic
markt [Sun, 6 Feb 2011 20:17:58 +0000 (20:17 +0000)]
Fix the expiration logic

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067743 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFirst attempt at a valve to limit session creation by web crawlers.
markt [Sun, 6 Feb 2011 19:28:48 +0000 (19:28 +0000)]
First attempt at a valve to limit session creation by web crawlers.
Docs etc to follow once it is confirmed working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067734 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTweak defaults. Document.
markt [Sun, 6 Feb 2011 19:08:13 +0000 (19:08 +0000)]
Tweak defaults. Document.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067732 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove attribute name definitions to AccessLog interface
markt [Sun, 6 Feb 2011 18:46:42 +0000 (18:46 +0000)]
Move attribute name definitions to AccessLog interface
AccessLog implementations need to be aware of attributes since they aren't always set (e.g. if request is rejected early in the connector)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067725 13f79535-47bb-0310-9956-ffa450edef68

14 years agoInitial attempt to fix RemoteIp issues observed with ASF Jira
markt [Sun, 6 Feb 2011 18:11:52 +0000 (18:11 +0000)]
Initial attempt to fix RemoteIp issues observed with ASF Jira
Docs, filter and changelog commits to follow once it works

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067718 13f79535-47bb-0310-9956-ffa450edef68