git.internetallee.de Git

markt [Fri, 23 Jul 2010 10:35:20 +0000 (10:35 +0000)]

Revert part of previous clean-up. Jar needs to remain open

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967026 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 23 Jul 2010 10:19:32 +0000 (10:19 +0000)]

Code clean-up. Fix Eclipse warnings. Implement TODOs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967021 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 22:48:18 +0000 (22:48 +0000)]

Tab police: javax.servlet (partial)
Thanks to Checkstyle and Eclipse source formatting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966888 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 22:35:32 +0000 (22:35 +0000)]

Tab police: javax.el
Thanks to Checkstyle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966883 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 22:31:30 +0000 (22:31 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
Add necessary plumbing to enable Checkstyle
The config file is deliberately empty. The check will be uncommented once the source code has been fixed (~200 files contain tabs).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966882 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 21:36:55 +0000 (21:36 +0000)]

Use specific imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966864 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 21:36:11 +0000 (21:36 +0000)]

Fix regression in previous fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Use TCCL to load webapp classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966863 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 21:29:42 +0000 (21:29 +0000)]

Fix copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966862 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 16:58:26 +0000 (16:58 +0000)]

Fix some Eclipse warnings, remove some implemented TODOs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966745 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 16:56:32 +0000 (16:56 +0000)]

Implement some Servlet 3 TODOs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966744 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 16:32:11 +0000 (16:32 +0000)]

Extend Lifecycle state machine so global listeners can start before everything else without impacting the context and TLD config listeners

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966735 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 14:36:15 +0000 (14:36 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49613
Improve performance for multiple calls to Request.getAttributeNames() when using SSL. Patch provided by Sampo Savolainen.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966692 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 14:27:20 +0000 (14:27 +0000)]

Remove some TODOs that have been implemented

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966684 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 12:18:59 +0000 (12:18 +0000)]

Run all unit tests will all connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966613 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 11:51:00 +0000 (11:51 +0000)]

Poll time and wait are both in milliseconds

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966596 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 10:43:43 +0000 (10:43 +0000)]

Fix possible NPE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966570 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 22 Jul 2010 09:12:18 +0000 (09:12 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49567
Better handling of calls to complete() from a separate thread.
There are still a handful of TODOs around this which will follow shortly but I'm committing this since it passes the unit tests and the Servlet TCK (with BIO)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966548 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 20:31:30 +0000 (20:31 +0000)]

Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49600
Based on a patch by Marc Guillemot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966405 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 20:30:53 +0000 (20:30 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49600
Return a consistent exception for 'Not Found' resources.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966404 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 16:37:58 +0000 (16:37 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49617
Correct the ExpiresFilter documentation after changes to the submitted patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966304 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 16:09:41 +0000 (16:09 +0000)]

Return copies of the URL array rather than the original. This facilitated CVE-2010-1622 although the root cause was in the Spring Framework. Returning a copy in this case seems like a good idea.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966292 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 10:59:31 +0000 (10:59 +0000)]

Correct explanation. mapSendOptions=6 is synchronous, not asynchronous.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966178 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 10:58:56 +0000 (10:58 +0000)]

Add note about message processing order.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966177 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 21 Jul 2010 08:12:37 +0000 (08:12 +0000)]

Eclipse sample files need to have correct (platform specific) line endings in src distributions.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966131 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 17 Jul 2010 23:57:23 +0000 (23:57 +0000)]

Restore pero's timeout fix for the BIO connector. Add configuration of the timeout.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965150 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 17 Jul 2010 20:40:51 +0000 (20:40 +0000)]

Trivial - align comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965130 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 17 Jul 2010 18:24:01 +0000 (18:24 +0000)]

Expose executor.
Required so Servlet 3 Async implementation can use the container thread pool when a new thread needs to be dispatched. (e.g. from AsyncContext.start(Runnable)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965123 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 17 Jul 2010 18:20:11 +0000 (18:20 +0000)]

Clean-up. No functional change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965122 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 17 Jul 2010 18:13:21 +0000 (18:13 +0000)]

Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965118 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 16 Jul 2010 14:55:01 +0000 (14:55 +0000)]

Make the bean Serializable so I can use the example to test/demo session persistence on restart
Add required getters/setters
Indent using 4 spaces
Fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964816 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 16 Jul 2010 11:59:57 +0000 (11:59 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
Add a work-around for the known namespace issues for some Microsoft WebDAV clients. Patch provided by Panagiotis Astithas.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964780 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 16 Jul 2010 09:09:44 +0000 (09:09 +0000)]

As suggested on the users list, add redirects to the HTML interface to the root of the host-manager and manager applications

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964722 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 15 Jul 2010 21:37:41 +0000 (21:37 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
When updating the session cookie header, actually update it rather than adding a new header without a name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964614 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 15 Jul 2010 21:32:35 +0000 (21:32 +0000)]

Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
Multiple invalid session cookies

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964611 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 14 Jul 2010 22:15:50 +0000 (22:15 +0000)]

Remove the ExpiresActive option. Just comment it out if you don't want to use it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964222 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 14 Jul 2010 22:11:30 +0000 (22:11 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
Add the ExpiresFilter, a port of mod_expires
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964219 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 14 Jul 2010 21:39:40 +0000 (21:39 +0000)]

Fxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49127
Don't swallow exceptions unnecessarily

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964216 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 14 Jul 2010 21:35:37 +0000 (21:35 +0000)]

Fxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49128
Don't swallow exceptions unnecessarily

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964215 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 14 Jul 2010 21:29:44 +0000 (21:29 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49130
Better describe the core package
Patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964211 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 14 Jul 2010 21:24:45 +0000 (21:24 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49182
Align setclasspath comments with reality.
Based on a patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964208 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Wed, 14 Jul 2010 13:54:43 +0000 (13:54 +0000)]

Add myself to the list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964049 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 13 Jul 2010 21:35:39 +0000 (21:35 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48960
Disable exec by default in SSI and provide an option to enable it for both Servlet and Filter

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963868 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 13 Jul 2010 16:02:09 +0000 (16:02 +0000)]

Sign the pom.
Make sure source jar signature doesn't overwrite the non-source jar signature.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963776 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kfujino [Tue, 13 Jul 2010 04:44:25 +0000 (04:44 +0000)]

Avoid NullPointerException, when copyXML=true and META-INF/context.xml does not exist.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963599 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 12 Jul 2010 13:17:01 +0000 (13:17 +0000)]

Hard code the snapshot version for 7.0.
7.0-SNAPSHOT will always point to the latest snapshot.
I'll clean out the snapshot repo before I do the next update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963275 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 12 Jul 2010 13:02:30 +0000 (13:02 +0000)]

Prepare for the next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963273 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 11 Jul 2010 16:37:32 +0000 (16:37 +0000)]

Make the fix for bug 49555 more robust

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963106 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 11 Jul 2010 16:29:25 +0000 (16:29 +0000)]

Remove unnecessary code since Class.getCanonicalName() is available

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963103 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 21:43:02 +0000 (21:43 +0000)]

Eclipse warnings for annotations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962923 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 21:39:58 +0000 (21:39 +0000)]

javax.mail is a dummy implementation - mark it as such to stop Eclipse complaining about empty methods and unused parameters

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962922 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 21:33:16 +0000 (21:33 +0000)]

Trivial cleanup no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962921 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 21:22:12 +0000 (21:22 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49442
Trivial code clean-up. No functional change.
Based on a patch provided by Sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962919 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 21:13:23 +0000 (21:13 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478
Add support for user specified character sets to the AddDefaultCharsetFilter. Based on a patch by Felix Schumacher.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962917 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 18:33:14 +0000 (18:33 +0000)]

Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962900 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 17:20:41 +0000 (17:20 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49570
When using the example compression filter, set the Vary header on compressed responses

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962889 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 16:41:59 +0000 (16:41 +0000)]

Make the random source used for nonces user configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962881 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 16:19:26 +0000 (16:19 +0000)]

Align implementation with docs. nonceCacheSize should be configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962872 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 16:14:42 +0000 (16:14 +0000)]

Add CVE-2010-2227 test case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962871 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 16:10:33 +0000 (16:10 +0000)]

Improve CSRF protection filter by using SecureRandom rather than Random

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962865 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 10 Jul 2010 16:05:52 +0000 (16:05 +0000)]

Align docs with reality

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962864 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Sat, 10 Jul 2010 15:12:24 +0000 (15:12 +0000)]

Add release date

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962857 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 9 Jul 2010 09:41:25 +0000 (09:41 +0000)]

Documentation improvements:
- Explicit version number in <title ../>
- Add version and date to every page
- Remove duplicate "Apache Tomcat 7" and promote real page title
- Automate copyright end date

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962466 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 22:22:34 +0000 (22:22 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48297
Use the HandlerInfo to initialise the HandlerChain, rather than adding to it which clearly isn't correct.
From looking at the javadoc, I believe this is the fix required but I don't have a test case.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961963 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 21:55:46 +0000 (21:55 +0000)]

GSOC 2010. Continue work to align MBean descriptors with reality. Patch provided by Chamith Buddhika.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961956 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 21:29:12 +0000 (21:29 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Correctly handle tag libraries that use functions defined in static inner classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961948 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 21:28:21 +0000 (21:28 +0000)]

Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Fix to follow shortly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961947 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 21:19:39 +0000 (21:19 +0000)]

Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961942 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 15:48:48 +0000 (15:48 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49503
Revert the protocol handler component of r940656. Subsequent lifecycle fixes have resolved the issues that required this change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961819 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 09:00:47 +0000 (09:00 +0000)]

Update post release of 7.0.0 beta

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961647 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 8 Jul 2010 00:05:38 +0000 (00:05 +0000)]

Include session ID in error message logged when trying to set an attribute on an invalid session.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961541 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 7 Jul 2010 23:33:28 +0000 (23:33 +0000)]

Improve logging of unhandled servlet exceptions by including the context name. For JasperExceptions, the JSP snippet will be logged (if enabled). Previously this was not logged and only displayed in the error page seen by the user.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961535 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 7 Jul 2010 22:34:47 +0000 (22:34 +0000)]

Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961525 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 7 Jul 2010 09:10:38 +0000 (09:10 +0000)]

Better error message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961313 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 6 Jul 2010 16:47:39 +0000 (16:47 +0000)]

Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Make sure identifiers meet the requirements of the JLS

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960942 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 6 Jul 2010 16:45:23 +0000 (16:45 +0000)]

Side effect of fixing https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Make the examples and the unit tests spec compliant

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960940 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 5 Jul 2010 21:45:26 +0000 (21:45 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Prevent use of Java keywords in identifiers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960712 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 5 Jul 2010 21:44:29 +0000 (21:44 +0000)]

Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960711 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 5 Jul 2010 21:07:32 +0000 (21:07 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
Allow default context.xml file to be specified using an absolute path.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960701 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 5 Jul 2010 20:58:23 +0000 (20:58 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Trivial code clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960698 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 5 Jul 2010 20:51:21 +0000 (20:51 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
Previous fix was incomplete. Improve test case and fix
TCK and test cases pass with this patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960692 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 4 Jul 2010 20:48:07 +0000 (20:48 +0000)]

Clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960394 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 4 Jul 2010 20:38:41 +0000 (20:38 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
AsyncContext.start() uses an internal dispatch but this should not have the same side-effects as calling dispatch()
TCK and test cases passes with this patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960392 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 4 Jul 2010 20:34:02 +0000 (20:34 +0000)]

Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49528

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960391 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Sun, 4 Jul 2010 16:01:43 +0000 (16:01 +0000)]

Remove *.rtf from fixcrlf patternset.

No need for native line ends in RTF files.
Their spec indicates they should use CRLF.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960350 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 4 Jul 2010 15:44:45 +0000 (15:44 +0000)]

Revert r958362, r960083, r958406, r960069. r958362 broke the TCK tests and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960348 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 4 Jul 2010 15:38:40 +0000 (15:38 +0000)]

Revert r960283, r960316, r960318. r960283 broke the spec and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960347 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

pero [Sun, 4 Jul 2010 10:50:53 +0000 (10:50 +0000)]

no functional change.
reformating and fix some checkstyle warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960318 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

pero [Sun, 4 Jul 2010 10:47:12 +0000 (10:47 +0000)]

Fix indentation...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960317 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

pero [Sat, 3 Jul 2010 23:02:46 +0000 (23:02 +0000)]

Fix NPE and add small test case to check VirtualWebappLoader.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960284 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

pero [Sat, 3 Jul 2010 22:48:16 +0000 (22:48 +0000)]

Fix Bug 49528 - HttpServletRequest.isAsyncStarted() returns false when a Runnable is started
Add isDebugEnabled statements.

Todo: Why we doesn't start directly a container thread with asyncContext.start()?
Currently we start user runnable as an internal forward.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960283 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 2 Jul 2010 21:13:25 +0000 (21:13 +0000)]

A few more FindBugs issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960104 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 2 Jul 2010 21:10:35 +0000 (21:10 +0000)]

Fix FindBugs niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960103 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

pero [Fri, 2 Jul 2010 18:30:34 +0000 (18:30 +0000)]

Test NIO AsyncListener timeout.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960083 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 2 Jul 2010 18:25:54 +0000 (18:25 +0000)]

Further MBean improvements.
Patch provided by chamith buddhika

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960081 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 2 Jul 2010 18:04:14 +0000 (18:04 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49530
Make sure children are stopped if they are running when the parent stops.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960076 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 2 Jul 2010 17:50:56 +0000 (17:50 +0000)]

Make new timeout thread a daemon thread so Tomcat will shutdown properly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960069 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 2 Jul 2010 10:01:32 +0000 (10:01 +0000)]

Additional debug logging for manager selection

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959931 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 1 Jul 2010 21:35:19 +0000 (21:35 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49536
Ensure a 404 response for an unmapped request when no ROOT context is deployed.
Most of the change is getting the mapper to use the Host object rather than the ObjectName or an empty string

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959790 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 1 Jul 2010 19:37:40 +0000 (19:37 +0000)]

Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959756 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 1 Jul 2010 19:33:45 +0000 (19:33 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49525
Cookies for ROOT context need a path of /

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959754 13f79535-47bb-0310-9956-ffa450edef68