fhanik [Mon, 3 Jan 2011 22:14:21 +0000 (22:14 +0000)]
add in ability to pass through credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=50025
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054801 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 20:11:50 +0000 (20:11 +0000)]
better count check
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054730 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 20:08:47 +0000 (20:08 +0000)]
update link
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054729 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 3 Jan 2011 14:00:29 +0000 (14:00 +0000)]
Update Copyright year.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054620 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Wed, 29 Dec 2010 20:42:04 +0000 (20:42 +0000)]
Improve documentation of database connection factory.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1053727 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Tue, 21 Dec 2010 22:26:55 +0000 (22:26 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159
- merged LocalStrings.properties file from package o.a.t.u.threads to o.a.t.u.threads.res
- removed 3 i18n keys that are no longer used by tc7. They were used by the old ThreadPool implementation of tc6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051682 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 17:40:57 +0000 (17:40 +0000)]
refactor latch usage, since its shared by all connectors
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051578 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 17:40:34 +0000 (17:40 +0000)]
Fix classpath
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051577 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 17:39:11 +0000 (17:39 +0000)]
Allow to set log formatter when running Junit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051576 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 16:15:16 +0000 (16:15 +0000)]
Allow to specify the test on the command line
ant -Dtest.name=**/TestMax** test
Without the parameter, the default is all tests as specified before
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051540 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 16:14:24 +0000 (16:14 +0000)]
make shared variable volatile
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051539 13f79535-47bb-0310-9956-
ffa450edef68
kfujino [Tue, 21 Dec 2010 09:47:15 +0000 (09:47 +0000)]
Fix webappClassLoader.clearJbdc message key and message in LocalStrings.properties.
Jbdc is corrected to jdbc.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051433 13f79535-47bb-0310-9956-
ffa450edef68
kfujino [Tue, 21 Dec 2010 06:56:09 +0000 (06:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50503.
When web application has a version, Engine level Clustering works correctly.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051392 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 21 Dec 2010 01:57:50 +0000 (01:57 +0000)]
Fix Checkstyle / Eclipse nags
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051358 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 21 Dec 2010 01:56:04 +0000 (01:56 +0000)]
Restore file accidently removed in r1044731
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051357 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 21 Dec 2010 01:53:34 +0000 (01:53 +0000)]
Fix Checkstyle / Eclipse nags
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051356 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 00:32:25 +0000 (00:32 +0000)]
Add in a default that doesnt throw a ClassNotFoundException that is simply ignored, and allow a fast way to change the console formatter through a system property when no config file is used.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051342 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 00:24:24 +0000 (00:24 +0000)]
Test can piggy back on the 'ant test' auto switch between connectors
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051335 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 20 Dec 2010 21:01:37 +0000 (21:01 +0000)]
Implement maxConnections for NIO connector
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051291 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 20 Dec 2010 16:42:13 +0000 (16:42 +0000)]
Implement a maxConnection threshold for the JIoEndpoint, to be able to constraint how many connections the connector will accept
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051202 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 20 Dec 2010 13:58:07 +0000 (13:58 +0000)]
Version numbers are defined in the properties file
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051106 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:44:07 +0000 (17:44 +0000)]
Fix unlikely FindBugs warning
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050684 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:43:41 +0000 (17:43 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050683 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:43:01 +0000 (17:43 +0000)]
Simplify based on StringManager changes
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050682 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:26:52 +0000 (17:26 +0000)]
Typos. Sorry for the noise
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050680 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:19:50 +0000 (17:19 +0000)]
Fix remaining warning in o.a.el.lang package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050679 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 16:23:09 +0000 (16:23 +0000)]
Fix most of the Java, Findbugs and unused code warnings in this package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050660 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 15:52:07 +0000 (15:52 +0000)]
Fix Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050653 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 22:09:28 +0000 (22:09 +0000)]
Fix remaining Eclipse warnings in o.a.juli
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050504 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 22:06:33 +0000 (22:06 +0000)]
Fix remaining Eclipse warnings in o.a.coyote
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050502 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 22:01:59 +0000 (22:01 +0000)]
Fix remaining warnings in unit tests (with recently documented settings)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050500 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 21:51:11 +0000 (21:51 +0000)]
Fix remaining warnings in webapps (with recently documented settings)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050499 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 21:49:54 +0000 (21:49 +0000)]
Fix remaining warnings in javax package (with recently documented settings)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050498 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 21:47:52 +0000 (21:47 +0000)]
Document the Eclipse compiler errors/warnings settings I am using
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050497 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 13:52:22 +0000 (13:52 +0000)]
Avoid a possible NPE that in turn was masking the root cause from JspC
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050384 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 00:17:18 +0000 (00:17 +0000)]
Fix massive memory leak in NIO connector. Http11NioProcessor objects were not being recycled.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050249 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 16 Dec 2010 23:35:17 +0000 (23:35 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=13731
Make variables in <code>_jspService()</code> method final where possible.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050229 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 16 Dec 2010 21:09:49 +0000 (21:09 +0000)]
Starting to work on maxConnections attribute for BIO/NIO connectors to allow administrators to throttle how accepting
connections is handled. Implement a CounterLatch to keep track of the
connection count while also allowing the acceptor
thread block while the max has been reached
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050161 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 16 Dec 2010 21:07:55 +0000 (21:07 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822
changelog + proposed for tomcat 6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050160 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 16 Dec 2010 20:40:36 +0000 (20:40 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050150 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 16 Dec 2010 19:39:58 +0000 (19:39 +0000)]
Fix Findbugs issues / Eclipse warnings.
Some genuine issues
Some changes to make code easier to read (for humans and analysis tools)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050117 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 16 Dec 2010 15:04:56 +0000 (15:04 +0000)]
Fix a FindBugs nag in the unit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049997 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 17:58:05 +0000 (17:58 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=10972
Improve error message if the className attribute is missing on an element in server.xml where it is required.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049654 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 16:41:31 +0000 (16:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=10526
Add alwaysUseSession option to authenticators
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049638 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 14:54:23 +0000 (14:54 +0000)]
Whilst I am thinking about excluding stuff from FindBugs - add some exceptions for the generated code with issues and fix the remaining issues in the same package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049572 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 14:35:22 +0000 (14:35 +0000)]
Add a FindBugs filter config for known false positives
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049564 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 14:34:32 +0000 (14:34 +0000)]
Fix various warnings (FindBugs, Eclipse etc.)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049563 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 13:53:22 +0000 (13:53 +0000)]
Fix another FindBugs niggle
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049553 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 13:31:28 +0000 (13:31 +0000)]
Remove unnecessary override
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049544 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 10:46:23 +0000 (10:46 +0000)]
Fix my stupid mistake.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049484 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 00:57:58 +0000 (00:57 +0000)]
Fix a typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049372 13f79535-47bb-0310-9956-
ffa450edef68
schultz [Tue, 14 Dec 2010 20:53:07 +0000 (20:53 +0000)]
Added documentation to parseBodyMethods and parseBodyMethodSet members.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049264 13f79535-47bb-0310-9956-
ffa450edef68
schultz [Tue, 14 Dec 2010 20:49:28 +0000 (20:49 +0000)]
Fixed bug #49125: toString on byte[] array probably is not correct
- Added HexUtils.toHexString method
- Wrapped output of byte[] objects with a call to HexUtils.toHexString
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049263 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 15:57:54 +0000 (15:57 +0000)]
Log mis-configuration in context.xml
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045201 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 15:06:13 +0000 (15:06 +0000)]
Aliases were broken if the context was reloaded
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045162 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 14:50:17 +0000 (14:50 +0000)]
Fix various FindBugs and Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045156 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 12:47:04 +0000 (12:47 +0000)]
Using abstract classes means impl isn't clear in the startup log. Modify name so it is clear.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045099 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 13 Dec 2010 02:09:32 +0000 (02:09 +0000)]
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
- Use AtomicReference to guard against possible duplicate registration of
listeners when logAccess() is called by several threads at the same time.
- Added install() and uninstall() method to AccessLogListener
to help register/unregister the listeners.
- When defaultAccessLog is nulled, always unregister the listener as well.
The listener does not need to be reused, because now we do create a listener
when there is no log and it will take care of things.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045003 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 13 Dec 2010 01:21:58 +0000 (01:21 +0000)]
changelog for r1044987
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044994 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 13 Dec 2010 00:58:11 +0000 (00:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
Avoid leak caused by using a cached exception instance
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044987 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sun, 12 Dec 2010 22:33:09 +0000 (22:33 +0000)]
Use i18n for the messages
It is followup to r1042022 which was a fix for BZ 48973
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044944 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 19:50:45 +0000 (19:50 +0000)]
Add some tests for bug50449 but haven't reproduced it yet
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044898 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 19:35:56 +0000 (19:35 +0000)]
Fix FindBugs issues in this class
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044896 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 19:27:13 +0000 (19:27 +0000)]
Fix FindBugs issues in this class
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044895 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 18:55:52 +0000 (18:55 +0000)]
i18n changes for r1044874
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044881 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 18:47:10 +0000 (18:47 +0000)]
Use the newly refactored session id generator when generating sso session IDs
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044879 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 18:30:03 +0000 (18:30 +0000)]
Re-factor session ID generation into a separate class so it can be re-used for SSO (patch for that to follow)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044874 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 17:24:47 +0000 (17:24 +0000)]
Fix FindBugs issues in this class
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044858 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Sun, 12 Dec 2010 00:16:33 +0000 (00:16 +0000)]
bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459
Fixed incorrect comment in code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044747 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Sun, 12 Dec 2010 00:10:39 +0000 (00:10 +0000)]
bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459
This fixes the bug that was introduced by http://svn.apache.org/viewvc?rev=
1044145&view=rev (introduced a dedicated thread when starting and stopping web applications to avoid mem leak)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044746 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 22:21:02 +0000 (22:21 +0000)]
TRy and sync up the deps in the POMs with what Checkstyle validates
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044731 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 22:20:10 +0000 (22:20 +0000)]
Tribes should only depend on JULI
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044730 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 21:48:22 +0000 (21:48 +0000)]
o.a.tomcat.jni should not have any external dependencies
OK for o.a.naming to have dependencies
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044729 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 21:35:18 +0000 (21:35 +0000)]
o.a.tomcat.util.net should not depend on o.a.coyote
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044727 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 21:14:45 +0000 (21:14 +0000)]
o.a.tomcat.util.net should not depend on o.a.catalina
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044723 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 20:58:28 +0000 (20:58 +0000)]
Get the checkstyle configs to play nicely with Ant and the Eclipse plug-in
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044716 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 20:38:42 +0000 (20:38 +0000)]
Add import-control checks to Checkstyle (these found the recent dependency issues)
Move checkstyle config to res/checkstyle to stop it cluttering up the root
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044710 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 20:36:29 +0000 (20:36 +0000)]
javax.el should not depend on javax.servlet.jsp.el
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044708 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 11 Dec 2010 18:27:15 +0000 (18:27 +0000)]
Coyote should not depend on Catalina
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044692 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 10 Dec 2010 13:54:16 +0000 (13:54 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50448
Regression caused by http://svn.apache.org/viewvc?view=revision&revision=
1036281
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044359 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 10 Dec 2010 12:28:20 +0000 (12:28 +0000)]
Avoid duplicate constant definition.
Use Constants defined by the Servlet/JSP specs where appropriate
Use Constants in preference to local Strings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044326 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 10 Dec 2010 10:11:38 +0000 (10:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413
Ensure 304s are not returned when using static files as error pages
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044266 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 10 Dec 2010 10:06:44 +0000 (10:06 +0000)]
Missed file in r1044255
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044264 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 10 Dec 2010 09:47:05 +0000 (09:47 +0000)]
Fix FindBugs / unused code warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044255 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 23:58:20 +0000 (23:58 +0000)]
Fix Eclipse warnings in package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044178 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 23:54:21 +0000 (23:54 +0000)]
Fix Eclipse warnings in package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044175 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 23:47:57 +0000 (23:47 +0000)]
Remove redundant interface definitions and fix other warnings (missing @Overrides) in same files
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044171 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 23:30:15 +0000 (23:30 +0000)]
Grrr. Missed a couple of @Override markers
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044164 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 23:29:15 +0000 (23:29 +0000)]
Fix missing @Override markers in Jasper and remove an unnecessary null check
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044162 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 9 Dec 2010 22:11:27 +0000 (22:11 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159
Use a dedicated thread when calling web application code when it is started and stopped (calls to Listeners, Filters, Servlets).
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044145 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 21:11:39 +0000 (21:11 +0000)]
Register the correct object after the refactoring
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044133 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 19:49:24 +0000 (19:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Add an option to control when the socket is bound
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044110 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 19:15:30 +0000 (19:15 +0000)]
mserver != null will never be true if the mbean was registered. Drop the check since the unregister method will handle things correctly anyway
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044093 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 19:02:01 +0000 (19:02 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Log the right message at the right point
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044091 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 9 Dec 2010 18:59:14 +0000 (18:59 +0000)]
ignore work and logs directories as discussed on dev list
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044088 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 9 Dec 2010 18:55:04 +0000 (18:55 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159
some formatting after discussion over the list (operator at the end of line, unnecessary cast)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044083 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 9 Dec 2010 18:10:38 +0000 (18:10 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Move ad-hoc attribute handling from the ProtocolHandler to the Endpoint and expose the Endpoint to ServerSocketFactory objects so they can retrieve additional configuration if required. All default components now use explicit configuration rather than relying on the ad-hoc mechanism.
Ensure the hooks for alternative SSL implementations are in place (were partially removed).
Remove the hooks for alternative ServerSocketFactory implementations (had been hard-coded / half implemented for some time).
Make the sslEnabledProtocols attribute work with BIO as well.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044058 13f79535-47bb-0310-9956-
ffa450edef68
schultz [Thu, 9 Dec 2010 14:35:28 +0000 (14:35 +0000)]
- Fixed brace and paren placement
- Changed Connector.isParseBodyMethod from public -> protected
- Relaxed language claiming that use of parseBodyMethods may "violate" the servlet spec
- Moved error message to LocalStrings.properties (Translations requested)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1043983 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 8 Dec 2010 22:25:04 +0000 (22:25 +0000)]
Removed a little more unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1043734 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 8 Dec 2010 17:15:50 +0000 (17:15 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
ProtocolHandler should register itself with MBean server rather than have the connector do it.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1043531 13f79535-47bb-0310-9956-
ffa450edef68