markt [Mon, 11 Jul 2011 22:27:06 +0000 (22:27 +0000)]
Protect against infinite loops in the HTTP NIO connector if sendfile is configured to send more data than is available in the file. (markt)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145383 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 22:08:30 +0000 (22:08 +0000)]
A little bit of docs is better than nothing ...
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145381 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 22:08:06 +0000 (22:08 +0000)]
Remove unused attribute
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145380 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 21:10:08 +0000 (21:10 +0000)]
Remove unused import
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145355 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 19:06:15 +0000 (19:06 +0000)]
Use en_US as locale for creationdate in WebdavServlet.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145296 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 11 Jul 2011 18:40:48 +0000 (18:40 +0000)]
Followup to r1145209
Do not expose TCN_FULL_VERSION as a public constant, but calculate it when needed.
Using this way it will be easier to throw away the code in AprEndpoint when it becomes unneeded.
I do not mind reintroducing the constant if it were used in two or more places.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145285 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 11 Jul 2011 18:10:11 +0000 (18:10 +0000)]
Expose recently added "encoding" and "locale" options of AccessLogValve through JMX.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145268 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 17:13:06 +0000 (17:13 +0000)]
- Remove unused code:
Cookie dates are formatted elsewhere.
This class used a very strange format:
" EEEE, dd-MMM-yy kk:mm:ss zz"
- Add log.isDebugEnabled()
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145246 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 16:51:54 +0000 (16:51 +0000)]
Always use en_US as locale for timestamps in
ExtendedAccessLogValve.
The format is specified in
http://www.w3.org/TR/WD-logfile.html
and states that the supported timestamps
"yyyy-MM-dd" and "HH:mm:ss" are defined with
ascii digits and GMT.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145238 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 11 Jul 2011 16:46:28 +0000 (16:46 +0000)]
* JULI FileHandler, AccessLogValve:
Create a directory automatically when it is specified as a part of the file name, e.g. in the prefix attribute. Earlier this happened only if it was specified with the directory attribute.
* AccessLogValve:
Log a failure if access log file cannot be opened.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145237 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 16:10:15 +0000 (16:10 +0000)]
Revert unintended commit
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145225 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 16:08:23 +0000 (16:08 +0000)]
Improve logging of error conditions
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145224 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 15:44:10 +0000 (15:44 +0000)]
BZ 51477: Support all SSL protocol combinations in the
APR/native connector.
This only works when using the native library
version 1.1.21 or later which is not yet released.
Older tcnative versions will use an unchanged
config parser. Otherwise non-supported protocol
combinations would be unnoticed.
For easier review of the changes in AprEndpoint
use "svn -x -w" to ignore white space.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145209 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 11 Jul 2011 15:13:13 +0000 (15:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46252
Allow to specify character set to be used to write the access log in AccessLogValve.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145200 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 14:18:32 +0000 (14:18 +0000)]
Fix javadoc.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145186 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 13:17:09 +0000 (13:17 +0000)]
Allow choosing a locale for timestamp formatting
in AccessLogValve. Only relevant to timestamps
explicitely given by SimpleDateFormat syntax.
Also: use Locale.US for CLF and for timestamps
that are part of the access log file name.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145166 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 13:16:29 +0000 (13:16 +0000)]
Ignore doc copied in during build process
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145165 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 13:05:30 +0000 (13:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51494
Prevent an NPE when a long running request completes if the associated web application was destroyed while the request was processing
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145160 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 11 Jul 2011 12:16:36 +0000 (12:16 +0000)]
Replace <tt> by <code> in docs.
The physical markup <tt> was only
used in few places. Mostly we use
the logical markup <code>.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145137 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 09:37:58 +0000 (09:37 +0000)]
Update changelog for bz51490 fixes
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145093 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 09:32:32 +0000 (09:32 +0000)]
Fix broken HTML
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145088 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 09:31:09 +0000 (09:31 +0000)]
Fix broken HTML
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145086 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 09:29:28 +0000 (09:29 +0000)]
Reduce variable scope to reduce testing issues
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145084 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 09:28:25 +0000 (09:28 +0000)]
Ensure it is clear when tag isn't working
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145083 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jul 2011 09:19:59 +0000 (09:19 +0000)]
Fix broken HTML
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1145081 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jul 2011 22:05:01 +0000 (22:05 +0000)]
Add a simple AJP test.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144976 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jul 2011 21:59:51 +0000 (21:59 +0000)]
Make it easier to test that the right response was returned
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144972 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 21:24:15 +0000 (21:24 +0000)]
Set includeantruntime in jdbc-pool javac
build tasks.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144966 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 21:23:33 +0000 (21:23 +0000)]
Fix version pattern in jdbc-pool manifest.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144964 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 20:29:30 +0000 (20:29 +0000)]
Add jdbc-pool to jarsToSkip.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144955 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 20:08:26 +0000 (20:08 +0000)]
Reorganize jdbc-pool inclusion in releases.
Split build (code and docs) from clean.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144951 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 20:07:26 +0000 (20:07 +0000)]
Add changelog entry for Filip's inclusion
of jdbc-pool in releases.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144950 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 20:04:28 +0000 (20:04 +0000)]
Move new changelog entries to correct subsection.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144948 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jul 2011 14:40:00 +0000 (14:40 +0000)]
Make it easier for tests to override the protocol (e.g. to test AJP)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144868 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 14:33:12 +0000 (14:33 +0000)]
Add missing thread name in RequestProcessor when Servlet 3 Async
is used.
Fixes null thread name in access log and probably JMX MBean.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144865 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 13:03:49 +0000 (13:03 +0000)]
Disable one test validation in TestAsyncContextImpl
if an AccessLogValve has been activated.
The test relies on receiving data via
StandardEngine.logAccess() which is already
handled by the other AccessLog.
By default no AccessLogValve is activated, so the
validation is still done.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144854 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 11:22:40 +0000 (11:22 +0000)]
Another regression in 7.0.18: year number formatting
in AccessLogValve is broken due to type "yyy" instead of "yyyy".
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144833 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jul 2011 11:02:22 +0000 (11:02 +0000)]
Remove unused code.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144823 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jul 2011 10:59:45 +0000 (10:59 +0000)]
7.0.18 not released
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144818 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jul 2011 10:53:51 +0000 (10:53 +0000)]
7.0.18 not released
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144817 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 10:10:33 +0000 (10:10 +0000)]
Add option test.accesslog to activate AccessLog
for unit tests.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144802 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Sun, 10 Jul 2011 06:53:36 +0000 (06:53 +0000)]
Fix regression producing invalid MBean names when using IPV6
addresses for connectors.
- revert r1135088
- remove the surrounding quotes only when
passing the name to the endpoint, so they
don't end up in the middle of thread names.
The thread names are used as MBean attribute
values, but not in MBean names.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144785 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Jul 2011 16:56:49 +0000 (16:56 +0000)]
Update to Eclipse JDT Compiler 3.7
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144706 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Jul 2011 16:38:39 +0000 (16:38 +0000)]
Update to Commons Daemon 1.0.6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144701 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Jul 2011 16:05:42 +0000 (16:05 +0000)]
Remove some more unnecessary code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144690 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Jul 2011 15:21:46 +0000 (15:21 +0000)]
Add regression fix to changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144682 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Jul 2011 00:28:44 +0000 (00:28 +0000)]
Fix Comet with HTTP/APR connector
r1144391 switched the key for the processor map for this connector from the socket to the socket wrapper. That prevented Comet from being able to retrieve the processor from the map when processing a comet event.
This commit changes all the connectors to map the socket (or rather whatever the SocketWrapper wraps) to the processor rather than the SocketWrapper.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144557 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 18:01:30 +0000 (18:01 +0000)]
Pull up Handler.process
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144405 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 17:28:25 +0000 (17:28 +0000)]
Align AJP and HTTP prior to pulling up Handler.process
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144393 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 17:19:38 +0000 (17:19 +0000)]
Pull up Handler.process for the Http11 connectors.
Note that this is an intermediate step. The aim is to pull this up to AbstractProtocol
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144391 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 17:19:19 +0000 (17:19 +0000)]
Pull up Handler.process for the Ajp Connectors.
Note that this is an intermediate step. The aim is to pull this up to AbstractProtocol
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144390 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 16:19:28 +0000 (16:19 +0000)]
Yet more protocol alignment (with an eye to aligning with AJP)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144375 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Fri, 8 Jul 2011 15:34:18 +0000 (15:34 +0000)]
Change eol-style and add link to jdbc-pool on the documentation home page
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144358 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 15:10:01 +0000 (15:10 +0000)]
More protocol alignment (with an eye to aligning with AJP)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144354 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 14:59:43 +0000 (14:59 +0000)]
Protocol will call recycle
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144349 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 14:04:08 +0000 (14:04 +0000)]
Bring the Http11 protocol implementations closer together.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144317 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 11:56:33 +0000 (11:56 +0000)]
Completely align process methods
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144276 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 11:49:50 +0000 (11:49 +0000)]
Align the process methods some more.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144272 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 11:40:36 +0000 (11:40 +0000)]
Align the process methods some more.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144271 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 11:21:37 +0000 (11:21 +0000)]
Remove unnecessary call. Socket can't be in connections at this point.
Leave currently unused socket parameter in method - plan to use it in later re-factoring
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144266 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 11:19:32 +0000 (11:19 +0000)]
Improve comments
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144264 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 10:45:19 +0000 (10:45 +0000)]
Fix regression in connector re-factoring that was too aggressive cleaning up AJP/BIO between requests triggering 400 entries in the access log
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144246 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jul 2011 09:50:02 +0000 (09:50 +0000)]
Fix indentation
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144225 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 22:14:07 +0000 (22:14 +0000)]
Pull up reset for remoteHost etc. to a common location
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144077 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:58:51 +0000 (21:58 +0000)]
Remove pointless code (see finally block just above)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144069 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:57:13 +0000 (21:57 +0000)]
Pull up asyncDispatch()
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144067 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 7 Jul 2011 21:40:05 +0000 (21:40 +0000)]
Include jdbc-pool into tomcat release.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144061 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:23:42 +0000 (21:23 +0000)]
No functional change - make it the same as BIO & APR
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144050 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:22:43 +0000 (21:22 +0000)]
Missed a reference to comet which will always be false in asyncDispatch
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144049 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:22:01 +0000 (21:22 +0000)]
Remove unnecessary throws
Move timeout lookups to where the timeouts are reset (in preparation for this being in a separate method)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144048 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:18:11 +0000 (21:18 +0000)]
Collapse the multiple if statements
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144046 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:17:25 +0000 (21:17 +0000)]
Post refactoring, can't be processing a comet request in asyncDispatch
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144045 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 21:00:18 +0000 (21:00 +0000)]
Add re-factoring to the changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144033 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 20:58:11 +0000 (20:58 +0000)]
Already loaded via SecurityClassLoad
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144032 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jul 2011 20:53:51 +0000 (20:53 +0000)]
Use SecurityClassLoad to pre-load HexUtils to prevent a security exception
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1144031 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 23:22:06 +0000 (23:22 +0000)]
Update ready for next release
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143609 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 23:12:15 +0000 (23:12 +0000)]
Remove debug code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143605 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 16:31:31 +0000 (16:31 +0000)]
Refactor to avoid NPEs during test
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143488 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 15:05:45 +0000 (15:05 +0000)]
Correct regression caused by connector re-factoring that meant that sendfile data was not reset between pipe-lined HTTP requests.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143457 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 12:34:27 +0000 (12:34 +0000)]
Fix typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143380 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 12:31:50 +0000 (12:31 +0000)]
Add sync to fix test failures on Linux.
Should have minimal impact in normal Tomcat usage since each instance/JVM only opens a single socket.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143379 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jul 2011 10:51:18 +0000 (10:51 +0000)]
Refactor the bind call to reduce the length of the stack traces when the unit tests fail. It probably won't fix the issue but it will make the logs easier to read.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143334 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 20:33:28 +0000 (20:33 +0000)]
Not just this test failing. Need a better solution. Revert r1143126.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143197 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 19:53:53 +0000 (19:53 +0000)]
Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143188 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 17:28:44 +0000 (17:28 +0000)]
Review comments
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143150 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 16:45:38 +0000 (16:45 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51475
Handle messages larger than the buffer size. Expand test cases to cover this.
Based on a patch by Christian Stöber.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143134 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 16:32:28 +0000 (16:32 +0000)]
Extract test to a test case
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143130 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 16:21:51 +0000 (16:21 +0000)]
Prevent test failures on Linux
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143126 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 12:28:50 +0000 (12:28 +0000)]
Update changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143025 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 12:26:09 +0000 (12:26 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143023 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 12:25:38 +0000 (12:25 +0000)]
Based on current usage within Tomcat, message length of 0 should result in null.
Populate the test for this and ensure the test passes.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143022 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 12:22:03 +0000 (12:22 +0000)]
Remove main method
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143020 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 12:21:37 +0000 (12:21 +0000)]
Remove ununsed methods.
Convert from using main() to a unit test
Use valid test data
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143019 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 12:06:04 +0000 (12:06 +0000)]
Move working JUnit tests to align with package of class being tested.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1143016 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 11:36:41 +0000 (11:36 +0000)]
Limit exclusion to 'old' tests so tests added to o.a.catalina.tribes will execute
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1142996 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 10:42:15 +0000 (10:42 +0000)]
Revert r1142953. The analysis was incorrect.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1142972 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Tue, 5 Jul 2011 10:08:00 +0000 (10:08 +0000)]
Fix response.encodeURL() for the special case of
an absolute URL with no path segment (http://name).
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1142959 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 5 Jul 2011 10:03:06 +0000 (10:03 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Correctly test modifiers when resolving bean methods with the BeanELResolver.
Patch provided by Friedhelm Kuehn.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1142953 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Tue, 5 Jul 2011 08:31:52 +0000 (08:31 +0000)]
Further improvements to the Windows installer
1. Install into "**/Tomcat7.0_servicename" when service name differs from default,
but install into "**/Tomcat7.0" if the name is the default one.
This is to be in line with 7.0.16 and earlier versions, but
differs from 7.0.17 which used "**/Tomcat7.0/servicename".
2. Changed name of registry key for running of Tomcat Monitor
3. Do not forget to delete Tomcat Monitor running entry from HKCU in 32-bit part of registry
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1142923 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Tue, 5 Jul 2011 07:10:31 +0000 (07:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51473
Fix concatenation of values in SecurityConfig.setSecurityProperty()
when the value provided by JRE is null.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1142904 13f79535-47bb-0310-9956-
ffa450edef68