horde.git
15 years agoCatch and log errors
Michael J. Rubinsky [Fri, 19 Feb 2010 17:04:42 +0000 (12:04 -0500)]
Catch and log errors

15 years agoUse Exceptions
Michael J. Rubinsky [Fri, 19 Feb 2010 16:54:56 +0000 (11:54 -0500)]
Use Exceptions

15 years agoAlways load the image before iterating, but make sure it's not already loaded first.
Michael J. Rubinsky [Fri, 19 Feb 2010 16:03:44 +0000 (11:03 -0500)]
Always load the image before iterating, but make sure it's not already loaded first.

If we attempt to call #load() twice, it will reload the raw data into Horde_Image,
thus resetting the iterator and causing an infinite loop. Also, use consistent method names.

15 years agows
Michael J. Rubinsky [Fri, 19 Feb 2010 16:02:56 +0000 (11:02 -0500)]
ws

15 years agoThis is no longer a PEAR_Error
Michael J. Rubinsky [Fri, 19 Feb 2010 15:18:10 +0000 (10:18 -0500)]
This is no longer a PEAR_Error

15 years ago...and re-enable the rest of the tests
Michael J. Rubinsky [Fri, 19 Feb 2010 15:13:31 +0000 (10:13 -0500)]
...and re-enable the rest of the tests

15 years agoid is a property, not a method
Michael J. Rubinsky [Fri, 19 Feb 2010 15:12:35 +0000 (10:12 -0500)]
id is a property, not a method

15 years agotests need the path to identify as well
Michael J. Rubinsky [Fri, 19 Feb 2010 15:11:45 +0000 (10:11 -0500)]
tests need the path to identify as well

15 years agofix member name
Michael J. Rubinsky [Fri, 19 Feb 2010 15:10:12 +0000 (10:10 -0500)]
fix member name

15 years agoRemove long config for long deprecated MCAL extension
Michael M Slusarz [Fri, 19 Feb 2010 08:04:48 +0000 (01:04 -0700)]
Remove long config for long deprecated MCAL extension

15 years agoFix class type determination
Michael M Slusarz [Fri, 19 Feb 2010 07:25:18 +0000 (00:25 -0700)]
Fix class type determination

15 years agoAdded run_task script from horde-support
Michael M Slusarz [Fri, 19 Feb 2010 06:59:00 +0000 (23:59 -0700)]
Added run_task script from horde-support

15 years agoFix setting class attribute on spellcheck results DIV
Michael M Slusarz [Fri, 19 Feb 2010 06:36:47 +0000 (23:36 -0700)]
Fix setting class attribute on spellcheck results DIV

15 years agoMake admin pages consistent UI-wise.
Michael M Slusarz [Fri, 19 Feb 2010 06:26:29 +0000 (23:26 -0700)]
Make admin pages consistent UI-wise.

15 years agoNo need for these separate functions
Michael M Slusarz [Fri, 19 Feb 2010 06:22:20 +0000 (23:22 -0700)]
No need for these separate functions

15 years agoFix Horde_Perms usage; remove duplicate notices
Michael M Slusarz [Fri, 19 Feb 2010 06:14:52 +0000 (23:14 -0700)]
Fix Horde_Perms usage; remove duplicate notices

15 years agoFix new DOM usage
Michael M Slusarz [Fri, 19 Feb 2010 06:13:03 +0000 (23:13 -0700)]
Fix new DOM usage

15 years agoFix return from getVersion()
Michael M Slusarz [Fri, 19 Feb 2010 06:12:46 +0000 (23:12 -0700)]
Fix return from getVersion()

15 years agoCSS tweaks
Michael M Slusarz [Fri, 19 Feb 2010 05:42:28 +0000 (22:42 -0700)]
CSS tweaks

15 years agoMove Mark As Unseen/Read into submenu for folders
Michael M Slusarz [Thu, 18 Feb 2010 23:44:44 +0000 (16:44 -0700)]
Move Mark As Unseen/Read into submenu for folders

15 years agoAllow specifying the element that observe the knl's keydown handler.
Michael J. Rubinsky [Fri, 19 Feb 2010 00:33:50 +0000 (19:33 -0500)]
Allow specifying the element that observe the knl's keydown handler.

This is needed in the case when there are other keydown events registered on the document.
There is no guarantee what order they will fire. So, in Kronolith for example, the event detail form
would receive an enter press and save the event before the autocompleter's knl would receive the event.

15 years agom.type will always be horde.alarm here
Michael M Slusarz [Thu, 18 Feb 2010 22:58:30 +0000 (15:58 -0700)]
m.type will always be horde.alarm here

15 years agoNeed to define default value of ajaxView
Michael M Slusarz [Thu, 18 Feb 2010 22:06:43 +0000 (15:06 -0700)]
Need to define default value of ajaxView

15 years agoHave Turba API throw Horde_Exceptions
Michael M Slusarz [Thu, 18 Feb 2010 22:01:53 +0000 (15:01 -0700)]
Have Turba API throw Horde_Exceptions

15 years agoThread view improvements
Michael M Slusarz [Thu, 18 Feb 2010 21:07:22 +0000 (14:07 -0700)]
Thread view improvements

15 years agoNotification event string representation fixes.
Michael M Slusarz [Thu, 18 Feb 2010 21:06:48 +0000 (14:06 -0700)]
Notification event string representation fixes.

15 years agoFix method name.
Jan Schneider [Thu, 18 Feb 2010 22:33:19 +0000 (23:33 +0100)]
Fix method name.

15 years agoFix alarms.
Jan Schneider [Thu, 18 Feb 2010 22:33:07 +0000 (23:33 +0100)]
Fix alarms.

15 years agoFix method name.
Jan Schneider [Thu, 18 Feb 2010 14:31:07 +0000 (15:31 +0100)]
Fix method name.

15 years agoAdd date picker to recurrence end date.
Jan Schneider [Thu, 18 Feb 2010 14:17:15 +0000 (15:17 +0100)]
Add date picker to recurrence end date.

15 years agoThe only KronolithCore methods we call from the outside are go() and the event
Jan Schneider [Thu, 18 Feb 2010 14:01:52 +0000 (15:01 +0100)]
The only KronolithCore methods we call from the outside are go() and the event
handler that we register, so there really isn't a point in separating public
from private methods.

15 years agoAlways open the first tab of an event/task dialog.
Jan Schneider [Thu, 18 Feb 2010 13:56:14 +0000 (14:56 +0100)]
Always open the first tab of an event/task dialog.

15 years agoHide pickers when closing dialogs.
Jan Schneider [Thu, 18 Feb 2010 13:01:40 +0000 (14:01 +0100)]
Hide pickers when closing dialogs.

15 years agoFix license language
Michael M Slusarz [Thu, 18 Feb 2010 07:43:32 +0000 (00:43 -0700)]
Fix license language

15 years agoFix adding body text to forward.
Michael M Slusarz [Thu, 18 Feb 2010 05:18:58 +0000 (22:18 -0700)]
Fix adding body text to forward.

Don't check for locked forward_default pref in forwardMessage(). It
prevents us from adding body text in dimp. A locked preference here
only means not to show the list of forward choices.

15 years agoDon't show forward dropdown image if disabled
Michael M Slusarz [Thu, 18 Feb 2010 04:57:25 +0000 (21:57 -0700)]
Don't show forward dropdown image if disabled

15 years agoFix setting no sound for alarms
Michael M Slusarz [Thu, 18 Feb 2010 01:20:28 +0000 (18:20 -0700)]
Fix setting no sound for alarms

15 years agoFix undefined error.
Michael M Slusarz [Thu, 18 Feb 2010 00:16:19 +0000 (17:16 -0700)]
Fix undefined error.

15 years ago$result isn't used.
Michael M Slusarz [Thu, 18 Feb 2010 00:20:18 +0000 (17:20 -0700)]
$result isn't used.

15 years agoAnother Notification rewrite.
Michael M Slusarz [Tue, 16 Feb 2010 06:27:31 +0000 (23:27 -0700)]
Another Notification rewrite.

First, fix Bug #8870. Fixed by removing Nag specific event type
(nag.alarm).  However, this was just a symptom of a larger problem.

The problem: using application specific Notification handlers to handle
application specific event types.  The problem comes when switching
between applications.  Since these application handlers don't have any
knowledge of each other, events created by one handler may not be able
to be displayed when notify() was eventually called, because another
status handler had replaced the original handler.

The solution: all notifications need to be handled by a single,
centralized source - namely, the horde-level handlers.  Application
specific details are instead injected into the horde-level handler to
extend behavior.

While reworking the code, also provided opportunity to remove all
application-specific code from Notification.  Horde-specific
instantiation (i.e. adding Horde logging and Alarm decorators) is now
done in Horde_Core rather than in the base Notification object.

Additionally, rework some of the complexity added to the package.  I
believe the goal of the recent Notification changes was to make the
Notification package testable and/or usable outside of a base Horde
install.  But these changes also made the code unreadable, redundant,
and overly complex.

e.g. using interfaces where simple class extensions
make much more sense (IMHO - there are very few cases where an interface
makes more sense than an abstract class. Using interfaces for the
Handler class was simply overkill.  Out of the 10 methods defined, there
are only 2 methods useful for decorator purposes - push() and notify().
And any given decorator won't even use both of these.  Having to contort
code to do things like chaining handlers to achieve this in an interface
pattern was almost impossible to follow.  It is much simpler to simply
add decorators directly to the base handler object.

15 years agoImprove identity selection javascript
Michael M Slusarz [Wed, 17 Feb 2010 09:37:43 +0000 (02:37 -0700)]
Improve identity selection javascript

15 years agoprefs cleanups
Michael M Slusarz [Wed, 17 Feb 2010 07:55:38 +0000 (00:55 -0700)]
prefs cleanups

15 years agoremove an pitifully small amount of TODOs
Michael J. Rubinsky [Thu, 18 Feb 2010 01:52:11 +0000 (20:52 -0500)]
remove an pitifully small amount of TODOs

15 years agoUse Ansel_Exceptions
Michael J. Rubinsky [Thu, 18 Feb 2010 01:31:19 +0000 (20:31 -0500)]
Use Ansel_Exceptions

15 years agofix ToggleGalleryActions ajax action
Michael J. Rubinsky [Thu, 18 Feb 2010 00:52:06 +0000 (19:52 -0500)]
fix ToggleGalleryActions ajax action

15 years agoComplete PHP5-ifying Ansel_Image
Michael J. Rubinsky [Thu, 18 Feb 2010 00:35:26 +0000 (19:35 -0500)]
Complete PHP5-ifying Ansel_Image

Use exceptions, move more queries into Ansel_Storage, phpdoc

15 years agoLots of H4 chagnes and improvements
Michael J. Rubinsky [Wed, 17 Feb 2010 23:20:22 +0000 (18:20 -0500)]
Lots of H4 chagnes and improvements

CS changes, PHP5-ify Ansel_Image and Ansel_ImageView classes.
Start moving all SQL queries into Horde_Storage.

15 years agoThrow exception if Imagick extension not available, don't throw exception if no image
Michael J. Rubinsky [Wed, 17 Feb 2010 22:06:05 +0000 (17:06 -0500)]
Throw exception if Imagick extension not available, don't throw exception if no image
data when getting dimensions, just return 0x0

15 years agoFix sprintf parameters
Michael J. Rubinsky [Wed, 17 Feb 2010 22:05:03 +0000 (17:05 -0500)]
Fix sprintf parameters

15 years agoindentation
Michael J. Rubinsky [Wed, 17 Feb 2010 22:04:17 +0000 (17:04 -0500)]
indentation

15 years agoCatch Ansel_Exceptions here
Michael J. Rubinsky [Wed, 17 Feb 2010 22:00:01 +0000 (17:00 -0500)]
Catch Ansel_Exceptions here

15 years agonote multi-image support in CHANGES
Michael J. Rubinsky [Wed, 17 Feb 2010 16:11:13 +0000 (11:11 -0500)]
note multi-image support in CHANGES

15 years agoremove TODO
Michael J. Rubinsky [Wed, 17 Feb 2010 16:11:00 +0000 (11:11 -0500)]
remove TODO

15 years agoAdd Horde_Registry#hasAjaxView() and load non-ajax applications in iframe.
Jan Schneider [Wed, 17 Feb 2010 22:14:09 +0000 (23:14 +0100)]
Add Horde_Registry#hasAjaxView() and load non-ajax applications in iframe.

15 years agoTweak loading and changing views of minical.
Jan Schneider [Wed, 17 Feb 2010 22:13:01 +0000 (23:13 +0100)]
Tweak loading and changing views of minical.

15 years agoWe want encoded urls here.
Jan Schneider [Wed, 17 Feb 2010 21:46:40 +0000 (22:46 +0100)]
We want encoded urls here.

15 years agoFix error checking.
Gunnar Wrobel [Wed, 17 Feb 2010 21:16:39 +0000 (22:16 +0100)]
Fix error checking.

15 years agoTypo
Gunnar Wrobel [Wed, 17 Feb 2010 21:07:06 +0000 (22:07 +0100)]
Typo

15 years agoConvert to exceptions, use type hinting instead of type checking, remove references...
Gunnar Wrobel [Wed, 17 Feb 2010 20:55:36 +0000 (21:55 +0100)]
Convert to exceptions, use type hinting instead of type checking, remove references to PEAR.

15 years agoNet_LDAP2 -> Horde_Ldap
Gunnar Wrobel [Wed, 17 Feb 2010 20:31:47 +0000 (21:31 +0100)]
Net_LDAP2 -> Horde_Ldap

15 years agoNet_LDAP2 -> Horde_Ldap
Gunnar Wrobel [Wed, 17 Feb 2010 20:25:22 +0000 (21:25 +0100)]
Net_LDAP2 -> Horde_Ldap

15 years agoFix error when clicking on draggable events.
Jan Schneider [Wed, 17 Feb 2010 18:06:32 +0000 (19:06 +0100)]
Fix error when clicking on draggable events.

15 years agoAlways return a non-empty result from ajax calls, if the callbacks have to do
Jan Schneider [Wed, 17 Feb 2010 17:56:15 +0000 (18:56 +0100)]
Always return a non-empty result from ajax calls, if the callbacks have to do
some cleanup.
Make task ajax calls more robust.

15 years agoMFB: Catch errors, at least until these throw exceptions
Michael J. Rubinsky [Wed, 17 Feb 2010 15:15:35 +0000 (10:15 -0500)]
MFB: Catch errors, at least until these throw exceptions

15 years agoMissing argument.
Jan Schneider [Wed, 17 Feb 2010 14:41:34 +0000 (15:41 +0100)]
Missing argument.

15 years agoMissed part of the design tweaks.
Jan Schneider [Wed, 17 Feb 2010 14:41:19 +0000 (15:41 +0100)]
Missed part of the design tweaks.

15 years agoFix the package.xml. These are files, not directories.
Gunnar Wrobel [Wed, 17 Feb 2010 12:17:59 +0000 (13:17 +0100)]
Fix the package.xml. These are files, not directories.

15 years agoFix the package.xml
Gunnar Wrobel [Wed, 17 Feb 2010 10:45:22 +0000 (11:45 +0100)]
Fix the package.xml

15 years agoFix testing and do not extend from Horde_Exception_Prior.
Gunnar Wrobel [Thu, 11 Feb 2010 17:21:51 +0000 (18:21 +0100)]
Fix testing and do not extend from Horde_Exception_Prior.

15 years agoAdditional Kolab_Server test fixes.
Gunnar Wrobel [Wed, 10 Feb 2010 09:19:16 +0000 (10:19 +0100)]
Additional Kolab_Server test fixes.

15 years agoCorrect some class names to fix additional tests.
Gunnar Wrobel [Wed, 10 Feb 2010 07:41:55 +0000 (08:41 +0100)]
Correct some class names to fix additional tests.

15 years agoConvert to using the newer Horde_Ldap. Does not really work completely yet but the...
Gunnar Wrobel [Wed, 10 Feb 2010 06:12:03 +0000 (07:12 +0100)]
Convert to using the newer Horde_Ldap. Does not really work completely yet but the test does not error out anymore.

15 years agoUpdate TODO.
Gunnar Wrobel [Wed, 2 Dec 2009 21:55:16 +0000 (22:55 +0100)]
Update TODO.

15 years agoSome more testing of the different search operations.
Gunnar Wrobel [Wed, 11 Nov 2009 07:12:13 +0000 (08:12 +0100)]
Some more testing of the different search operations.

15 years agoBug #8868: Fix charset when converting html -> text
Michael M Slusarz [Wed, 17 Feb 2010 06:46:37 +0000 (23:46 -0700)]
Bug #8868: Fix charset when converting html -> text

15 years agoNot needed
Michael M Slusarz [Wed, 17 Feb 2010 06:30:56 +0000 (23:30 -0700)]
Not needed

15 years agows
Michael M Slusarz [Tue, 16 Feb 2010 06:19:58 +0000 (23:19 -0700)]
ws

15 years agoFix mailbox sorting
Michael M Slusarz [Tue, 16 Feb 2010 05:45:51 +0000 (22:45 -0700)]
Fix mailbox sorting

15 years ago3rd try
Michael J. Rubinsky [Wed, 17 Feb 2010 01:07:00 +0000 (20:07 -0500)]
3rd try

15 years ago*sigh*
Michael J. Rubinsky [Wed, 17 Feb 2010 01:06:29 +0000 (20:06 -0500)]
*sigh*

15 years ago2nd try
Michael J. Rubinsky [Wed, 17 Feb 2010 01:05:20 +0000 (20:05 -0500)]
2nd try

15 years agoH4 naming conventions
Michael J. Rubinsky [Wed, 17 Feb 2010 00:40:06 +0000 (19:40 -0500)]
H4 naming conventions

15 years agoSome H4 changes, start cleaning up Image object, improve logic, less iteration etc...
Michael J. Rubinsky [Wed, 17 Feb 2010 00:04:13 +0000 (19:04 -0500)]
Some H4 changes, start cleaning up Image object, improve logic, less iteration etc...

15 years agoWhups: make sure permissionsFilter() works for Queue Contents block
Ben Klang [Tue, 16 Feb 2010 21:56:53 +0000 (16:56 -0500)]
Whups: make sure permissionsFilter() works for Queue Contents block

15 years agoSupport for multipage images.
Michael J. Rubinsky [Tue, 16 Feb 2010 21:37:06 +0000 (16:37 -0500)]
Support for multipage images.

Adding a multipage TIFF image will now create a new subgallery in the current
gallery, with each page added as an image to that gallery. This completes
Request: #6022

15 years agoMore style tweaks.
Jan Schneider [Tue, 16 Feb 2010 18:12:25 +0000 (19:12 +0100)]
More style tweaks.

15 years agoEnable and style application drop down.
Jan Schneider [Tue, 16 Feb 2010 17:37:41 +0000 (18:37 +0100)]
Enable and style application drop down.
Add border to top navigation.

15 years agows, style
Michael J. Rubinsky [Tue, 16 Feb 2010 17:02:14 +0000 (12:02 -0500)]
ws, style

15 years agounused
Michael J. Rubinsky [Tue, 16 Feb 2010 16:58:15 +0000 (11:58 -0500)]
unused

15 years agoUse injector to get notification object
Michael J. Rubinsky [Tue, 16 Feb 2010 16:56:05 +0000 (11:56 -0500)]
Use injector to get notification object

15 years agoAll redirects done in Const'r
Michael J. Rubinsky [Tue, 16 Feb 2010 16:28:42 +0000 (11:28 -0500)]
All redirects done in Const'r

Make sure all redirects Ansel_Views need are done in the Const'r since
most likely headers will have been sent by the time html() is called.
These still need to be cleaned up, probably some of the globals
are gettable from $injector etc... but now at least Ansel views work again.

15 years agoTry the current framework directory too.
Jan Schneider [Tue, 16 Feb 2010 10:44:25 +0000 (11:44 +0100)]
Try the current framework directory too.

15 years agows
Michael M Slusarz [Tue, 16 Feb 2010 00:41:57 +0000 (17:41 -0700)]
ws

15 years agoFix Horde_Image usage in imp
Michael M Slusarz [Tue, 16 Feb 2010 00:41:47 +0000 (17:41 -0700)]
Fix Horde_Image usage in imp

15 years agoHorde_Alarm now throws exceptions
Michael M Slusarz [Mon, 15 Feb 2010 20:46:04 +0000 (13:46 -0700)]
Horde_Alarm now throws exceptions

15 years agoRevert "Make sure we have send more then just the <HEAD> of the document"
Michael J. Rubinsky [Mon, 15 Feb 2010 21:12:51 +0000 (16:12 -0500)]
Revert "Make sure we have send more then just the <HEAD> of the document"

Cr*p - this breaks redirects in the List view.  Going to have to revisit
the HTML output for all the views. addScriptFile and outputInlineScript seem
to misbehave when used in conjection with output buffering.

This reverts commit d02caf6b50f8d1b793bf4306e95dd4c89fda8ad3.

15 years agoMake sure we have send more then just the <HEAD> of the document
Michael J. Rubinsky [Mon, 15 Feb 2010 21:05:49 +0000 (16:05 -0500)]
Make sure we have send more then just the <HEAD> of the document
before we call Ansel_View#html so any inline script has somewhere to
go.

15 years agows
Michael J. Rubinsky [Mon, 15 Feb 2010 19:19:13 +0000 (14:19 -0500)]
ws

15 years agoMost apps don't use bodyId and/or bodyClass variables
Michael Slusarz [Sun, 14 Feb 2010 22:02:29 +0000 (15:02 -0700)]
Most apps don't use bodyId and/or bodyClass variables

15 years agoUse the horde common-header template when creating prefs screen
Michael Slusarz [Sun, 14 Feb 2010 22:01:50 +0000 (15:01 -0700)]
Use the horde common-header template when creating prefs screen