markt [Fri, 7 Jan 2011 10:05:07 +0000 (10:05 +0000)]
Fix various warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1056234 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 6 Jan 2011 23:53:11 +0000 (23:53 +0000)]
Fix bug https://issues.apache.org/bugzilla/show_bug.cgi?id=50477
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1056125 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Thu, 6 Jan 2011 21:38:35 +0000 (21:38 +0000)]
Followup to r1055989
Do not use $Id if svn:keywords property is not set.
BTW, @author tags are deprecated, aren't they?
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1056091 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 6 Jan 2011 18:22:34 +0000 (18:22 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49543
Add the ability to specify a data source link, to use a shared datasource with per application credentials
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055989 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 6 Jan 2011 18:09:23 +0000 (18:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550
Make sure PROPFIND,MKCOL,PROPFIND returns 404,201,207 rather than 404,201,404
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055975 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 6 Jan 2011 17:29:01 +0000 (17:29 +0000)]
Fix a couple of FindBugs niggles
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055951 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 6 Jan 2011 17:02:27 +0000 (17:02 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319
Don't return null for getRemoteHost() if the IP address cannot be resolved.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055938 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 6 Jan 2011 16:05:41 +0000 (16:05 +0000)]
Switch all configuration options that use regular expression to require a single regular expression (using java.util.regex<) rather than a list of comma-separated or semi-colon-separated expressions.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055923 13f79535-47bb-0310-9956-
ffa450edef68
kfujino [Thu, 6 Jan 2011 09:17:28 +0000 (09:17 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547.
Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055798 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 5 Jan 2011 23:58:38 +0000 (23:58 +0000)]
allow system to start
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055690 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 15:05:42 +0000 (15:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453
Correctly handle multiple X-Forwarded-For headers
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055482 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 14:28:30 +0000 (14:28 +0000)]
Remove unnecessary code. Valves in this package can use the StringManager defined in ValveBase
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055469 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 13:51:48 +0000 (13:51 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50467
Protect against NPE that will cause Poller to fail
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055458 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 10:10:29 +0000 (10:10 +0000)]
Simplify getContentCount.
Prep for fixing bug 50496
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055391 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 09:57:44 +0000 (09:57 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055389 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 09:47:43 +0000 (09:47 +0000)]
Remove unused methods
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055384 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 09:45:18 +0000 (09:45 +0000)]
Remove unused constants (follow up to r1055377)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055382 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 09:40:09 +0000 (09:40 +0000)]
Remove unused method
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055377 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 08:44:20 +0000 (08:44 +0000)]
Fix required after removing unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055357 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 07:50:11 +0000 (07:50 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055341 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 5 Jan 2011 07:18:29 +0000 (07:18 +0000)]
getContentCount() may return -1 so use getContentCountLong()
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055327 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 22:59:38 +0000 (22:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50527
Improve error message
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055236 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 19:28:16 +0000 (19:28 +0000)]
Doh. Forgot to update the change log.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055147 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 19:20:28 +0000 (19:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
Make accepting name only cookies configurable, defaulting to disabled.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055143 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 19:09:06 +0000 (19:09 +0000)]
Grr. Remove comment markers.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055141 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 4 Jan 2011 18:37:44 +0000 (18:37 +0000)]
No need to instantiate a new driver instance each time, simply reuse the one we got
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055137 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 18:28:23 +0000 (18:28 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
Consistently handle name only cookies (which are not spec complaint)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055132 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 17:57:16 +0000 (17:57 +0000)]
Re-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49372
Don't throw an LifecycleException for an invalid transition if a connector fails to start.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055121 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 17:35:06 +0000 (17:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50541
Add support for sizeLimit and timeLimit on the JNDIRealm
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055115 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 17:09:48 +0000 (17:09 +0000)]
Fix typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055103 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 16:56:58 +0000 (16:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50488
Update classpath required when using jsvc and add a note regarding server VMs.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055101 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 4 Jan 2011 15:55:18 +0000 (15:55 +0000)]
Add a test case of no user name change
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055085 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 14:22:52 +0000 (14:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50500
Use correct coercions (as per the EL spec) for arithmetic operations involving string values containing '.', 'e' or 'E'. Based on a patch by Brian Weisleder.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1055055 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 4 Jan 2011 11:53:32 +0000 (11:53 +0000)]
Remove unused imports
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054987 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 23:28:42 +0000 (23:28 +0000)]
one 0 too many on username test
make sure the driver correctly checks url
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054824 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 22:33:06 +0000 (22:33 +0000)]
Up the number of iterations the test runs
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054812 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 22:18:11 +0000 (22:18 +0000)]
version
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054804 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 22:15:35 +0000 (22:15 +0000)]
Increment version number
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054803 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 22:14:21 +0000 (22:14 +0000)]
add in ability to pass through credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=50025
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054801 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 20:11:50 +0000 (20:11 +0000)]
better count check
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054730 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 3 Jan 2011 20:08:47 +0000 (20:08 +0000)]
update link
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054729 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 3 Jan 2011 14:00:29 +0000 (14:00 +0000)]
Update Copyright year.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1054620 13f79535-47bb-0310-9956-
ffa450edef68
rjung [Wed, 29 Dec 2010 20:42:04 +0000 (20:42 +0000)]
Improve documentation of database connection factory.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1053727 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Tue, 21 Dec 2010 22:26:55 +0000 (22:26 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159
- merged LocalStrings.properties file from package o.a.t.u.threads to o.a.t.u.threads.res
- removed 3 i18n keys that are no longer used by tc7. They were used by the old ThreadPool implementation of tc6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051682 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 17:40:57 +0000 (17:40 +0000)]
refactor latch usage, since its shared by all connectors
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051578 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 17:40:34 +0000 (17:40 +0000)]
Fix classpath
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051577 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 17:39:11 +0000 (17:39 +0000)]
Allow to set log formatter when running Junit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051576 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 16:15:16 +0000 (16:15 +0000)]
Allow to specify the test on the command line
ant -Dtest.name=**/TestMax** test
Without the parameter, the default is all tests as specified before
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051540 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 16:14:24 +0000 (16:14 +0000)]
make shared variable volatile
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051539 13f79535-47bb-0310-9956-
ffa450edef68
kfujino [Tue, 21 Dec 2010 09:47:15 +0000 (09:47 +0000)]
Fix webappClassLoader.clearJbdc message key and message in LocalStrings.properties.
Jbdc is corrected to jdbc.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051433 13f79535-47bb-0310-9956-
ffa450edef68
kfujino [Tue, 21 Dec 2010 06:56:09 +0000 (06:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50503.
When web application has a version, Engine level Clustering works correctly.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051392 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 21 Dec 2010 01:57:50 +0000 (01:57 +0000)]
Fix Checkstyle / Eclipse nags
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051358 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 21 Dec 2010 01:56:04 +0000 (01:56 +0000)]
Restore file accidently removed in r1044731
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051357 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 21 Dec 2010 01:53:34 +0000 (01:53 +0000)]
Fix Checkstyle / Eclipse nags
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051356 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 00:32:25 +0000 (00:32 +0000)]
Add in a default that doesnt throw a ClassNotFoundException that is simply ignored, and allow a fast way to change the console formatter through a system property when no config file is used.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051342 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 21 Dec 2010 00:24:24 +0000 (00:24 +0000)]
Test can piggy back on the 'ant test' auto switch between connectors
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051335 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 20 Dec 2010 21:01:37 +0000 (21:01 +0000)]
Implement maxConnections for NIO connector
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051291 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Mon, 20 Dec 2010 16:42:13 +0000 (16:42 +0000)]
Implement a maxConnection threshold for the JIoEndpoint, to be able to constraint how many connections the connector will accept
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051202 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 20 Dec 2010 13:58:07 +0000 (13:58 +0000)]
Version numbers are defined in the properties file
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1051106 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:44:07 +0000 (17:44 +0000)]
Fix unlikely FindBugs warning
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050684 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:43:41 +0000 (17:43 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050683 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:43:01 +0000 (17:43 +0000)]
Simplify based on StringManager changes
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050682 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:26:52 +0000 (17:26 +0000)]
Typos. Sorry for the noise
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050680 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 17:19:50 +0000 (17:19 +0000)]
Fix remaining warning in o.a.el.lang package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050679 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 16:23:09 +0000 (16:23 +0000)]
Fix most of the Java, Findbugs and unused code warnings in this package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050660 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Dec 2010 15:52:07 +0000 (15:52 +0000)]
Fix Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050653 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 22:09:28 +0000 (22:09 +0000)]
Fix remaining Eclipse warnings in o.a.juli
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050504 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 22:06:33 +0000 (22:06 +0000)]
Fix remaining Eclipse warnings in o.a.coyote
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050502 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 22:01:59 +0000 (22:01 +0000)]
Fix remaining warnings in unit tests (with recently documented settings)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050500 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 21:51:11 +0000 (21:51 +0000)]
Fix remaining warnings in webapps (with recently documented settings)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050499 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 21:49:54 +0000 (21:49 +0000)]
Fix remaining warnings in javax package (with recently documented settings)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050498 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 21:47:52 +0000 (21:47 +0000)]
Document the Eclipse compiler errors/warnings settings I am using
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050497 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 13:52:22 +0000 (13:52 +0000)]
Avoid a possible NPE that in turn was masking the root cause from JspC
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050384 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 17 Dec 2010 00:17:18 +0000 (00:17 +0000)]
Fix massive memory leak in NIO connector. Http11NioProcessor objects were not being recycled.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050249 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 16 Dec 2010 23:35:17 +0000 (23:35 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=13731
Make variables in <code>_jspService()</code> method final where possible.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050229 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 16 Dec 2010 21:09:49 +0000 (21:09 +0000)]
Starting to work on maxConnections attribute for BIO/NIO connectors to allow administrators to throttle how accepting
connections is handled. Implement a CounterLatch to keep track of the
connection count while also allowing the acceptor
thread block while the max has been reached
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050161 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 16 Dec 2010 21:07:55 +0000 (21:07 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822
changelog + proposed for tomcat 6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050160 13f79535-47bb-0310-9956-
ffa450edef68
slaurent [Thu, 16 Dec 2010 20:40:36 +0000 (20:40 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050150 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 16 Dec 2010 19:39:58 +0000 (19:39 +0000)]
Fix Findbugs issues / Eclipse warnings.
Some genuine issues
Some changes to make code easier to read (for humans and analysis tools)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1050117 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 16 Dec 2010 15:04:56 +0000 (15:04 +0000)]
Fix a FindBugs nag in the unit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049997 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 17:58:05 +0000 (17:58 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=10972
Improve error message if the className attribute is missing on an element in server.xml where it is required.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049654 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 16:41:31 +0000 (16:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=10526
Add alwaysUseSession option to authenticators
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049638 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 14:54:23 +0000 (14:54 +0000)]
Whilst I am thinking about excluding stuff from FindBugs - add some exceptions for the generated code with issues and fix the remaining issues in the same package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049572 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 14:35:22 +0000 (14:35 +0000)]
Add a FindBugs filter config for known false positives
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049564 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 14:34:32 +0000 (14:34 +0000)]
Fix various warnings (FindBugs, Eclipse etc.)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049563 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 13:53:22 +0000 (13:53 +0000)]
Fix another FindBugs niggle
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049553 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 13:31:28 +0000 (13:31 +0000)]
Remove unnecessary override
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049544 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 10:46:23 +0000 (10:46 +0000)]
Fix my stupid mistake.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049484 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 15 Dec 2010 00:57:58 +0000 (00:57 +0000)]
Fix a typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049372 13f79535-47bb-0310-9956-
ffa450edef68
schultz [Tue, 14 Dec 2010 20:53:07 +0000 (20:53 +0000)]
Added documentation to parseBodyMethods and parseBodyMethodSet members.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049264 13f79535-47bb-0310-9956-
ffa450edef68
schultz [Tue, 14 Dec 2010 20:49:28 +0000 (20:49 +0000)]
Fixed bug #49125: toString on byte[] array probably is not correct
- Added HexUtils.toHexString method
- Wrapped output of byte[] objects with a call to HexUtils.toHexString
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1049263 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 15:57:54 +0000 (15:57 +0000)]
Log mis-configuration in context.xml
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045201 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 15:06:13 +0000 (15:06 +0000)]
Aliases were broken if the context was reloaded
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045162 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 14:50:17 +0000 (14:50 +0000)]
Fix various FindBugs and Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045156 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 13 Dec 2010 12:47:04 +0000 (12:47 +0000)]
Using abstract classes means impl isn't clear in the startup log. Modify name so it is clear.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045099 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 13 Dec 2010 02:09:32 +0000 (02:09 +0000)]
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
- Use AtomicReference to guard against possible duplicate registration of
listeners when logAccess() is called by several threads at the same time.
- Added install() and uninstall() method to AccessLogListener
to help register/unregister the listeners.
- When defaultAccessLog is nulled, always unregister the listener as well.
The listener does not need to be reused, because now we do create a listener
when there is no log and it will take care of things.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1045003 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 13 Dec 2010 01:21:58 +0000 (01:21 +0000)]
changelog for r1044987
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044994 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 13 Dec 2010 00:58:11 +0000 (00:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
Avoid leak caused by using a cached exception instance
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044987 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sun, 12 Dec 2010 22:33:09 +0000 (22:33 +0000)]
Use i18n for the messages
It is followup to r1042022 which was a fix for BZ 48973
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044944 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 12 Dec 2010 19:50:45 +0000 (19:50 +0000)]
Add some tests for bug50449 but haven't reproduced it yet
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1044898 13f79535-47bb-0310-9956-
ffa450edef68