Jan Schneider [Fri, 12 Feb 2010 22:33:06 +0000 (23:33 +0100)]
No need to pass the Variables object around.
Jan Schneider [Fri, 12 Feb 2010 21:48:16 +0000 (22:48 +0100)]
We don't want the backtrace in notifications, use getMessage().
Jan Schneider [Sun, 14 Feb 2010 22:39:10 +0000 (23:39 +0100)]
Fix Exception calling.
Jan Schneider [Sun, 14 Feb 2010 22:23:40 +0000 (23:23 +0100)]
Wicked classes and constants are not autoloadable yet.
Jan Schneider [Sun, 14 Feb 2010 22:23:20 +0000 (23:23 +0100)]
Fix variable name.
Jan Schneider [Sun, 14 Feb 2010 18:57:41 +0000 (19:57 +0100)]
Since this is the default path for linked libraries now, enable it.
Jan Schneider [Sun, 14 Feb 2010 18:37:03 +0000 (19:37 +0100)]
MFB: Simplify
Jan Schneider [Sun, 14 Feb 2010 18:35:45 +0000 (19:35 +0100)]
MFB:
Take care of appending session parameter ourselves, because the parameter must
not be encoded, but we still don't want the full url.
Jan Schneider [Sun, 14 Feb 2010 18:33:25 +0000 (19:33 +0100)]
MFB: Don't use WikiWords in menus (Request #7021).
Jan Schneider [Sun, 14 Feb 2010 18:29:17 +0000 (19:29 +0100)]
MFB: Check for lock when renaming/merging.
Jan Schneider [Sun, 14 Feb 2010 18:28:16 +0000 (19:28 +0100)]
MFB:
Only StandardPages support locking.
Fix permission check when editing pages.
Allow editing for the owner of the lock without having to unlock first.
Jan Schneider [Sun, 14 Feb 2010 18:20:23 +0000 (19:20 +0100)]
MFB: Unlock page when cancelling the edit.
Jan Schneider [Sun, 14 Feb 2010 16:16:19 +0000 (17:16 +0100)]
Decode html entities too in cli mode.
Jan Schneider [Thu, 4 Feb 2010 23:06:43 +0000 (00:06 +0100)]
No longer a todo.
Michael J. Rubinsky [Sun, 14 Feb 2010 21:49:13 +0000 (16:49 -0500)]
Complete implementation of Iterator support in Horde_Image.
This works in Imagemagick and Imagick only. GD will always return a clone of itself;
(GD doesn't support TIFF or PDF, and has no native methods for obtaining individual pages from GIF)
Multipage images (TIFF, GIF, PDF etc...) can now be either iterated as so:
<code>
// $original Image contains a multipage image
foreach($original as $page) {
// $page is a Horde_Image object representing the single page
}
</code>
or individually select the page as so:
<code>
$page = $original->getImageAtIndex($pageNumber);
</code>
Horde_Image_Base#getImagePageCount returns the total number of pages.
Michael J. Rubinsky [Sun, 14 Feb 2010 21:48:32 +0000 (16:48 -0500)]
(finally) update horde's config to reflect new Horde_Image driver structure
Michael J. Rubinsky [Sun, 14 Feb 2010 16:53:11 +0000 (11:53 -0500)]
update tests
Michael J. Rubinsky [Sun, 14 Feb 2010 16:48:06 +0000 (11:48 -0500)]
Start work on implementing an Iterator for Horde_Image for supporting multi-page images.
Add Iterator interface to Horde_Image_Base and implement it in Horde_Image_Imagick. Other
backend support to come. Allows iterating through all images in a multi-page image such
as TIFF or animatted GIFs
This also goes towards a solution for Request: 6022
Michael J. Rubinsky [Sun, 14 Feb 2010 15:27:04 +0000 (10:27 -0500)]
tweak capability array
Michael J. Rubinsky [Sun, 14 Feb 2010 15:17:28 +0000 (10:17 -0500)]
Consistent style
Michael J. Rubinsky [Sat, 13 Feb 2010 21:06:47 +0000 (16:06 -0500)]
fix Horde_Perms constant
Michael J. Rubinsky [Sat, 13 Feb 2010 20:11:17 +0000 (15:11 -0500)]
[mjr] Allow creation of default, personal address book when other read-only sources are present.
Michael J. Rubinsky [Sat, 13 Feb 2010 19:26:31 +0000 (14:26 -0500)]
Log deletion of objects from _deleteAll() in Horde_History
Bug: 8755
Michael J. Rubinsky [Sat, 13 Feb 2010 17:51:21 +0000 (12:51 -0500)]
MFB - use realPath here.
Bug: 8760
Michael J. Rubinsky [Sat, 13 Feb 2010 15:24:13 +0000 (10:24 -0500)]
Delete the mapMarker when clearing the Location text field
Michael J. Rubinsky [Sat, 13 Feb 2010 14:30:06 +0000 (09:30 -0500)]
Fix method name
Gunnar Wrobel [Fri, 12 Feb 2010 22:21:12 +0000 (23:21 +0100)]
Add some notes to the package.xml and update using the Packaging script.
Michael J. Rubinsky [Fri, 12 Feb 2010 21:59:49 +0000 (16:59 -0500)]
Fix event edit form loading when maps are not available
Michael J. Rubinsky [Fri, 12 Feb 2010 20:49:30 +0000 (15:49 -0500)]
ws
Michael J. Rubinsky [Fri, 12 Feb 2010 20:47:40 +0000 (15:47 -0500)]
Add a Null HordeMap.Geocoder driver and add to Kronolith
Returns error for geocoding requests and lat/lng pair for reverse geocoding requests
Jan Schneider [Fri, 12 Feb 2010 21:37:01 +0000 (22:37 +0100)]
Fix if Nag is not installed.
Gunnar Wrobel [Fri, 12 Feb 2010 21:34:14 +0000 (22:34 +0100)]
Update using the Packaging script.
Gunnar Wrobel [Fri, 12 Feb 2010 21:33:48 +0000 (22:33 +0100)]
WS
Gunnar Wrobel [Fri, 12 Feb 2010 21:33:32 +0000 (22:33 +0100)]
If you want to run the unit tests in the Exception package you need the Horde_Test package -> optional dependency.
Gunnar Wrobel [Wed, 10 Feb 2010 07:42:55 +0000 (08:42 +0100)]
Basic conversion from Net_LDAP2 to Horde_Ldap to make the Util class accessible.
Gunnar Wrobel [Wed, 10 Feb 2010 06:15:25 +0000 (07:15 +0100)]
Basic conversion from Net_LDAP2 to Horde_Ldap to make the Search class accessible. The class does not extend the PEAR class any longer and the call to the PEAR() method has been removed.
Gunnar Wrobel [Wed, 10 Feb 2010 06:14:13 +0000 (07:14 +0100)]
The class does not extend the PEAR class any longer so avoid calling the PEAR method.
Gunnar Wrobel [Wed, 10 Feb 2010 06:13:18 +0000 (07:13 +0100)]
Add missing Exception class.
Ben Klang [Wed, 30 Dec 2009 16:16:56 +0000 (11:16 -0500)]
Add static methods from old Horde_LDAP library
Ben Klang [Wed, 30 Dec 2009 16:06:13 +0000 (11:06 -0500)]
Whitespace fixes
Ben Klang [Fri, 18 Dec 2009 03:36:57 +0000 (22:36 -0500)]
Convert to proper exceptions
Ben Klang [Fri, 18 Dec 2009 03:15:14 +0000 (22:15 -0500)]
Fix comment whitespace
Ben Klang [Fri, 18 Dec 2009 03:08:38 +0000 (22:08 -0500)]
Fix directory nesting, comment whitespace
Ben Klang [Fri, 18 Dec 2009 02:58:37 +0000 (21:58 -0500)]
Horde-ify Horde_Ldap library. Switch to real exception handling.
Ben Klang [Fri, 18 Dec 2009 00:40:07 +0000 (19:40 -0500)]
Fork Net_LDAP2 to Horde_Ldap
Reasons:
1) Net_LDAP2 does not conform to E_STRICT on PHP5
2) Net_LDAP2 does not use exceptions, but instead checks for and returns PEAR_Error objects.
Ben Klang [Wed, 30 Dec 2009 23:48:06 +0000 (18:48 -0500)]
Deprecate former Horde_LDAP library
Jan Schneider [Fri, 12 Feb 2010 19:33:51 +0000 (20:33 +0100)]
Add mouse scrolling for due date/time too.
Jan Schneider [Fri, 12 Feb 2010 19:32:34 +0000 (20:32 +0100)]
Set default due date/time.
Jan Schneider [Fri, 12 Feb 2010 17:47:21 +0000 (18:47 +0100)]
Fix saving all-day events.
Jan Schneider [Fri, 12 Feb 2010 17:37:58 +0000 (18:37 +0100)]
Simplify selectors.
Jan Schneider [Fri, 12 Feb 2010 17:35:49 +0000 (18:35 +0100)]
Fix error with IE and prototype.
Jan Schneider [Fri, 12 Feb 2010 15:39:18 +0000 (16:39 +0100)]
Add close button to growler logs too.
Jan Schneider [Fri, 12 Feb 2010 15:21:44 +0000 (16:21 +0100)]
Style
Jan Schneider [Fri, 12 Feb 2010 15:00:49 +0000 (16:00 +0100)]
Return the current log status again.
Jan Schneider [Fri, 12 Feb 2010 14:50:31 +0000 (15:50 +0100)]
Always show close button.
Jan Schneider [Fri, 12 Feb 2010 14:33:00 +0000 (15:33 +0100)]
Only show map link if the is a location.
Tweak edit form.
Jan Schneider [Fri, 12 Feb 2010 14:07:46 +0000 (15:07 +0100)]
Create all-day event when clicking in the all-day row.
Jan Schneider [Fri, 12 Feb 2010 13:32:50 +0000 (14:32 +0100)]
Always and consitently reset edit forms before deciding whether to load date
into them.
Jan Schneider [Fri, 12 Feb 2010 13:20:07 +0000 (14:20 +0100)]
Show due date, even if the task isn't due yet.
Jan Schneider [Fri, 12 Feb 2010 13:08:54 +0000 (14:08 +0100)]
Reset due date and time when loading tasks.
Jan Schneider [Fri, 12 Feb 2010 12:58:20 +0000 (13:58 +0100)]
Fix parse error.
Jan Schneider [Fri, 12 Feb 2010 12:21:37 +0000 (13:21 +0100)]
Replace is_a() calls.
Fade out PEAR_Error.
Jan Schneider [Fri, 12 Feb 2010 12:04:18 +0000 (13:04 +0100)]
Use Horde_Exception_NotFound.
Jan Schneider [Fri, 12 Feb 2010 11:03:44 +0000 (12:03 +0100)]
Fix saving due dates.
Jan Schneider [Fri, 12 Feb 2010 10:56:18 +0000 (11:56 +0100)]
getEvent() doesn't return PEAR_Errors anymore.
Jan Schneider [Fri, 12 Feb 2010 10:49:56 +0000 (11:49 +0100)]
Re-enable inactive task forms.
Create task cache when adding a first task.
Show "no items" initially when no tasks exist from the start.
Catch edge case when to-be-deleted tasks don't exist anymore.
Jan Schneider [Fri, 12 Feb 2010 10:38:16 +0000 (11:38 +0100)]
Sort
Jan Schneider [Fri, 12 Feb 2010 10:34:46 +0000 (11:34 +0100)]
Don't react on clicks and mouseovers of the 'no items' row.
Jan Schneider [Fri, 12 Feb 2010 10:33:16 +0000 (11:33 +0100)]
We don't need a custom notification handler for Kronolith anymore.
Jan Schneider [Thu, 11 Feb 2010 22:09:50 +0000 (23:09 +0100)]
Fix scope.
Michael M Slusarz [Thu, 11 Feb 2010 21:16:06 +0000 (14:16 -0700)]
Bug #8867: refactor Horde::getServiceLink() for general use, not just menu-related use
Michael M Slusarz [Thu, 11 Feb 2010 20:56:29 +0000 (13:56 -0700)]
Use Horde_Injector to instantiate Horde_Perms
Resource savings - many pages don't need permissions checking, so only
create Perms object if needed.
Michael M Slusarz [Thu, 11 Feb 2010 19:58:14 +0000 (12:58 -0700)]
Horde_Perms now created with Horde_Injector
Michael M Slusarz [Thu, 11 Feb 2010 19:50:38 +0000 (12:50 -0700)]
Remove Horde_Cli::singleton().
If calling appInit() with 'cli' parameter set to true, the global
variable $cli will contain the Horde_Cli instance.
Michael M Slusarz [Thu, 11 Feb 2010 19:35:23 +0000 (12:35 -0700)]
Use global notification object
Michael M Slusarz [Thu, 11 Feb 2010 19:20:20 +0000 (12:20 -0700)]
Always utilize global Horde_Browser object
Michael M Slusarz [Thu, 11 Feb 2010 19:14:36 +0000 (12:14 -0700)]
Check that the file exists and has contents when uploading
Michael M Slusarz [Thu, 11 Feb 2010 19:01:01 +0000 (12:01 -0700)]
Horde_Script_Files fixes/improvements
Don't use private methods (not sure how this was working anymore)
Use injector to hold singleton object
Michael M Slusarz [Thu, 11 Feb 2010 18:54:53 +0000 (11:54 -0700)]
Fix duplicate output of javascript files
Michael J. Rubinsky [Thu, 11 Feb 2010 19:31:04 +0000 (14:31 -0500)]
Typos
Sumbmitted By: rsalmon (at) mbpgroup (dot) com
Michael M Slusarz [Thu, 11 Feb 2010 18:02:56 +0000 (11:02 -0700)]
This is an int, not null. Was breaking all sorts of stuff
Jan Schneider [Thu, 11 Feb 2010 17:53:55 +0000 (18:53 +0100)]
Don't overwrite .kronolithToday in year view.
Jan Schneider [Thu, 11 Feb 2010 17:50:49 +0000 (18:50 +0100)]
Floats casted to strings are locale dependant. Use sprintf() with %F instead.
Michael M Slusarz [Thu, 11 Feb 2010 17:47:20 +0000 (10:47 -0700)]
Request #6232: Show alarm notifications in DIMP.
Michael M Slusarz [Thu, 11 Feb 2010 17:41:23 +0000 (10:41 -0700)]
Fix error notification.
Michael M Slusarz [Thu, 11 Feb 2010 17:36:01 +0000 (10:36 -0700)]
'driver' can be null but Horde_Alarm will use default sql values.
Gunnar Wrobel [Thu, 11 Feb 2010 14:31:06 +0000 (15:31 +0100)]
CS
Gunnar Wrobel [Thu, 11 Feb 2010 14:01:44 +0000 (15:01 +0100)]
Update the Injector package.xml using the Packaging script.
Gunnar Wrobel [Thu, 11 Feb 2010 13:57:52 +0000 (14:57 +0100)]
Complete coverage.
Gunnar Wrobel [Thu, 11 Feb 2010 13:52:26 +0000 (14:52 +0100)]
Complete coverage.
Gunnar Wrobel [Thu, 11 Feb 2010 13:48:13 +0000 (14:48 +0100)]
Omit warning during autoloading when an included file does not exist.
Otherwise some test may fail under strict conditions since
class_exists() and new ReflectionClass() suddenly emit a warning for
non-existant classes. See tests in Horde_Injector that test for
reactions on specifying non existing Instances.
Gunnar Wrobel [Thu, 11 Feb 2010 12:15:51 +0000 (13:15 +0100)]
Update the package.xml using the Packaging script.
Gunnar Wrobel [Thu, 11 Feb 2010 11:32:09 +0000 (12:32 +0100)]
Typo
Gunnar Wrobel [Thu, 11 Feb 2010 11:11:48 +0000 (12:11 +0100)]
Complete exception testing.
Gunnar Wrobel [Thu, 11 Feb 2010 10:56:27 +0000 (11:56 +0100)]
Support previous exceptions in PHP < 5.3.0.
Taken from http://framework.zend.com/wiki/display/ZFPROP/previous+Exception+on+Zend_Exception+-+Marc+Bennewitz
Jan Schneider [Thu, 11 Feb 2010 10:50:19 +0000 (11:50 +0100)]
Fix tests.
Gunnar Wrobel [Thu, 11 Feb 2010 10:07:15 +0000 (11:07 +0100)]
Extract PEAR and exception handling into a separate class.
Again we always know when we throw a PEAR Error or an exception at
Horde_Exception. It is not necessary to have the class trying to
determine what the arguments might have been.
Gunnar Wrobel [Thu, 11 Feb 2010 08:29:43 +0000 (09:29 +0100)]
Do not convert incorrect code types to integer automatically.
If $code is null it will be converted to 0 by the default Exception
anyhow.
If $code contains a string it will elicit a Fatal Error. But that is
okay and should not be hidden. In nearly all cases where we provided a
string as $code it was a simple coding error that needs to be fixed.
There may be cases where the code is a value returned from another
library. If it is uncertain that the library ensures that the return
value is an integer then it can be cast into an integer before
providing it to the exception.
Gunnar Wrobel [Thu, 11 Feb 2010 08:09:59 +0000 (09:09 +0100)]
Extract the error_get_last() handling into a separate Exception class.
In all cases (Horde_Feed, Horde_Xml_Element, Horde_Yaml, and Horde_Http) where
we throw the result from error_get_last() into the exception class we know
exactly that we are doing so.
Rather than having the Exception class trying to determine what kind of
parameters it might have received we can use a separate class for that.
Jan Schneider [Thu, 11 Feb 2010 09:51:45 +0000 (10:51 +0100)]
Use Horde_Exception_PermissionDenied.