tomcat7.0
15 years agoMinor fixes
markt [Wed, 21 Apr 2010 12:07:05 +0000 (12:07 +0000)]
Minor fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@936274 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove mystery method
markt [Tue, 20 Apr 2010 22:19:42 +0000 (22:19 +0000)]
Remove mystery method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@936091 13f79535-47bb-0310-9956-ffa450edef68

15 years agogetCookies is a httpServletRequestMethod, not a httpServletResponseMethod
markt [Tue, 20 Apr 2010 22:11:15 +0000 (22:11 +0000)]
getCookies is a httpServletRequestMethod, not a httpServletResponseMethod

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@936086 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49141
markt [Tue, 20 Apr 2010 19:49:10 +0000 (19:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49141
Stop Findbugs complaining

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@936047 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49158
fhanik [Tue, 20 Apr 2010 17:13:37 +0000 (17:13 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49158
Session cookies should only set one header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935998 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd test case for bug 49158
fhanik [Tue, 20 Apr 2010 16:34:27 +0000 (16:34 +0000)]
Add test case for bug 49158

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935984 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=48589
kkolinko [Tue, 20 Apr 2010 16:30:52 +0000 (16:30 +0000)]
Additional patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=48589
Do not access JNDIRealm$User class fields directly, but use the getter methods,
as (theoretically) those can be overwritten in subclasses.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935983 13f79535-47bb-0310-9956-ffa450edef68

15 years agoremove null check.
kfujino [Tue, 20 Apr 2010 00:46:19 +0000 (00:46 +0000)]
remove null check.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935777 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49151
kfujino [Mon, 19 Apr 2010 10:12:02 +0000 (10:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49151

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935510 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49150
kfujino [Mon, 19 Apr 2010 10:07:16 +0000 (10:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49150

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935509 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove the ChatServlet comet example.
kkolinko [Sat, 17 Apr 2010 01:59:56 +0000 (01:59 +0000)]
Improve the ChatServlet comet example.
1. Fix possible deadlock in ChatServlet$MessageSender, similar to BZ 48843.
2. Properly wake up ChatServlet$MessageSender when the servlet is destroyed.
3. Filter special characters when printing the message in ChatServlet.
4. Provide an explicit charset everywhere.
5. Fix frames layout. Fix redirections.
Use target="<name>" attribute in HTML to send request to a particular frame.
6. Fix DTDs. Use frameset DTD for the page containing frames.
7. Add "xxx joined the chat" message at startup.
8. Rename chat.jsp -> index.jsp, so that the entry point to this example is more visible.
9. Corrected the link that opens a new chat window. It referenced an undefined JavaScript function. Now it is implemented just by using target="_blank".
10. Added submit button to the form pages.
11. Minor message tweaks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935105 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore checking against the spec
markt [Fri, 16 Apr 2010 22:39:55 +0000 (22:39 +0000)]
More checking against the spec

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935092 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet build working with relative base.path
markt [Fri, 16 Apr 2010 20:41:11 +0000 (20:41 +0000)]
Get build working with relative base.path

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@935077 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused dependency on o.a.t.util.collections.MultiMap.
kkolinko [Fri, 16 Apr 2010 15:44:51 +0000 (15:44 +0000)]
Remove unused dependency on o.a.t.util.collections.MultiMap.
An indication here is that MultiMap$Field.name and .value fields are never assigned.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934968 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix asyn with APR.
jfclere [Fri, 16 Apr 2010 14:44:50 +0000 (14:44 +0000)]
Fix asyn with APR.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934936 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReview section 4. More stuff to do.
markt [Fri, 16 Apr 2010 06:45:39 +0000 (06:45 +0000)]
Review section 4. More stuff to do.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934696 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean up a bit
fhanik [Fri, 16 Apr 2010 03:37:59 +0000 (03:37 +0000)]
Clean up a bit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934677 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd in statement cache
fhanik [Fri, 16 Apr 2010 00:02:53 +0000 (00:02 +0000)]
Add in statement cache

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934651 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect a misprint (s/provide/provided), wrap the long line.
kkolinko [Thu, 15 Apr 2010 23:41:52 +0000 (23:41 +0000)]
Correct a misprint (s/provide/provided), wrap the long line.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934647 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFollowup to r934220.
kkolinko [Thu, 15 Apr 2010 23:36:49 +0000 (23:36 +0000)]
Followup to r934220.
Set svn:eol-style=native for the added files. No change in their content.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934644 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSection 3 of spec checked
markt [Thu, 15 Apr 2010 23:07:22 +0000 (23:07 +0000)]
Section 3 of spec checked

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934640 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImplement SRV.3.2. Non file parts should be exposed via getParameters()
markt [Thu, 15 Apr 2010 22:57:36 +0000 (22:57 +0000)]
Implement SRV.3.2. Non file parts should be exposed via getParameters()
Cache results so multiple calls to getParts() work

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934634 13f79535-47bb-0310-9956-ffa450edef68

15 years agoif error, next request
fhanik [Thu, 15 Apr 2010 15:38:17 +0000 (15:38 +0000)]
if error, next request

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934457 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSection 3.2 of the Servlet 3 spec says getParameter should still work for parameters...
markt [Thu, 15 Apr 2010 15:01:55 +0000 (15:01 +0000)]
Section 3.2 of the Servlet 3 spec says getParameter should still work for parameters that do not represent file uploads (it doesn't at the moment - patch to follow)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934438 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate release plan.
markt [Thu, 15 Apr 2010 12:06:24 +0000 (12:06 +0000)]
Update release plan.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934382 13f79535-47bb-0310-9956-ffa450edef68

15 years agosessionCounter and expiredSessions declares as long instead of int.
kfujino [Thu, 15 Apr 2010 09:19:02 +0000 (09:19 +0000)]
sessionCounter and expiredSessions declares as long instead of int.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934337 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49024
markt [Wed, 14 Apr 2010 23:17:26 +0000 (23:17 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49024
Enhance the RemoteIpFilter docs
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934239 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49129
markt [Wed, 14 Apr 2010 23:13:45 +0000 (23:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49129

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934238 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49118
markt [Wed, 14 Apr 2010 22:50:35 +0000 (22:50 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49118
Use StringBuilder rather than concatenation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934234 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49110
markt [Wed, 14 Apr 2010 22:47:57 +0000 (22:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49110
Make inner class static to prevent possible memory leak - found by FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934233 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49109
markt [Wed, 14 Apr 2010 22:43:37 +0000 (22:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49109
Remove unused authenticate() method with a broken default impl

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934232 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49106
markt [Wed, 14 Apr 2010 22:29:34 +0000 (22:29 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49106
Remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934225 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49105
markt [Wed, 14 Apr 2010 22:27:59 +0000 (22:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49105
Misc Javadoc corrections.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934224 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49104
markt [Wed, 14 Apr 2010 22:24:17 +0000 (22:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49104
Generics

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934223 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49103
markt [Wed, 14 Apr 2010 22:19:33 +0000 (22:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49103
Add @Override where appropriate

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934222 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTwo BCEL files have IBM copyright and EPL licensing. Update LICENSE and NOTICE files...
markt [Wed, 14 Apr 2010 22:11:30 +0000 (22:11 +0000)]
Two BCEL files have IBM copyright and EPL licensing. Update LICENSE and NOTICE files accordingly.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934220 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCPL allows us to elect to distribute under a later version of the license so elect...
markt [Wed, 14 Apr 2010 22:10:35 +0000 (22:10 +0000)]
CPL allows us to elect to distribute under a later version of the license so elect to distribute under EPL as we are already using EPL for Eclipse JDT.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934219 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't include modules in the src release
markt [Wed, 14 Apr 2010 21:40:13 +0000 (21:40 +0000)]
Don't include modules in the src release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934207 13f79535-47bb-0310-9956-ffa450edef68

15 years agoParametrise current year in all embedded NOTICE files
markt [Wed, 14 Apr 2010 21:25:20 +0000 (21:25 +0000)]
Parametrise current year in all embedded NOTICE files
Don't use the same property name for different output files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934203 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd license headers to NSIS files
markt [Wed, 14 Apr 2010 20:51:19 +0000 (20:51 +0000)]
Add license headers to NSIS files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934192 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAL2 header
markt [Wed, 14 Apr 2010 20:18:14 +0000 (20:18 +0000)]
AL2 header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934173 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTomcat 7 needs Java 6
markt [Wed, 14 Apr 2010 20:11:59 +0000 (20:11 +0000)]
Tomcat 7 needs Java 6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934170 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd info on API stability to the release.
markt [Wed, 14 Apr 2010 18:00:34 +0000 (18:00 +0000)]
Add info on API stability to the release.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934067 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFully fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49082
markt [Wed, 14 Apr 2010 14:46:07 +0000 (14:46 +0000)]
Fully fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49082

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933972 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49045
markt [Wed, 14 Apr 2010 12:07:04 +0000 (12:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49045
Add support for adding Services and Engines via JMX
Based on a patch by Chamith Buddhika

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933921 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
markt [Wed, 14 Apr 2010 10:14:34 +0000 (10:14 +0000)]
Alternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49089

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933907 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49116
kfujino [Wed, 14 Apr 2010 08:48:43 +0000 (08:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49116
If session is already invalid, expire session to prevent memory leak.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933881 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix download location for native binaries
markt [Tue, 13 Apr 2010 09:59:54 +0000 (09:59 +0000)]
Fix download location for native binaries

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933535 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49086
markt [Mon, 12 Apr 2010 10:34:09 +0000 (10:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49086
Add Javadocs to javax.servlet.annotation
Patch provided by Pid.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933183 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake constant final
markt [Mon, 12 Apr 2010 09:47:42 +0000 (09:47 +0000)]
Make constant final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933168 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49091
markt [Mon, 12 Apr 2010 09:42:07 +0000 (09:42 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49091
Reduce visibility

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933167 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake public constant final
markt [Mon, 12 Apr 2010 09:35:52 +0000 (09:35 +0000)]
Make public constant final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933165 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fox for https://issues.apache.org/bugzilla/show_bug.cgi?id=49082
markt [Mon, 12 Apr 2010 09:26:39 +0000 (09:26 +0000)]
Partial fox for https://issues.apache.org/bugzilla/show_bug.cgi?id=49082
java.home may not include the final path separator

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933162 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd some additional tests
markt [Mon, 12 Apr 2010 08:32:22 +0000 (08:32 +0000)]
Add some additional tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933141 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factor to allow easier addition of extra tests
markt [Mon, 12 Apr 2010 08:26:34 +0000 (08:26 +0000)]
Re-factor to allow easier addition of extra tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933140 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBack to -dev
markt [Sun, 11 Apr 2010 23:02:13 +0000 (23:02 +0000)]
Back to -dev

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933021 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPrepare for RC1 release
markt [Sun, 11 Apr 2010 22:52:44 +0000 (22:52 +0000)]
Prepare for RC1 release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933012 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: EL TCK with security manager
markt [Sun, 11 Apr 2010 22:43:09 +0000 (22:43 +0000)]
TCK failures: EL TCK with security manager

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@933007 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse spec compliant session expiration in STRICT_SERVLET_COMPLIANCE mode.
rjung [Sun, 11 Apr 2010 20:51:16 +0000 (20:51 +0000)]
Use spec compliant session expiration in STRICT_SERVLET_COMPLIANCE mode.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932989 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReduce failures of new API when running under security manager.
rjung [Sun, 11 Apr 2010 18:26:20 +0000 (18:26 +0000)]
Reduce failures of new API when running under security manager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932969 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49081
markt [Sun, 11 Apr 2010 18:15:02 +0000 (18:15 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49081
"#${1+1}" should evaluate to "#2"
Note that all files apart from ELParser.jjt are generated by javacc from the changes to ELParser.jjt

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932967 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd test cases for https://issues.apache.org/bugzilla/show_bug.cgi?id=49081
markt [Sun, 11 Apr 2010 18:09:16 +0000 (18:09 +0000)]
Add test cases for https://issues.apache.org/bugzilla/show_bug.cgi?id=49081
"#${1+1}" should evaluate to "#2"

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932965 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAllow JioEndpoint to switch context class loader
rjung [Sun, 11 Apr 2010 17:47:00 +0000 (17:47 +0000)]
Allow JioEndpoint to switch context class loader
under security manager. Code copied from standard session.

Add two more classes to class pre-loading to improve
security manager interoperability.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932953 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIgnore request handling time in session lastAccessedTime
rjung [Sun, 11 Apr 2010 15:53:07 +0000 (15:53 +0000)]
Ignore request handling time in session lastAccessedTime
when acting servlet spec compliant.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932926 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAnd another property for the policy.
rjung [Sun, 11 Apr 2010 01:46:20 +0000 (01:46 +0000)]
And another property for the policy.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932826 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd another property access to our security policy.
rjung [Sun, 11 Apr 2010 01:26:43 +0000 (01:26 +0000)]
Add another property access to our security policy.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932823 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd permission to read the STRICT_SERVLET_COMPLIANCE property
rjung [Sun, 11 Apr 2010 01:08:09 +0000 (01:08 +0000)]
Add permission to read the STRICT_SERVLET_COMPLIANCE property
to our default policy for the security manager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932822 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd missing class.
jfclere [Sat, 10 Apr 2010 18:07:39 +0000 (18:07 +0000)]
Add missing class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932776 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failure (with security manager): Preload required class.
markt [Sat, 10 Apr 2010 15:53:14 +0000 (15:53 +0000)]
TCK failure (with security manager): Preload required class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932751 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavadoc update
markt [Fri, 9 Apr 2010 11:43:16 +0000 (11:43 +0000)]
Javadoc update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932363 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49075
markt [Fri, 9 Apr 2010 11:16:40 +0000 (11:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49075
NPE protection if roles is null and roles needs to be modifiable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932357 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate EL & JSP versions
markt [Fri, 9 Apr 2010 08:01:07 +0000 (08:01 +0000)]
Update EL & JSP versions
Minor tweaks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932289 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse chunked encoding for http 1.1 requests with no content-length (regardless of...
markt [Wed, 7 Apr 2010 22:17:19 +0000 (22:17 +0000)]
Use chunked encoding for http 1.1 requests with no content-length (regardless of keep-alive) so client can differentiate between complete and partial responses.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931709 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFurther corrections to SSL session timeout attribute name.
markt [Wed, 7 Apr 2010 21:46:55 +0000 (21:46 +0000)]
Further corrections to SSL session timeout attribute name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931699 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo
markt [Wed, 7 Apr 2010 20:11:57 +0000 (20:11 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931664 13f79535-47bb-0310-9956-ffa450edef68

15 years agoStart working on a statement cache. Add in disconnect event for interceptors, make...
fhanik [Wed, 7 Apr 2010 13:54:21 +0000 (13:54 +0000)]
Start working on a statement cache. Add in disconnect event for interceptors, make the statement decorator extensible

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931550 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018
kkolinko [Wed, 7 Apr 2010 03:24:08 +0000 (03:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018
Fix processing of time argument in the "Expire sessions" action in the Manager web application

Also, provide separate templates for the "managerServlet.sessiontimeout" message, to allow it to be properly translated into other languages. I cannot provide the actual translations, though. The translated variants of the new messages are now a mix of English and translated text, which just mimics the old behaviour.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931415 13f79535-47bb-0310-9956-ffa450edef68

15 years agomemberAlive is not called if member has not already existed in membership.
kfujino [Tue, 6 Apr 2010 09:25:59 +0000 (09:25 +0000)]
memberAlive is not called if member has not already existed in membership.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931061 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert accidental commit
markt [Mon, 5 Apr 2010 19:38:28 +0000 (19:38 +0000)]
Revert accidental commit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930936 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix the immediate problem described in https://issues.apache.org/bugzilla/show_bug...
markt [Sun, 4 Apr 2010 16:26:51 +0000 (16:26 +0000)]
Fix the immediate problem described in https://issues.apache.org/bugzilla/show_bug.cgi?id=48648
Still need review remainder of bug report

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930711 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49014
markt [Sun, 4 Apr 2010 10:37:17 +0000 (10:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49014
Add test cases for the RemoteIpFilter
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930659 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48983
markt [Sun, 4 Apr 2010 10:25:56 +0000 (10:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48983
Additional debug logging for when RemoteIp(Valve|Filter) is not invoked

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930657 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48914
markt [Sun, 4 Apr 2010 10:09:18 +0000 (10:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48914
Invoke should use parameters provided in expression in preference to parameters provided in invoke() call

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930653 13f79535-47bb-0310-9956-ffa450edef68

15 years agoModify unit tests to take account of https://issues.apache.org/bugzilla/show_bug...
markt [Sun, 4 Apr 2010 10:08:04 +0000 (10:08 +0000)]
Modify unit tests to take account of https://issues.apache.org/bugzilla/show_bug.cgi?id=48914
Invoke should use parameters provided in expression in preference to parameters provided in invoke() call

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930652 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCleanup. Remove field that is never initialized and never read.
kkolinko [Sat, 3 Apr 2010 17:40:53 +0000 (17:40 +0000)]
Cleanup. Remove field that is never initialized and never read.
req.getResponse() is used instead of it when needed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930549 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: If a servlet/filter has any mappings in the main web.xml, these overrid...
markt [Sat, 3 Apr 2010 12:41:31 +0000 (12:41 +0000)]
TCK failures: If a servlet/filter has any mappings in the main web.xml, these override rather than replace the mappings defined in the fragments. The same goes for fragments and annotations.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930514 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix copy paste error
fhanik [Fri, 2 Apr 2010 14:59:33 +0000 (14:59 +0000)]
Fix copy paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930289 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
markt [Wed, 31 Mar 2010 13:06:30 +0000 (13:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
Failure of one connector should not leave some connectors started and some ignored

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929521 13f79535-47bb-0310-9956-ffa450edef68

15 years agodelete test file
kfujino [Wed, 31 Mar 2010 08:09:40 +0000 (08:09 +0000)]
delete test file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929428 13f79535-47bb-0310-9956-ffa450edef68

15 years agocommit access test
kfujino [Wed, 31 Mar 2010 08:06:13 +0000 (08:06 +0000)]
commit access test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929427 13f79535-47bb-0310-9956-ffa450edef68

15 years agodelete test file
kfujino [Wed, 31 Mar 2010 06:32:46 +0000 (06:32 +0000)]
delete test file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929404 13f79535-47bb-0310-9956-ffa450edef68

15 years agocommit access test
kfujino [Wed, 31 Mar 2010 06:08:32 +0000 (06:08 +0000)]
commit access test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929394 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWhen changing a session ID, use the internal add cookie method in the same way as...
markt [Tue, 30 Mar 2010 21:01:02 +0000 (21:01 +0000)]
When changing a session ID, use the internal add cookie method in the same way as when first creating a session cookie.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929284 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClear up state handling a bit
fhanik [Tue, 30 Mar 2010 16:03:32 +0000 (16:03 +0000)]
Clear up state handling a bit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929181 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895
markt [Mon, 29 Mar 2010 15:01:14 +0000 (15:01 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895
Make clearing thread locals optional and disabled by default since it isn't thread-safe

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928798 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48840
markt [Mon, 29 Mar 2010 11:51:46 +0000 (11:51 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48840
If CDPATH is set, cd may result in output to stdout.
Swallow the output. This is safe since the script outputs the value used for CATALINA_HOME so any issues will be visible then.
Patch provided by mdietze

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928732 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
markt [Mon, 29 Mar 2010 10:37:53 +0000 (10:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
Correctly handle multi-line headers with the NIO connector
Patch suggested by Richa Baronia

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928695 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
markt [Mon, 29 Mar 2010 10:36:55 +0000 (10:36 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
Fix to follow shortly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928694 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNew installer side graphics. Artwork provided by Adela Turk
mturk [Mon, 29 Mar 2010 05:46:57 +0000 (05:46 +0000)]
New installer side graphics. Artwork provided by Adela Turk

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928599 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48717
markt [Sun, 28 Mar 2010 19:34:12 +0000 (19:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48717
When a node joins a cluster and it receives all the current sessions, ensure the sessionCreated event is fired if the Manager is configured to replicate session events

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928482 13f79535-47bb-0310-9956-ffa450edef68