tomcat7.0
14 years agoEnable testcase for 50413#c6, now that the issue is fixed with r1056889.
kkolinko [Sun, 9 Jan 2011 08:10:33 +0000 (08:10 +0000)]
Enable testcase for 50413#c6, now that the issue is fixed with r1056889.
Update changelog.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056890 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413#c6
kkolinko [Sun, 9 Jan 2011 08:07:02 +0000 (08:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413#c6
Serve the error page regardless of "Range" header in the original request.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056889 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdded tests for https://issues.apache.org/bugzilla/show_bug.cgi?id=50413
kkolinko [Sun, 9 Jan 2011 07:13:28 +0000 (07:13 +0000)]
Added tests for https://issues.apache.org/bugzilla/show_bug.cgi?id=50413
The test that is currently failing is commented out and marked with a "FIXME" comment.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056888 13f79535-47bb-0310-9956-ffa450edef68

14 years agoThe TestMapper.performanceTest() takes 3250 msecs to rn for me. I am increasing the...
kkolinko [Sun, 9 Jan 2011 07:11:30 +0000 (07:11 +0000)]
The TestMapper.performanceTest() takes 3250 msecs to rn for me. I am increasing the timeout to be 4s.
Also printing the actual value in case the test fails.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056887 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1055975
kkolinko [Sat, 8 Jan 2011 22:46:02 +0000 (22:46 +0000)]
Followup to r1055975
Move string calculation out of synchronized block

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056828 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=21157
markt [Sat, 8 Jan 2011 22:27:26 +0000 (22:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=21157
Write cookie before response might be committed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056820 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1056386.
kkolinko [Sat, 8 Jan 2011 18:51:56 +0000 (18:51 +0000)]
Followup to r1056386.
Add a changelog entry.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056760 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStringBuffer -> StringBuilder for consistency
markt [Sat, 8 Jan 2011 17:02:10 +0000 (17:02 +0000)]
StringBuffer -> StringBuilder for consistency

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056735 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect typo in the method names in a test case, so that they match to what method...
kkolinko [Sat, 8 Jan 2011 01:09:54 +0000 (01:09 +0000)]
Correct typo in the method names in a test case, so that they match to what method is actually being tested.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056583 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1056553
kkolinko [Sat, 8 Jan 2011 00:50:02 +0000 (00:50 +0000)]
Followup to r1056553
There should not be "import com.sun.jndi.ldap.LdapPoolManager;" as we must not depend on that class at build time. Actually the import was used by JavaDoc comments only.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056576 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFolloup to r1055989
kkolinko [Sat, 8 Jan 2011 00:22:56 +0000 (00:22 +0000)]
Folloup to r1055989
Add qualifiers to the fields of DataSourceLinkFactory.DataSourceHandler class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056569 13f79535-47bb-0310-9956-ffa450edef68

14 years agoProvide two alternative locations for the libraries downloaded from the ASF web site...
kkolinko [Fri, 7 Jan 2011 23:54:54 +0000 (23:54 +0000)]
Provide two alternative locations for the libraries downloaded from the ASF web site at build time. Use the main distribution site as default and the archive one as fallback.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056562 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 50556: improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager
slaurent [Fri, 7 Jan 2011 22:56:30 +0000 (22:56 +0000)]
bug 50556: improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056553 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix security exception when running Servlet TCK
markt [Fri, 7 Jan 2011 18:13:38 +0000 (18:13 +0000)]
Fix security exception when running Servlet TCK

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056434 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate daemon to 1.0.5
mturk [Fri, 7 Jan 2011 16:45:31 +0000 (16:45 +0000)]
Update daemon to 1.0.5

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056386 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate tests now name only cookies are not accepted by default
markt [Fri, 7 Jan 2011 15:16:44 +0000 (15:16 +0000)]
Update tests now name only cookies are not accepted by default

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056344 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix tests after regex changes
markt [Fri, 7 Jan 2011 14:56:50 +0000 (14:56 +0000)]
Fix tests after regex changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056340 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPut sleep in right place for test to pass.
markt [Fri, 7 Jan 2011 13:26:33 +0000 (13:26 +0000)]
Put sleep in right place for test to pass.
With acceptCount of 1 need a short delay else connections get rejected as Tomcat doesn't process incoming connections fast enough (on 8-core machine)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056310 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50496
markt [Fri, 7 Jan 2011 13:01:00 +0000 (13:01 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50496
Differentiate between content written (what the app writes to the output stream) and bytes written (what Tomcat writes to the socket) and use bytes for the access logs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056298 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50552
markt [Fri, 7 Jan 2011 11:24:36 +0000 (11:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50552
Avoid NPE that hides error when using Ant tasks (schultz)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056264 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix some simple FindBugs issues
markt [Fri, 7 Jan 2011 11:02:25 +0000 (11:02 +0000)]
Fix some simple FindBugs issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056256 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50554
markt [Fri, 7 Jan 2011 10:31:59 +0000 (10:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50554
Various FindBugs / Eclipse warnings
Silence the false positives

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056244 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNumerical order, fix indenting
markt [Fri, 7 Jan 2011 10:16:59 +0000 (10:16 +0000)]
Numerical order, fix indenting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056237 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix various warnings
markt [Fri, 7 Jan 2011 10:05:07 +0000 (10:05 +0000)]
Fix various warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056234 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix bug https://issues.apache.org/bugzilla/show_bug.cgi?id=50477
fhanik [Thu, 6 Jan 2011 23:53:11 +0000 (23:53 +0000)]
Fix bug https://issues.apache.org/bugzilla/show_bug.cgi?id=50477

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056125 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1055989
kkolinko [Thu, 6 Jan 2011 21:38:35 +0000 (21:38 +0000)]
Followup to r1055989
Do not use $Id if svn:keywords property is not set.

BTW, @author tags are deprecated, aren't they?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1056091 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49543
fhanik [Thu, 6 Jan 2011 18:22:34 +0000 (18:22 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49543
Add the ability to specify a data source link, to use a shared datasource with per application credentials

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055989 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550
markt [Thu, 6 Jan 2011 18:09:23 +0000 (18:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550
Make sure PROPFIND,MKCOL,PROPFIND returns 404,201,207 rather than 404,201,404

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055975 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix a couple of FindBugs niggles
markt [Thu, 6 Jan 2011 17:29:01 +0000 (17:29 +0000)]
Fix a couple of FindBugs niggles

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055951 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319
markt [Thu, 6 Jan 2011 17:02:27 +0000 (17:02 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319
Don't return null for getRemoteHost() if the IP address cannot be resolved.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055938 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSwitch all configuration options that use regular expression to require a single...
markt [Thu, 6 Jan 2011 16:05:41 +0000 (16:05 +0000)]
Switch all configuration options that use regular expression to require a single regular expression (using java.util.regex<) rather than a list of comma-separated or semi-colon-separated expressions.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055923 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547.
kfujino [Thu, 6 Jan 2011 09:17:28 +0000 (09:17 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547.
Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055798 13f79535-47bb-0310-9956-ffa450edef68

14 years agoallow system to start
fhanik [Wed, 5 Jan 2011 23:58:38 +0000 (23:58 +0000)]
allow system to start

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055690 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453
markt [Wed, 5 Jan 2011 15:05:42 +0000 (15:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453
Correctly handle multiple X-Forwarded-For headers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055482 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code. Valves in this package can use the StringManager defined...
markt [Wed, 5 Jan 2011 14:28:30 +0000 (14:28 +0000)]
Remove unnecessary code. Valves in this package can use the StringManager defined in ValveBase

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055469 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50467
markt [Wed, 5 Jan 2011 13:51:48 +0000 (13:51 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50467
Protect against NPE that will cause Poller to fail

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055458 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSimplify getContentCount.
markt [Wed, 5 Jan 2011 10:10:29 +0000 (10:10 +0000)]
Simplify getContentCount.
Prep for fixing bug 50496

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055391 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Wed, 5 Jan 2011 09:57:44 +0000 (09:57 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055389 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused methods
markt [Wed, 5 Jan 2011 09:47:43 +0000 (09:47 +0000)]
Remove unused methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055384 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused constants (follow up to r1055377)
markt [Wed, 5 Jan 2011 09:45:18 +0000 (09:45 +0000)]
Remove unused constants (follow up to r1055377)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055382 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused method
markt [Wed, 5 Jan 2011 09:40:09 +0000 (09:40 +0000)]
Remove unused method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055377 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix required after removing unused code
markt [Wed, 5 Jan 2011 08:44:20 +0000 (08:44 +0000)]
Fix required after removing unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055357 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Wed, 5 Jan 2011 07:50:11 +0000 (07:50 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055341 13f79535-47bb-0310-9956-ffa450edef68

14 years agogetContentCount() may return -1 so use getContentCountLong()
markt [Wed, 5 Jan 2011 07:18:29 +0000 (07:18 +0000)]
getContentCount() may return -1 so use getContentCountLong()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055327 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50527
markt [Tue, 4 Jan 2011 22:59:38 +0000 (22:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50527
Improve error message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055236 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDoh. Forgot to update the change log.
markt [Tue, 4 Jan 2011 19:28:16 +0000 (19:28 +0000)]
Doh. Forgot to update the change log.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055147 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
markt [Tue, 4 Jan 2011 19:20:28 +0000 (19:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
Make accepting name only cookies configurable, defaulting to disabled.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055143 13f79535-47bb-0310-9956-ffa450edef68

14 years agoGrr. Remove comment markers.
markt [Tue, 4 Jan 2011 19:09:06 +0000 (19:09 +0000)]
Grr. Remove comment markers.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055141 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNo need to instantiate a new driver instance each time, simply reuse the one we got
fhanik [Tue, 4 Jan 2011 18:37:44 +0000 (18:37 +0000)]
No need to instantiate a new driver instance each time, simply reuse the one we got

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055137 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
markt [Tue, 4 Jan 2011 18:28:23 +0000 (18:28 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
Consistently handle name only cookies (which are not spec complaint)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055132 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRe-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49372
markt [Tue, 4 Jan 2011 17:57:16 +0000 (17:57 +0000)]
Re-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49372
Don't throw an LifecycleException for an invalid transition if a connector fails to start.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055121 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50541
markt [Tue, 4 Jan 2011 17:35:06 +0000 (17:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50541
Add support for sizeLimit and timeLimit on the JNDIRealm

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055115 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo
markt [Tue, 4 Jan 2011 17:09:48 +0000 (17:09 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055103 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50488
markt [Tue, 4 Jan 2011 16:56:58 +0000 (16:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50488
Update classpath required when using jsvc and add a note regarding server VMs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055101 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a test case of no user name change
fhanik [Tue, 4 Jan 2011 15:55:18 +0000 (15:55 +0000)]
Add a test case of no user name change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055085 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50500
markt [Tue, 4 Jan 2011 14:22:52 +0000 (14:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50500
Use correct coercions (as per the EL spec) for arithmetic operations involving string values containing '.', 'e' or 'E'. Based on a patch by Brian Weisleder.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055055 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused imports
markt [Tue, 4 Jan 2011 11:53:32 +0000 (11:53 +0000)]
Remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054987 13f79535-47bb-0310-9956-ffa450edef68

14 years agoone 0 too many on username test
fhanik [Mon, 3 Jan 2011 23:28:42 +0000 (23:28 +0000)]
one 0 too many on username test
make sure the driver correctly checks url

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054824 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUp the number of iterations the test runs
fhanik [Mon, 3 Jan 2011 22:33:06 +0000 (22:33 +0000)]
Up the number of iterations the test runs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054812 13f79535-47bb-0310-9956-ffa450edef68

14 years agoversion
fhanik [Mon, 3 Jan 2011 22:18:11 +0000 (22:18 +0000)]
version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054804 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIncrement version number
fhanik [Mon, 3 Jan 2011 22:15:35 +0000 (22:15 +0000)]
Increment version number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054803 13f79535-47bb-0310-9956-ffa450edef68

14 years agoadd in ability to pass through credentials
fhanik [Mon, 3 Jan 2011 22:14:21 +0000 (22:14 +0000)]
add in ability to pass through credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=50025

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054801 13f79535-47bb-0310-9956-ffa450edef68

14 years agobetter count check
fhanik [Mon, 3 Jan 2011 20:11:50 +0000 (20:11 +0000)]
better count check

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054730 13f79535-47bb-0310-9956-ffa450edef68

14 years agoupdate link
fhanik [Mon, 3 Jan 2011 20:08:47 +0000 (20:08 +0000)]
update link

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054729 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate Copyright year.
rjung [Mon, 3 Jan 2011 14:00:29 +0000 (14:00 +0000)]
Update Copyright year.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054620 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove documentation of database connection factory.
rjung [Wed, 29 Dec 2010 20:42:04 +0000 (20:42 +0000)]
Improve documentation of database connection factory.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1053727 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 49159: Improve ThreadLocal memory leak clean-up
slaurent [Tue, 21 Dec 2010 22:26:55 +0000 (22:26 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159

- merged LocalStrings.properties file from package o.a.t.u.threads to o.a.t.u.threads.res
- removed 3 i18n keys that are no longer used by tc7. They were used by the old ThreadPool implementation of tc6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051682 13f79535-47bb-0310-9956-ffa450edef68

14 years agorefactor latch usage, since its shared by all connectors
fhanik [Tue, 21 Dec 2010 17:40:57 +0000 (17:40 +0000)]
refactor latch usage, since its shared by all connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051578 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix classpath
fhanik [Tue, 21 Dec 2010 17:40:34 +0000 (17:40 +0000)]
Fix classpath

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051577 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAllow to set log formatter when running Junit tests
fhanik [Tue, 21 Dec 2010 17:39:11 +0000 (17:39 +0000)]
Allow to set log formatter when running Junit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051576 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAllow to specify the test on the command line
fhanik [Tue, 21 Dec 2010 16:15:16 +0000 (16:15 +0000)]
Allow to specify the test on the command line
ant -Dtest.name=**/TestMax** test
Without the parameter, the default is all tests as specified before

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051540 13f79535-47bb-0310-9956-ffa450edef68

14 years agomake shared variable volatile
fhanik [Tue, 21 Dec 2010 16:14:24 +0000 (16:14 +0000)]
make shared variable volatile

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051539 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix webappClassLoader.clearJbdc message key and message in LocalStrings.properties.
kfujino [Tue, 21 Dec 2010 09:47:15 +0000 (09:47 +0000)]
Fix webappClassLoader.clearJbdc message key and message in LocalStrings.properties.
Jbdc is corrected to jdbc.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051433 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50503.
kfujino [Tue, 21 Dec 2010 06:56:09 +0000 (06:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50503.
When web application has a version, Engine level Clustering works correctly.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051392 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Checkstyle / Eclipse nags
markt [Tue, 21 Dec 2010 01:57:50 +0000 (01:57 +0000)]
Fix Checkstyle / Eclipse nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051358 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRestore file accidently removed in r1044731
markt [Tue, 21 Dec 2010 01:56:04 +0000 (01:56 +0000)]
Restore file accidently removed in r1044731

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051357 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Checkstyle / Eclipse nags
markt [Tue, 21 Dec 2010 01:53:34 +0000 (01:53 +0000)]
Fix Checkstyle / Eclipse nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051356 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd in a default that doesnt throw a ClassNotFoundException that is simply ignored...
fhanik [Tue, 21 Dec 2010 00:32:25 +0000 (00:32 +0000)]
Add in a default that doesnt throw a ClassNotFoundException that is simply ignored, and allow a fast way to change the console formatter through a system property when no config file is used.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051342 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest can piggy back on the 'ant test' auto switch between connectors
fhanik [Tue, 21 Dec 2010 00:24:24 +0000 (00:24 +0000)]
Test can piggy back on the 'ant test' auto switch between connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051335 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImplement maxConnections for NIO connector
fhanik [Mon, 20 Dec 2010 21:01:37 +0000 (21:01 +0000)]
Implement maxConnections for NIO connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051291 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImplement a maxConnection threshold for the JIoEndpoint, to be able to constraint...
fhanik [Mon, 20 Dec 2010 16:42:13 +0000 (16:42 +0000)]
Implement a maxConnection threshold for the JIoEndpoint, to be able to constraint how many connections the connector will accept

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051202 13f79535-47bb-0310-9956-ffa450edef68

14 years agoVersion numbers are defined in the properties file
markt [Mon, 20 Dec 2010 13:58:07 +0000 (13:58 +0000)]
Version numbers are defined in the properties file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051106 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix unlikely FindBugs warning
markt [Sat, 18 Dec 2010 17:44:07 +0000 (17:44 +0000)]
Fix unlikely FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050684 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Sat, 18 Dec 2010 17:43:41 +0000 (17:43 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050683 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSimplify based on StringManager changes
markt [Sat, 18 Dec 2010 17:43:01 +0000 (17:43 +0000)]
Simplify based on StringManager changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050682 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTypos. Sorry for the noise
markt [Sat, 18 Dec 2010 17:26:52 +0000 (17:26 +0000)]
Typos. Sorry for the noise

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050680 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warning in o.a.el.lang package
markt [Sat, 18 Dec 2010 17:19:50 +0000 (17:19 +0000)]
Fix remaining warning in o.a.el.lang package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050679 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix most of the Java, Findbugs and unused code warnings in this package
markt [Sat, 18 Dec 2010 16:23:09 +0000 (16:23 +0000)]
Fix most of the Java, Findbugs and unused code warnings in this package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050660 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Sat, 18 Dec 2010 15:52:07 +0000 (15:52 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050653 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining Eclipse warnings in o.a.juli
markt [Fri, 17 Dec 2010 22:09:28 +0000 (22:09 +0000)]
Fix remaining Eclipse warnings in o.a.juli

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050504 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining Eclipse warnings in o.a.coyote
markt [Fri, 17 Dec 2010 22:06:33 +0000 (22:06 +0000)]
Fix remaining Eclipse warnings in o.a.coyote

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050502 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warnings in unit tests (with recently documented settings)
markt [Fri, 17 Dec 2010 22:01:59 +0000 (22:01 +0000)]
Fix remaining warnings in unit tests (with recently documented settings)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050500 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warnings in webapps (with recently documented settings)
markt [Fri, 17 Dec 2010 21:51:11 +0000 (21:51 +0000)]
Fix remaining warnings in webapps (with recently documented settings)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050499 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warnings in javax package (with recently documented settings)
markt [Fri, 17 Dec 2010 21:49:54 +0000 (21:49 +0000)]
Fix remaining warnings in javax package (with recently documented settings)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050498 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDocument the Eclipse compiler errors/warnings settings I am using
markt [Fri, 17 Dec 2010 21:47:52 +0000 (21:47 +0000)]
Document the Eclipse compiler errors/warnings settings I am using

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050497 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid a possible NPE that in turn was masking the root cause from JspC
markt [Fri, 17 Dec 2010 13:52:22 +0000 (13:52 +0000)]
Avoid a possible NPE that in turn was masking the root cause from JspC

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050384 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix massive memory leak in NIO connector. Http11NioProcessor objects were not being...
markt [Fri, 17 Dec 2010 00:17:18 +0000 (00:17 +0000)]
Fix massive memory leak in NIO connector. Http11NioProcessor objects were not being recycled.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050249 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=13731
markt [Thu, 16 Dec 2010 23:35:17 +0000 (23:35 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=13731
Make variables in <code>_jspService()</code> method final where possible.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050229 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStarting to work on maxConnections attribute for BIO/NIO connectors to allow administ...
fhanik [Thu, 16 Dec 2010 21:09:49 +0000 (21:09 +0000)]
Starting to work on maxConnections attribute for BIO/NIO connectors to allow administrators to throttle how accepting
connections is handled. Implement a CounterLatch to keep track of the
connection count while also allowing the acceptor
thread block while the max has been reached

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050161 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 48822: Include contest name in reload and stop log statements
slaurent [Thu, 16 Dec 2010 21:07:55 +0000 (21:07 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822

changelog + proposed for tomcat 6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050160 13f79535-47bb-0310-9956-ffa450edef68