git.internetallee.de Git

markt [Tue, 1 Mar 2011 12:32:25 +0000 (12:32 +0000)]

Improve handling of SSL renegotiation by failing earlier when the request body contains more bytes than maxSavePostSize.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075792 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 11:12:22 +0000 (11:12 +0000)]

Remove the init from references to handshake since the same fields/methods will be used for renegotiation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075776 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 10:16:36 +0000 (10:16 +0000)]

Extract the client-cert tests into a separate test
Check maxPostSize works as expected with client-cert

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075762 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 09:33:57 +0000 (09:33 +0000)]

Clear remainder of current FindBugs issues in unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075742 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 09:13:18 +0000 (09:13 +0000)]

More entries

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075737 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 09:12:51 +0000 (09:12 +0000)]

Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075736 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 09:02:52 +0000 (09:02 +0000)]

Fix Findbugs nag
Reduce visibility

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075725 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 09:01:30 +0000 (09:01 +0000)]

Grr. This worked if 20 bytes were read in one go

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075724 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 09:00:01 +0000 (09:00 +0000)]

Better fix, we actually need to read 20 byres for the test to pass

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075719 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 08:56:48 +0000 (08:56 +0000)]

Fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075718 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 08:50:40 +0000 (08:50 +0000)]

More explicit failure message - fixed FindBugs nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075713 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 08:44:29 +0000 (08:44 +0000)]

FindBugs fixes - make constants static

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075708 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 08:36:57 +0000 (08:36 +0000)]

Comment tweaks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075699 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 01:23:31 +0000 (01:23 +0000)]

Revert SSL renegotiation for NIO - implementation is broken
Reverts r1074675 and r1075030

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075606 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 1 Mar 2011 01:15:11 +0000 (01:15 +0000)]

Start of an SSL re-negotiation test. Need to expand it to handle request bodies and the other issues highlighted by Filip.
Switch to using a CA since it makes the code cleaner and it is easier to get CLIENT-CERT working than will all self-signed certs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075604 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 28 Feb 2011 19:03:31 +0000 (19:03 +0000)]

Should have moved the keys when I moved the SSL tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075487 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 28 Feb 2011 18:43:44 +0000 (18:43 +0000)]

Fix an Eclipse nag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075474 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 28 Feb 2011 18:15:48 +0000 (18:15 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
Add URL encoding where missing to parameters in URLs presented by Ant tasks to the Manager application.
Based on a patch by Stephane Bailliez.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075458 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 28 Feb 2011 17:24:00 +0000 (17:24 +0000)]

Clarify auth process for CLIENT-CERT

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075435 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 28 Feb 2011 14:14:41 +0000 (14:14 +0000)]

Prep for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075338 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 28 Feb 2011 13:35:41 +0000 (13:35 +0000)]

Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
- consistently pass absolute paths to validateFile()
- handle non-absolute catalina home/base

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075320 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 23:08:45 +0000 (23:08 +0000)]

Fix Eclipse warnings
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075176 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 22:59:10 +0000 (22:59 +0000)]

Clear remaining FindBugs issues from javax.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075175 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 15:53:45 +0000 (15:53 +0000)]

Misc clean-up
- remove unused code
- suppress FindBugs false positives
- add javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075083 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 14:34:19 +0000 (14:34 +0000)]

Another false positive

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 14:31:27 +0000 (14:31 +0000)]

Couple more false positives

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075062 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 14:29:07 +0000 (14:29 +0000)]

Misc clean-up
- Suppress Eclipse warnings
- Remove unused code
- Correct Javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075061 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 14:26:55 +0000 (14:26 +0000)]

Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075060 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 14:12:39 +0000 (14:12 +0000)]

Revert r1075050

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075058 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 13:19:22 +0000 (13:19 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31027
Trim whitespace from names and values obtained from $CATALINA_BASE/conf/catalina.properties to avoid hard to diagnose errors on startup.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075050 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 11:28:01 +0000 (11:28 +0000)]

Block whilst waiting for data from client in NIO SSL-rehandshake rather than spinning the CPU

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075030 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 11:00:12 +0000 (11:00 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
Better documentation of the meaning of Lifecycle.isAvailable() and correct a couple of cases where this could incorrectly return true.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075022 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 27 Feb 2011 10:31:49 +0000 (10:31 +0000)]

Another false positive

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075019 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 26 Feb 2011 20:44:34 +0000 (20:44 +0000)]

Fix FindBugs identified error in Servlet 2.2 jspFile handling

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074919 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 26 Feb 2011 20:40:25 +0000 (20:40 +0000)]

Fix what looks like a copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074918 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 26 Feb 2011 20:07:00 +0000 (20:07 +0000)]

No need to call stop if the app didn't start

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074915 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 26 Feb 2011 20:01:10 +0000 (20:01 +0000)]

Ensure a web application is taken out of service if the web.xml file is not valid.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074914 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 26 Feb 2011 19:37:13 +0000 (19:37 +0000)]

Fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074911 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 25 Feb 2011 19:19:13 +0000 (19:19 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49284
Support SSL re-negotiation in the HTTP NIO connector
There is a fair amount of renaming in this patch. The real work is in the new rehandshake() method in the SecureNioChannel.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074675 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 25 Feb 2011 15:58:08 +0000 (15:58 +0000)]

Avoid NPEs trying to re-negotiate with NIO

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074597 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 24 Feb 2011 17:25:38 +0000 (17:25 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50826
Avoid IAE when Tomcat instance is destroyed without every being started.
Add a test case for this.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074225 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 24 Feb 2011 17:03:27 +0000 (17:03 +0000)]

Don't start NamingResources multiple times

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074215 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 24 Feb 2011 16:01:38 +0000 (16:01 +0000)]

Add documentation for the Crawler Session Manager Valve.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074192 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 24 Feb 2011 14:39:39 +0000 (14:39 +0000)]

Fix comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074168 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 24 Feb 2011 14:15:34 +0000 (14:15 +0000)]

Avoid NPE if no u-a header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074159 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 24 Feb 2011 13:11:17 +0000 (13:11 +0000)]

Restore the CrawlerSessionManagerValve
Local testing with Jira 4.2.4 shows it works.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074132 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 23 Feb 2011 19:25:17 +0000 (19:25 +0000)]

Add security listener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073893 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 23 Feb 2011 19:23:59 +0000 (19:23 +0000)]

Add the SecurityListener (disabled by default) that prevents Tomcat from starting if configured insecurely.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073891 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 23 Feb 2011 11:58:47 +0000 (11:58 +0000)]

Better handling in acceptor threads if server hits ulimit for open files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073711 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Tue, 22 Feb 2011 22:45:43 +0000 (22:45 +0000)]

doco update bug 50805

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073532 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Tue, 22 Feb 2011 22:42:44 +0000 (22:42 +0000)]

https://issues.apache.org/bugzilla/show_bug.cgi?id=50805
Make sure we only call borrowConnection once per connection per checkout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073531 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 22 Feb 2011 16:38:39 +0000 (16:38 +0000)]

Test before generating debug log messages
Fix FindBugs issues for File.delete() return value

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073393 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 22 Feb 2011 12:55:56 +0000 (12:55 +0000)]

Remove unused code, fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073320 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 22 Feb 2011 11:48:09 +0000 (11:48 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=21669
Add the ability to specify the roleBase for the JNDI Realm as relative to the users DN. Based on a patch by Art W.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073301 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 22 Feb 2011 11:08:42 +0000 (11:08 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=19444
Add an option to the JNDI realm to allow role searches to be performed by the authenticated user.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073296 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 22 Feb 2011 10:46:02 +0000 (10:46 +0000)]

Refactoring to remove duplicate code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073289 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 21 Feb 2011 23:21:09 +0000 (23:21 +0000)]

Convert to Javadoc comment and add some additional info

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073184 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 21 Feb 2011 16:23:05 +0000 (16:23 +0000)]

Smarter solution for bug 48863

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073047 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 21 Feb 2011 13:15:53 +0000 (13:15 +0000)]

Servletapi-2.3 appears to have disappeared from the maven1 repo.
Switch everything to maven2 repo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072962 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 21 Feb 2011 12:59:50 +0000 (12:59 +0000)]

Fix javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072960 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 21:45:49 +0000 (21:45 +0000)]

Fix indentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072161 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 21:44:13 +0000 (21:44 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
Re-factor to remove parallel arrays.
Modify fix for 48863 to remove use of StringManager as it is not available in Bootstrap

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072160 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 20:58:16 +0000 (20:58 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
Better logging when specifying an invalid directory for a class loader.
Based on a patch by Ralf Hauser.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072145 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 20:48:56 +0000 (20:48 +0000)]

Exclude a check

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072144 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 20:44:55 +0000 (20:44 +0000)]

Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072140 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 20:43:46 +0000 (20:43 +0000)]

Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072138 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 20:39:48 +0000 (20:39 +0000)]

Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072136 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 16:53:08 +0000 (16:53 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50743
Cache CheckStyle results between builds to speed up validation. Patch provided by Oliver.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072057 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 16:24:36 +0000 (16:24 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50189
Once the application has finished writing to the response, prevent further reads from the request since this causes various problems in the connectors which do not expect this.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072042 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 18 Feb 2011 15:30:57 +0000 (15:30 +0000)]

line length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072024 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 20:38:49 +0000 (20:38 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50802
Ensure that ServletContext.getResourcePaths() includes static resources packaged in JAR files in its output.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071774 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Thu, 17 Feb 2011 19:42:05 +0000 (19:42 +0000)]

Update ignore list with the full set

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071757 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Thu, 17 Feb 2011 18:22:23 +0000 (18:22 +0000)]

ignore list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071735 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Thu, 17 Feb 2011 18:16:22 +0000 (18:16 +0000)]

Update version numbers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071734 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Thu, 17 Feb 2011 16:23:44 +0000 (16:23 +0000)]

Correctly use the readFully method. Add a utility method to sort absolute order

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071677 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 16:08:08 +0000 (16:08 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50780
Fix memory leak in APR implementation of AJP connector introduced by the refactoring for bug 49884

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071671 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 14:11:41 +0000 (14:11 +0000)]

Remove unnecessary code.
I don't see a code path that could result in the socket being in the map at this point

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071617 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 14:04:37 +0000 (14:04 +0000)]

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 13:10:36 +0000 (13:10 +0000)]

Fix NPEs on shutdown. Loop is prevented above when the child is removed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071601 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 12:11:36 +0000 (12:11 +0000)]

Typo? Copy and paste error?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071592 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 12:10:32 +0000 (12:10 +0000)]

Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071591 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 10:32:07 +0000 (10:32 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50789
Provide an option to enable ServletRequestListeners for forwards as required by some CDI frameworks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071565 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 09:59:30 +0000 (09:59 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50790
Improve method resolution in EL expressions
Add test cases for this bug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071561 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Thu, 17 Feb 2011 09:51:17 +0000 (09:51 +0000)]

Remove duplicate code.

The implementation in the base class is identical and all other http11 implementations also inherit it from there.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071560 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 09:46:52 +0000 (09:46 +0000)]

Prevent NPE in unit tests as a result of r1067718

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071559 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 09:29:58 +0000 (09:29 +0000)]

Fix test failure now r1069056 has added stricter checks for state transitions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071557 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 17 Feb 2011 09:20:16 +0000 (09:20 +0000)]

Prevent NPE in unit tests as a result of r1067718

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071556 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 16 Feb 2011 17:56:03 +0000 (17:56 +0000)]

Prep for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071329 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 16 Feb 2011 17:35:24 +0000 (17:35 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50793
Correctly fire request init/destroy events for astnc requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071321 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 16 Feb 2011 14:18:12 +0000 (14:18 +0000)]

Move test outside the loop

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071262 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 16 Feb 2011 13:43:39 +0000 (13:43 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50713
Remove roles command from Manager application

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071243 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 15 Feb 2011 17:00:05 +0000 (17:00 +0000)]

Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070967 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 14 Feb 2011 19:05:25 +0000 (19:05 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50700
Ensure that the override attribute of context parameters is correctly followed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070609 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 14 Feb 2011 09:53:24 +0000 (09:53 +0000)]

Correctly test for no attributes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070420 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kfujino [Mon, 14 Feb 2011 08:47:49 +0000 (08:47 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50771
Ensure HttpServletRequest#getAuthType() returns the name of the authentication scheme
if request has already been authenticated.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070409 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kfujino [Mon, 14 Feb 2011 02:04:06 +0000 (02:04 +0000)]

Followup to r1069836
Remove unused managerClassName attribute from mbeans-descriptors.xml.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070365 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sat, 12 Feb 2011 19:35:26 +0000 (19:35 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50726
Ensure that the use of the genStringAsCharArray does not result in String constants that are too long for valid Java code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070139 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Fri, 11 Feb 2011 16:42:05 +0000 (16:42 +0000)]

doco and version update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069876 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

fhanik [Fri, 11 Feb 2011 16:32:41 +0000 (16:32 +0000)]

https://issues.apache.org/bugzilla/show_bug.cgi?id=50759
Update validation timestamp if using an external validator.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069864 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 11 Feb 2011 15:39:52 +0000 (15:39 +0000)]

Remove deprecated code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069844 13f79535-47bb-0310-9956-ffa450edef68