tomcat7.0
14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50855
markt [Sun, 6 Mar 2011 07:33:58 +0000 (07:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50855
Fix NPE on HttpServletRequest.logout() when debug logging is enabled.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078412 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix threading issue reported on dev list
markt [Sun, 6 Mar 2011 07:17:07 +0000 (07:17 +0000)]
Fix threading issue reported on dev list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078409 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrep for next release
markt [Sun, 6 Mar 2011 06:27:30 +0000 (06:27 +0000)]
Prep for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078404 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd missing entry.
markt [Sun, 6 Mar 2011 06:26:46 +0000 (06:26 +0000)]
Add missing entry.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078403 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCode clean-up
markt [Fri, 4 Mar 2011 16:49:14 +0000 (16:49 +0000)]
Code clean-up
 - fix FindBugs warnings
 - remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078049 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNow there is always an authenticator, need to allow for the extra MBean
markt [Fri, 4 Mar 2011 15:54:28 +0000 (15:54 +0000)]
Now there is always an authenticator, need to allow for the extra MBean

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078024 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCode clean-up
markt [Fri, 4 Mar 2011 15:52:01 +0000 (15:52 +0000)]
Code clean-up
 - fix FindBugs warnings
 - remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078022 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid npe
markt [Fri, 4 Mar 2011 15:31:04 +0000 (15:31 +0000)]
Avoid npe

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1078004 13f79535-47bb-0310-9956-ffa450edef68

14 years ago@ServletSecurity
markt [Fri, 4 Mar 2011 15:17:22 +0000 (15:17 +0000)]
@ServletSecurity
Servlets added via addServlet() should not be processed unless created via craeteServlet. Need to delay scanning until urlPatterns are known

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1077995 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCheck metadata-complete=true leads to @ServletSecurity being ignored
markt [Fri, 4 Mar 2011 11:23:43 +0000 (11:23 +0000)]
Check metadata-complete=true leads to @ServletSecurity being ignored

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1077883 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCheck web.xml takes precedence over @ServletSecurity
markt [Fri, 4 Mar 2011 11:17:06 +0000 (11:17 +0000)]
Check web.xml takes precedence over @ServletSecurity

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1077881 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd missing files and license header
fhanik [Thu, 3 Mar 2011 19:20:38 +0000 (19:20 +0000)]
Add missing files and license header
Add NOTICE/LICENSE to all JAR files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076736 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest that individual roles are correctly handled
markt [Thu, 3 Mar 2011 19:13:52 +0000 (19:13 +0000)]
Test that individual roles are correctly handled

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076731 13f79535-47bb-0310-9956-ffa450edef68

14 years ago@ServletSecurity
markt [Thu, 3 Mar 2011 12:56:07 +0000 (12:56 +0000)]
@ServletSecurity
Refactor to reduce duplication in test code
Add tests for method constraints

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076606 13f79535-47bb-0310-9956-ffa450edef68

14 years ago@ServletSecurity support
markt [Thu, 3 Mar 2011 11:31:56 +0000 (11:31 +0000)]
@ServletSecurity support
Add tests for subclasses

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076589 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo
markt [Thu, 3 Mar 2011 11:24:35 +0000 (11:24 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076587 13f79535-47bb-0310-9956-ffa450edef68

14 years ago[SECURITY]
markt [Thu, 3 Mar 2011 11:16:51 +0000 (11:16 +0000)]
[SECURITY]
Start of fix for issue reported on users list that @ServletSecurity annotations were ignored.
This fix is not yet complete. This first part:
- Triggers the loading of the Wrapper before the constraints are processed to ensure that any @ServletSecurity annotations are taken account of
- Makes sure the constraints collection is thread-safe given new usage
- Adds scanning for @ServletSecurity when a Servlet is loaded
- Ensure there is always an authenticator when using the embedded Tomcat class so that @ServletSecurity will have an effect
- Adds a simple unit test to check @ServletSecurity annotations are processed
Further commits will add additional test cases and any changes required for those test cases to pass

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076586 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDoco update
fhanik [Wed, 2 Mar 2011 21:18:18 +0000 (21:18 +0000)]
Doco update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076385 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50857
fhanik [Wed, 2 Mar 2011 21:15:07 +0000 (21:15 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50857
Timeouts have to be trapped, and properly handled

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076380 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSpeed up shut down when ThreadLocalLeakPreventionListener is enabled
markt [Wed, 2 Mar 2011 15:19:58 +0000 (15:19 +0000)]
Speed up shut down when ThreadLocalLeakPreventionListener is enabled

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076249 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Wed, 2 Mar 2011 13:55:19 +0000 (13:55 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076222 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Javadoc
markt [Wed, 2 Mar 2011 13:48:16 +0000 (13:48 +0000)]
Fix Javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076218 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988
markt [Wed, 2 Mar 2011 13:23:37 +0000 (13:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988
Improve reporting of missing files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076212 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate change log
markt [Wed, 2 Mar 2011 13:17:37 +0000 (13:17 +0000)]
Update change log

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076206 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBetter test for APR
markt [Wed, 2 Mar 2011 12:42:34 +0000 (12:42 +0000)]
Better test for APR

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076197 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect issues in the SSL renegotiation tests
markt [Wed, 2 Mar 2011 12:03:05 +0000 (12:03 +0000)]
Correct issues in the SSL renegotiation tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076182 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSave a few cycles
markt [Wed, 2 Mar 2011 11:43:06 +0000 (11:43 +0000)]
Save a few cycles

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076178 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
kkolinko [Tue, 1 Mar 2011 23:59:36 +0000 (23:59 +0000)]
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
1) Be more strict when ignoring the warning:
ignore only when it is the "lib" directory and when it does not exist
2) Warn about JARs created from expanding the GLOB pattern as well
3) s/new File(f.getCanonicalPath())/f.getCanonicalFile()/ for efficiency

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076059 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect several typos
kkolinko [Tue, 1 Mar 2011 23:24:33 +0000 (23:24 +0000)]
Correct several typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076047 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake sure we also validate the content that is sent and received
fhanik [Tue, 1 Mar 2011 20:34:00 +0000 (20:34 +0000)]
Make sure we also validate the content that is sent and received

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076015 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImplement renegotiation for SSL cert authentication
fhanik [Tue, 1 Mar 2011 20:04:26 +0000 (20:04 +0000)]
Implement renegotiation for SSL cert authentication

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076008 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrectly determine if a buffer has data or not
fhanik [Tue, 1 Mar 2011 19:58:55 +0000 (19:58 +0000)]
Correctly determine if a buffer has data or not

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1076004 13f79535-47bb-0310-9956-ffa450edef68

14 years agopropagate all exceptions through IOExceptions
fhanik [Tue, 1 Mar 2011 18:24:03 +0000 (18:24 +0000)]
propagate all exceptions through IOExceptions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075964 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSimple implementation of a forced and blocking renegotiation with a SSL client
fhanik [Tue, 1 Mar 2011 18:13:38 +0000 (18:13 +0000)]
Simple implementation of a forced and blocking renegotiation with a SSL client

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075956 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove outside of loop as per kkolinko's review
markt [Tue, 1 Mar 2011 14:13:16 +0000 (14:13 +0000)]
Move outside of loop as per kkolinko's review

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075823 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMissed a keystore in the refactoring
markt [Tue, 1 Mar 2011 13:35:24 +0000 (13:35 +0000)]
Missed a keystore in the refactoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075816 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix bug in unit test due to some Lifecycle refactoring
markt [Tue, 1 Mar 2011 13:24:31 +0000 (13:24 +0000)]
Fix bug in unit test due to some Lifecycle refactoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075811 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove handling of SSL renegotiation by failing earlier when the request body contai...
markt [Tue, 1 Mar 2011 12:32:25 +0000 (12:32 +0000)]
Improve handling of SSL renegotiation by failing earlier when the request body contains more bytes than maxSavePostSize.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075792 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove the init from references to handshake since the same fields/methods will be...
markt [Tue, 1 Mar 2011 11:12:22 +0000 (11:12 +0000)]
Remove the init from references to handshake since the same fields/methods will be used for renegotiation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075776 13f79535-47bb-0310-9956-ffa450edef68

14 years agoExtract the client-cert tests into a separate test
markt [Tue, 1 Mar 2011 10:16:36 +0000 (10:16 +0000)]
Extract the client-cert tests into a separate test
Check maxPostSize works as expected with client-cert

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075762 13f79535-47bb-0310-9956-ffa450edef68

14 years agoClear remainder of current FindBugs issues in unit tests
markt [Tue, 1 Mar 2011 09:33:57 +0000 (09:33 +0000)]
Clear remainder of current FindBugs issues in unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075742 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMore entries
markt [Tue, 1 Mar 2011 09:13:18 +0000 (09:13 +0000)]
More entries

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075737 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Tue, 1 Mar 2011 09:12:51 +0000 (09:12 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075736 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Findbugs nag
markt [Tue, 1 Mar 2011 09:02:52 +0000 (09:02 +0000)]
Fix Findbugs nag
Reduce visibility

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075725 13f79535-47bb-0310-9956-ffa450edef68

14 years agoGrr. This worked if 20 bytes were read in one go
markt [Tue, 1 Mar 2011 09:01:30 +0000 (09:01 +0000)]
Grr. This worked if 20 bytes were read in one go

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075724 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBetter fix, we actually need to read 20 byres for the test to pass
markt [Tue, 1 Mar 2011 09:00:01 +0000 (09:00 +0000)]
Better fix, we actually need to read 20 byres for the test to pass

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075719 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix FindBugs warning
markt [Tue, 1 Mar 2011 08:56:48 +0000 (08:56 +0000)]
Fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075718 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMore explicit failure message - fixed FindBugs nags
markt [Tue, 1 Mar 2011 08:50:40 +0000 (08:50 +0000)]
More explicit failure message - fixed FindBugs nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075713 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFindBugs fixes - make constants static
markt [Tue, 1 Mar 2011 08:44:29 +0000 (08:44 +0000)]
FindBugs fixes - make constants static

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075708 13f79535-47bb-0310-9956-ffa450edef68

14 years agoComment tweaks
markt [Tue, 1 Mar 2011 08:36:57 +0000 (08:36 +0000)]
Comment tweaks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075699 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert SSL renegotiation for NIO - implementation is broken
markt [Tue, 1 Mar 2011 01:23:31 +0000 (01:23 +0000)]
Revert SSL renegotiation for NIO - implementation is broken
Reverts r1074675 and r1075030

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075606 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStart of an SSL re-negotiation test. Need to expand it to handle request bodies and...
markt [Tue, 1 Mar 2011 01:15:11 +0000 (01:15 +0000)]
Start of an SSL re-negotiation test. Need to expand it to handle request bodies and the other issues highlighted by Filip.
Switch to using a CA since it makes the code cleaner and it is easier to get CLIENT-CERT working than will all self-signed certs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075604 13f79535-47bb-0310-9956-ffa450edef68

14 years agoShould have moved the keys when I moved the SSL tests
markt [Mon, 28 Feb 2011 19:03:31 +0000 (19:03 +0000)]
Should have moved the keys when I moved the SSL tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075487 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix an Eclipse nag
markt [Mon, 28 Feb 2011 18:43:44 +0000 (18:43 +0000)]
Fix an Eclipse nag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075474 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
markt [Mon, 28 Feb 2011 18:15:48 +0000 (18:15 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
Add URL encoding where missing to parameters in URLs presented by Ant tasks to the Manager application.
Based on a patch by Stephane Bailliez.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075458 13f79535-47bb-0310-9956-ffa450edef68

14 years agoClarify auth process for CLIENT-CERT
markt [Mon, 28 Feb 2011 17:24:00 +0000 (17:24 +0000)]
Clarify auth process for CLIENT-CERT

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075435 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrep for next release
markt [Mon, 28 Feb 2011 14:14:41 +0000 (14:14 +0000)]
Prep for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075338 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
markt [Mon, 28 Feb 2011 13:35:41 +0000 (13:35 +0000)]
Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
- consistently pass absolute paths to validateFile()
- handle non-absolute catalina home/base

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075320 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Sun, 27 Feb 2011 23:08:45 +0000 (23:08 +0000)]
Fix Eclipse warnings
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075176 13f79535-47bb-0310-9956-ffa450edef68

14 years agoClear remaining FindBugs issues from javax.*
markt [Sun, 27 Feb 2011 22:59:10 +0000 (22:59 +0000)]
Clear remaining FindBugs issues from javax.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075175 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMisc clean-up
markt [Sun, 27 Feb 2011 15:53:45 +0000 (15:53 +0000)]
Misc clean-up
- remove unused code
- suppress FindBugs false positives
- add javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075083 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAnother false positive
markt [Sun, 27 Feb 2011 14:34:19 +0000 (14:34 +0000)]
Another false positive

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075063 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCouple more false positives
markt [Sun, 27 Feb 2011 14:31:27 +0000 (14:31 +0000)]
Couple more false positives

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075062 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMisc clean-up
markt [Sun, 27 Feb 2011 14:29:07 +0000 (14:29 +0000)]
Misc clean-up
 - Suppress Eclipse warnings
 - Remove unused code
 - Correct Javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075061 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Sun, 27 Feb 2011 14:26:55 +0000 (14:26 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075060 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert r1075050
markt [Sun, 27 Feb 2011 14:12:39 +0000 (14:12 +0000)]
Revert r1075050

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075058 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=31027
markt [Sun, 27 Feb 2011 13:19:22 +0000 (13:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31027
Trim whitespace from names and values obtained from $CATALINA_BASE/conf/catalina.properties to avoid hard to diagnose errors on startup.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075050 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBlock whilst waiting for data from client in NIO SSL-rehandshake rather than spinning...
markt [Sun, 27 Feb 2011 11:28:01 +0000 (11:28 +0000)]
Block whilst waiting for data from client in NIO SSL-rehandshake rather than spinning the CPU

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075030 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
markt [Sun, 27 Feb 2011 11:00:12 +0000 (11:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
Better documentation of the meaning of Lifecycle.isAvailable() and correct a couple of cases where this could incorrectly return true.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075022 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAnother false positive
markt [Sun, 27 Feb 2011 10:31:49 +0000 (10:31 +0000)]
Another false positive

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1075019 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix FindBugs identified error in Servlet 2.2 jspFile handling
markt [Sat, 26 Feb 2011 20:44:34 +0000 (20:44 +0000)]
Fix FindBugs identified error in Servlet 2.2 jspFile handling

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074919 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix what looks like a copy/paste error
markt [Sat, 26 Feb 2011 20:40:25 +0000 (20:40 +0000)]
Fix what looks like a copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074918 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNo need to call stop if the app didn't start
markt [Sat, 26 Feb 2011 20:07:00 +0000 (20:07 +0000)]
No need to call stop if the app didn't start

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074915 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnsure a web application is taken out of service if the web.xml file is not valid.
markt [Sat, 26 Feb 2011 20:01:10 +0000 (20:01 +0000)]
Ensure a web application is taken out of service if the web.xml file is not valid.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074914 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix FindBugs warning
markt [Sat, 26 Feb 2011 19:37:13 +0000 (19:37 +0000)]
Fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074911 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49284
markt [Fri, 25 Feb 2011 19:19:13 +0000 (19:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49284
Support SSL re-negotiation in the HTTP NIO connector
There is a fair amount of renaming in this patch. The real work is in the new rehandshake() method in the SecureNioChannel.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074675 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid NPEs trying to re-negotiate with NIO
markt [Fri, 25 Feb 2011 15:58:08 +0000 (15:58 +0000)]
Avoid NPEs trying to re-negotiate with NIO

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074597 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50826
markt [Thu, 24 Feb 2011 17:25:38 +0000 (17:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50826
Avoid IAE when Tomcat instance is destroyed without every being started.
Add a test case for this.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074225 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDon't start NamingResources multiple times
markt [Thu, 24 Feb 2011 17:03:27 +0000 (17:03 +0000)]
Don't start NamingResources multiple times

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074215 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd documentation for the Crawler Session Manager Valve.
markt [Thu, 24 Feb 2011 16:01:38 +0000 (16:01 +0000)]
Add documentation for the Crawler Session Manager Valve.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074192 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix comment typo
markt [Thu, 24 Feb 2011 14:39:39 +0000 (14:39 +0000)]
Fix comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074168 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid NPE if no u-a header
markt [Thu, 24 Feb 2011 14:15:34 +0000 (14:15 +0000)]
Avoid NPE if no u-a header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074159 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRestore the CrawlerSessionManagerValve
markt [Thu, 24 Feb 2011 13:11:17 +0000 (13:11 +0000)]
Restore the CrawlerSessionManagerValve
Local testing with Jira 4.2.4 shows it works.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1074132 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd security listener
markt [Wed, 23 Feb 2011 19:25:17 +0000 (19:25 +0000)]
Add security listener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073893 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd the SecurityListener (disabled by default) that prevents Tomcat from starting...
markt [Wed, 23 Feb 2011 19:23:59 +0000 (19:23 +0000)]
Add the SecurityListener (disabled by default) that prevents Tomcat from starting if configured insecurely.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073891 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBetter handling in acceptor threads if server hits ulimit for open files
markt [Wed, 23 Feb 2011 11:58:47 +0000 (11:58 +0000)]
Better handling in acceptor threads if server hits ulimit for open files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073711 13f79535-47bb-0310-9956-ffa450edef68

14 years agodoco update bug 50805
fhanik [Tue, 22 Feb 2011 22:45:43 +0000 (22:45 +0000)]
doco update bug 50805

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073532 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50805
fhanik [Tue, 22 Feb 2011 22:42:44 +0000 (22:42 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50805
Make sure we only call borrowConnection once per connection per checkout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073531 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest before generating debug log messages
markt [Tue, 22 Feb 2011 16:38:39 +0000 (16:38 +0000)]
Test before generating debug log messages
Fix FindBugs issues for File.delete() return value

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073393 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code, fix FindBugs warning
markt [Tue, 22 Feb 2011 12:55:56 +0000 (12:55 +0000)]
Remove unused code, fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073320 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=21669
markt [Tue, 22 Feb 2011 11:48:09 +0000 (11:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=21669
Add the ability to specify the roleBase for the JNDI Realm as relative to the users DN. Based on a patch by Art W.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073301 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=19444
markt [Tue, 22 Feb 2011 11:08:42 +0000 (11:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=19444
Add an option to the JNDI realm to allow role searches to be performed by the authenticated user.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073296 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRefactoring to remove duplicate code
markt [Tue, 22 Feb 2011 10:46:02 +0000 (10:46 +0000)]
Refactoring to remove duplicate code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073289 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConvert to Javadoc comment and add some additional info
markt [Mon, 21 Feb 2011 23:21:09 +0000 (23:21 +0000)]
Convert to Javadoc comment and add some additional info

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073184 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSmarter solution for bug 48863
markt [Mon, 21 Feb 2011 16:23:05 +0000 (16:23 +0000)]
Smarter solution for bug 48863

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1073047 13f79535-47bb-0310-9956-ffa450edef68

14 years agoServletapi-2.3 appears to have disappeared from the maven1 repo.
markt [Mon, 21 Feb 2011 13:15:53 +0000 (13:15 +0000)]
Servletapi-2.3 appears to have disappeared from the maven1 repo.
Switch everything to maven2 repo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072962 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix javadoc
markt [Mon, 21 Feb 2011 12:59:50 +0000 (12:59 +0000)]
Fix javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072960 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix indentation
markt [Fri, 18 Feb 2011 21:45:49 +0000 (21:45 +0000)]
Fix indentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072161 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
markt [Fri, 18 Feb 2011 21:44:13 +0000 (21:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48870
Re-factor to remove parallel arrays.
Modify fix for 48863 to remove use of StringManager as it is not available in Bootstrap

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072160 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
markt [Fri, 18 Feb 2011 20:58:16 +0000 (20:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
Better logging when specifying an invalid directory for a class loader.
Based on a patch by Ralf Hauser.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072145 13f79535-47bb-0310-9956-ffa450edef68