horde.git
15 years agoFix saving all-day events.
Jan Schneider [Fri, 12 Feb 2010 17:47:21 +0000 (18:47 +0100)]
Fix saving all-day events.

15 years agoSimplify selectors.
Jan Schneider [Fri, 12 Feb 2010 17:37:58 +0000 (18:37 +0100)]
Simplify selectors.

15 years agoFix error with IE and prototype.
Jan Schneider [Fri, 12 Feb 2010 17:35:49 +0000 (18:35 +0100)]
Fix error with IE and prototype.

15 years agoAdd close button to growler logs too.
Jan Schneider [Fri, 12 Feb 2010 15:39:18 +0000 (16:39 +0100)]
Add close button to growler logs too.

15 years agoStyle
Jan Schneider [Fri, 12 Feb 2010 15:21:44 +0000 (16:21 +0100)]
Style

15 years agoReturn the current log status again.
Jan Schneider [Fri, 12 Feb 2010 15:00:49 +0000 (16:00 +0100)]
Return the current log status again.

15 years agoAlways show close button.
Jan Schneider [Fri, 12 Feb 2010 14:50:31 +0000 (15:50 +0100)]
Always show close button.

15 years agoOnly show map link if the is a location.
Jan Schneider [Fri, 12 Feb 2010 14:33:00 +0000 (15:33 +0100)]
Only show map link if the is a location.
Tweak edit form.

15 years agoCreate all-day event when clicking in the all-day row.
Jan Schneider [Fri, 12 Feb 2010 14:07:46 +0000 (15:07 +0100)]
Create all-day event when clicking in the all-day row.

15 years agoAlways and consitently reset edit forms before deciding whether to load date
Jan Schneider [Fri, 12 Feb 2010 13:32:50 +0000 (14:32 +0100)]
Always and consitently reset edit forms before deciding whether to load date
into them.

15 years agoShow due date, even if the task isn't due yet.
Jan Schneider [Fri, 12 Feb 2010 13:20:07 +0000 (14:20 +0100)]
Show due date, even if the task isn't due yet.

15 years agoReset due date and time when loading tasks.
Jan Schneider [Fri, 12 Feb 2010 13:08:54 +0000 (14:08 +0100)]
Reset due date and time when loading tasks.

15 years agoFix parse error.
Jan Schneider [Fri, 12 Feb 2010 12:58:20 +0000 (13:58 +0100)]
Fix parse error.

15 years agoReplace is_a() calls.
Jan Schneider [Fri, 12 Feb 2010 12:21:37 +0000 (13:21 +0100)]
Replace is_a() calls.
Fade out PEAR_Error.

15 years agoUse Horde_Exception_NotFound.
Jan Schneider [Fri, 12 Feb 2010 12:04:18 +0000 (13:04 +0100)]
Use Horde_Exception_NotFound.

15 years agoFix saving due dates.
Jan Schneider [Fri, 12 Feb 2010 11:03:44 +0000 (12:03 +0100)]
Fix saving due dates.

15 years agogetEvent() doesn't return PEAR_Errors anymore.
Jan Schneider [Fri, 12 Feb 2010 10:56:18 +0000 (11:56 +0100)]
getEvent() doesn't return PEAR_Errors anymore.

15 years agoRe-enable inactive task forms.
Jan Schneider [Fri, 12 Feb 2010 10:49:56 +0000 (11:49 +0100)]
Re-enable inactive task forms.
Create task cache when adding a first task.
Show "no items" initially when no tasks exist from the start.
Catch edge case when to-be-deleted tasks don't exist anymore.

15 years agoSort
Jan Schneider [Fri, 12 Feb 2010 10:38:16 +0000 (11:38 +0100)]
Sort

15 years agoDon't react on clicks and mouseovers of the 'no items' row.
Jan Schneider [Fri, 12 Feb 2010 10:34:46 +0000 (11:34 +0100)]
Don't react on clicks and mouseovers of the 'no items' row.

15 years agoWe don't need a custom notification handler for Kronolith anymore.
Jan Schneider [Fri, 12 Feb 2010 10:33:16 +0000 (11:33 +0100)]
We don't need a custom notification handler for Kronolith anymore.

15 years agoFix scope.
Jan Schneider [Thu, 11 Feb 2010 22:09:50 +0000 (23:09 +0100)]
Fix scope.

15 years agoBug #8867: refactor Horde::getServiceLink() for general use, not just menu-related use
Michael M Slusarz [Thu, 11 Feb 2010 21:16:06 +0000 (14:16 -0700)]
Bug #8867: refactor Horde::getServiceLink() for general use, not just menu-related use

15 years agoUse Horde_Injector to instantiate Horde_Perms
Michael M Slusarz [Thu, 11 Feb 2010 20:56:29 +0000 (13:56 -0700)]
Use Horde_Injector to instantiate Horde_Perms

Resource savings - many pages don't need permissions checking, so only
create Perms object if needed.

15 years agoHorde_Perms now created with Horde_Injector
Michael M Slusarz [Thu, 11 Feb 2010 19:58:14 +0000 (12:58 -0700)]
Horde_Perms now created with Horde_Injector

15 years agoRemove Horde_Cli::singleton().
Michael M Slusarz [Thu, 11 Feb 2010 19:50:38 +0000 (12:50 -0700)]
Remove Horde_Cli::singleton().

If calling appInit() with 'cli' parameter set to true, the global
variable $cli will contain the Horde_Cli instance.

15 years agoUse global notification object
Michael M Slusarz [Thu, 11 Feb 2010 19:35:23 +0000 (12:35 -0700)]
Use global notification object

15 years agoAlways utilize global Horde_Browser object
Michael M Slusarz [Thu, 11 Feb 2010 19:20:20 +0000 (12:20 -0700)]
Always utilize global Horde_Browser object

15 years agoCheck that the file exists and has contents when uploading
Michael M Slusarz [Thu, 11 Feb 2010 19:14:36 +0000 (12:14 -0700)]
Check that the file exists and has contents when uploading

15 years agoHorde_Script_Files fixes/improvements
Michael M Slusarz [Thu, 11 Feb 2010 19:01:01 +0000 (12:01 -0700)]
Horde_Script_Files fixes/improvements

Don't use private methods (not sure how this was working anymore)
Use injector to hold singleton object

15 years agoFix duplicate output of javascript files
Michael M Slusarz [Thu, 11 Feb 2010 18:54:53 +0000 (11:54 -0700)]
Fix duplicate output of javascript files

15 years agoTypos
Michael J. Rubinsky [Thu, 11 Feb 2010 19:31:04 +0000 (14:31 -0500)]
Typos
Sumbmitted By: rsalmon (at) mbpgroup (dot) com

15 years agoThis is an int, not null. Was breaking all sorts of stuff
Michael M Slusarz [Thu, 11 Feb 2010 18:02:56 +0000 (11:02 -0700)]
This is an int, not null. Was breaking all sorts of stuff

15 years agoDon't overwrite .kronolithToday in year view.
Jan Schneider [Thu, 11 Feb 2010 17:53:55 +0000 (18:53 +0100)]
Don't overwrite .kronolithToday in year view.

15 years agoFloats casted to strings are locale dependant. Use sprintf() with %F instead.
Jan Schneider [Thu, 11 Feb 2010 17:50:49 +0000 (18:50 +0100)]
Floats casted to strings are locale dependant. Use sprintf() with %F instead.

15 years agoRequest #6232: Show alarm notifications in DIMP.
Michael M Slusarz [Thu, 11 Feb 2010 17:47:20 +0000 (10:47 -0700)]
Request #6232: Show alarm notifications in DIMP.

15 years agoFix error notification.
Michael M Slusarz [Thu, 11 Feb 2010 17:41:23 +0000 (10:41 -0700)]
Fix error notification.

15 years ago'driver' can be null but Horde_Alarm will use default sql values.
Michael M Slusarz [Thu, 11 Feb 2010 17:36:01 +0000 (10:36 -0700)]
'driver' can be null but Horde_Alarm will use default sql values.

15 years agoCS
Gunnar Wrobel [Thu, 11 Feb 2010 14:31:06 +0000 (15:31 +0100)]
CS

15 years agoUpdate the Injector package.xml using the Packaging script.
Gunnar Wrobel [Thu, 11 Feb 2010 14:01:44 +0000 (15:01 +0100)]
Update the Injector package.xml using the Packaging script.

15 years agoComplete coverage.
Gunnar Wrobel [Thu, 11 Feb 2010 13:57:52 +0000 (14:57 +0100)]
Complete coverage.

15 years agoComplete coverage.
Gunnar Wrobel [Thu, 11 Feb 2010 13:52:26 +0000 (14:52 +0100)]
Complete coverage.

15 years agoOmit warning during autoloading when an included file does not exist.
Gunnar Wrobel [Thu, 11 Feb 2010 13:48:13 +0000 (14:48 +0100)]
Omit warning during autoloading when an included file does not exist.

Otherwise some test may fail under strict conditions since
class_exists() and new ReflectionClass() suddenly emit a warning for
non-existant classes. See tests in Horde_Injector that test for
reactions on specifying non existing Instances.

15 years agoUpdate the package.xml using the Packaging script.
Gunnar Wrobel [Thu, 11 Feb 2010 12:15:51 +0000 (13:15 +0100)]
Update the package.xml using the Packaging script.

15 years agoTypo
Gunnar Wrobel [Thu, 11 Feb 2010 11:32:09 +0000 (12:32 +0100)]
Typo

15 years agoComplete exception testing.
Gunnar Wrobel [Thu, 11 Feb 2010 11:11:48 +0000 (12:11 +0100)]
Complete exception testing.

15 years agoSupport previous exceptions in PHP < 5.3.0.
Gunnar Wrobel [Thu, 11 Feb 2010 10:56:27 +0000 (11:56 +0100)]
Support previous exceptions in PHP < 5.3.0.

Taken from http://framework.zend.com/wiki/display/ZFPROP/previous+Exception+on+Zend_Exception+-+Marc+Bennewitz

15 years agoFix tests.
Jan Schneider [Thu, 11 Feb 2010 10:50:19 +0000 (11:50 +0100)]
Fix tests.

15 years agoExtract PEAR and exception handling into a separate class.
Gunnar Wrobel [Thu, 11 Feb 2010 10:07:15 +0000 (11:07 +0100)]
Extract PEAR and exception handling into a separate class.

Again we always know when we throw a PEAR Error or an exception at
Horde_Exception. It is not necessary to have the class trying to
determine what the arguments might have been.

15 years agoDo not convert incorrect code types to integer automatically.
Gunnar Wrobel [Thu, 11 Feb 2010 08:29:43 +0000 (09:29 +0100)]
Do not convert incorrect code types to integer automatically.

If $code is null it will be converted to 0 by the default Exception
anyhow.

If $code contains a string it will elicit a Fatal Error. But that is
okay and should not be hidden. In nearly all cases where we provided a
string as $code it was a simple coding error that needs to be fixed.

There may be cases where the code is a value returned from another
library. If it is uncertain that the library ensures that the return
value is an integer then it can be cast into an integer before
providing it to the exception.

15 years agoExtract the error_get_last() handling into a separate Exception class.
Gunnar Wrobel [Thu, 11 Feb 2010 08:09:59 +0000 (09:09 +0100)]
Extract the error_get_last() handling into a separate Exception class.

In all cases (Horde_Feed, Horde_Xml_Element, Horde_Yaml, and Horde_Http) where
we throw the result from error_get_last() into the exception class we know
exactly that we are doing so.

Rather than having the Exception class trying to determine what kind of
parameters it might have received we can use a separate class for that.

15 years agoUse Horde_Exception_PermissionDenied.
Jan Schneider [Thu, 11 Feb 2010 09:51:45 +0000 (10:51 +0100)]
Use Horde_Exception_PermissionDenied.

15 years agoFix dragging in the month view.
Jan Schneider [Wed, 10 Feb 2010 23:42:17 +0000 (00:42 +0100)]
Fix dragging in the month view.

15 years agoDon't wrap HTML->Text reply data
Michael M Slusarz [Wed, 10 Feb 2010 20:21:22 +0000 (13:21 -0700)]
Don't wrap HTML->Text reply data

15 years agoMove filter interface into Horde_Text_Filter_Base class.
Michael M Slusarz [Wed, 10 Feb 2010 20:20:32 +0000 (13:20 -0700)]
Move filter interface into Horde_Text_Filter_Base class.

15 years agoTweaks to reply quote styling
Michael M Slusarz [Wed, 10 Feb 2010 19:54:45 +0000 (12:54 -0700)]
Tweaks to reply quote styling

15 years agoImprovements to the Html2Text filter.
Michael M Slusarz [Wed, 10 Feb 2010 19:20:03 +0000 (12:20 -0700)]
Improvements to the Html2Text filter.

15 years agoAdd ability to define filters to use with preg_replace_callback().
Michael M Slusarz [Wed, 10 Feb 2010 18:59:58 +0000 (11:59 -0700)]
Add ability to define filters to use with preg_replace_callback().

15 years agoFix undefined error warning.
Michael M Slusarz [Wed, 10 Feb 2010 18:49:27 +0000 (11:49 -0700)]
Fix undefined error warning.

15 years agoThis can all be done in one call in PHP 4.3.0+
Michael M Slusarz [Wed, 10 Feb 2010 18:14:22 +0000 (11:14 -0700)]
This can all be done in one call in PHP 4.3.0+

15 years agoMove from main() to init() in the AllTests.php files.
Gunnar Wrobel [Thu, 11 Feb 2010 07:59:57 +0000 (08:59 +0100)]
Move from main() to init() in the AllTests.php files.

15 years agoFix adding events via the API.
Michael J. Rubinsky [Wed, 10 Feb 2010 21:06:29 +0000 (16:06 -0500)]
Fix adding events via the API.

Sneaky little bug. Can't catch a Kronolith_Exception here, since
Kronolith_Driver#getByUID can also throw a Horde_Exception_NotFound now too.

15 years agoFix variable name
Michael J. Rubinsky [Wed, 10 Feb 2010 19:37:54 +0000 (14:37 -0500)]
Fix variable name

15 years agospelling
Michael J. Rubinsky [Wed, 10 Feb 2010 19:14:56 +0000 (14:14 -0500)]
spelling

15 years agocast the lat/lon values to floats since we evidently can't use DB's placeholders
Michael J. Rubinsky [Wed, 10 Feb 2010 19:11:26 +0000 (14:11 -0500)]
cast the lat/lon values to floats since we evidently can't use DB's placeholders

15 years agouse placeholders where possible, can't use them in the POINT() spatial function, as
Michael J. Rubinsky [Wed, 10 Feb 2010 18:57:18 +0000 (13:57 -0500)]
use placeholders where possible, can't use them in the POINT() spatial function, as
this seems to break the query.

15 years agotypos, fix variable names
Michael J. Rubinsky [Wed, 10 Feb 2010 18:56:39 +0000 (13:56 -0500)]
typos, fix variable names

15 years agoUse exceptions and a bit other H4 stuff along the way.
Jan Schneider [Wed, 10 Feb 2010 18:28:36 +0000 (19:28 +0100)]
Use exceptions and a bit other H4 stuff along the way.

15 years agofix variable name
Michael J. Rubinsky [Wed, 10 Feb 2010 18:22:58 +0000 (13:22 -0500)]
fix variable name

15 years agoFix display of duplicate attachments
Michael M Slusarz [Wed, 10 Feb 2010 18:00:17 +0000 (11:00 -0700)]
Fix display of duplicate attachments

15 years agoDon't display PGP armored text data as separate part.
Michael M Slusarz [Wed, 10 Feb 2010 17:58:00 +0000 (10:58 -0700)]
Don't display PGP armored text data as separate part.

15 years agoDon't display S/MIME signature data inline.
Michael M Slusarz [Wed, 10 Feb 2010 17:36:44 +0000 (10:36 -0700)]
Don't display S/MIME signature data inline.

15 years agoUse placeholders instead of interpolation - and fix logic in setLocation()
Michael J. Rubinsky [Wed, 10 Feb 2010 17:13:16 +0000 (12:13 -0500)]
Use placeholders instead of interpolation - and fix logic in setLocation()

15 years agoMark tests as skipped if the sqlite extension is not available.
Gunnar Wrobel [Wed, 10 Feb 2010 16:53:41 +0000 (17:53 +0100)]
Mark tests as skipped if the sqlite extension is not available.

15 years agoUse the main method from the parent class to avoid strict warnings.
Gunnar Wrobel [Wed, 10 Feb 2010 16:45:19 +0000 (17:45 +0100)]
Use the main method from the parent class to avoid strict warnings.

15 years agoEnsure we dont include the AllTests.php from the Test package.
Gunnar Wrobel [Wed, 10 Feb 2010 16:37:35 +0000 (17:37 +0100)]
Ensure we dont include the AllTests.php from the Test package.

15 years agoMake test_framework run again.
Gunnar Wrobel [Wed, 10 Feb 2010 16:35:44 +0000 (17:35 +0100)]
Make test_framework run again.

Disabled some Kolab tests from H3 that were not yet ported to H4.
Removed the init() call. Either all AllTests.php use this or none.

Without the init() call in the AllTests.php the suite() yields no test cases
so the only tests being run are currently from the Db package.

15 years agoRemove unused rename() method.
Jan Schneider [Wed, 10 Feb 2010 16:31:25 +0000 (17:31 +0100)]
Remove unused rename() method.

15 years agoRemove redundant method.
Jan Schneider [Tue, 9 Feb 2010 23:31:12 +0000 (00:31 +0100)]
Remove redundant method.

15 years agoAdd Horde_Exception_NotFound.
Jan Schneider [Tue, 9 Feb 2010 17:53:20 +0000 (18:53 +0100)]
Add Horde_Exception_NotFound.

15 years agoSet default exception message.
Jan Schneider [Tue, 9 Feb 2010 11:52:07 +0000 (12:52 +0100)]
Set default exception message.

15 years agoAdd Horde_Exception_PermissionDenied.
Jan Schneider [Tue, 9 Feb 2010 11:46:44 +0000 (12:46 +0100)]
Add Horde_Exception_PermissionDenied.

15 years agoUpdate history in base class.
Jan Schneider [Tue, 9 Feb 2010 11:27:36 +0000 (12:27 +0100)]
Update history in base class.

15 years agoCorrect the error message and keep the command line information.
Gunnar Wrobel [Wed, 10 Feb 2010 15:11:10 +0000 (16:11 +0100)]
Correct the error message and keep the command line information.

The command line was originally reported as user information on a PEAR Error object. During the
import to git the PEAR Error was exchanged with an exception and the command line provided as
the second argument to the exception. As strings in this position get reset the information will
be lost. I assume that concatenating the command line to the error might actually be what was
desired.

15 years agoReadd sprintf() that got lost with the import to git.
Gunnar Wrobel [Wed, 10 Feb 2010 15:03:56 +0000 (16:03 +0100)]
Readd sprintf() that got lost with the import to git.

15 years agoFix typo that crept in with commit cdc9a1b.
Gunnar Wrobel [Wed, 10 Feb 2010 14:58:47 +0000 (15:58 +0100)]
Fix typo that crept in with commit cdc9a1b.

15 years agoRemove second exception parameter if it is a string.
Gunnar Wrobel [Wed, 10 Feb 2010 14:45:50 +0000 (15:45 +0100)]
Remove second exception parameter if it is a string.

Having a string as  does not have any effect as it gets set to zero in the Exception constructor.

15 years agoAdd tests for the current exception class.
Gunnar Wrobel [Wed, 10 Feb 2010 10:49:17 +0000 (11:49 +0100)]
Add tests for the current exception class.

15 years agoAdd the possibility to initialize a test suite with a static init() method
Gunnar Wrobel [Wed, 10 Feb 2010 08:39:29 +0000 (09:39 +0100)]
Add the possibility to initialize a test suite with a static init() method
rather than using the main() method.

It is not sufficient to setup the static AllTests class via the main method.
This only allows to directly execute the AllTests.php file by parsing it
with php. Using phpunit is not possible as this will only use the suite()
method to grab the test suite.

It would still be better to use late static binding here but the added
method should be enough to allow running the tests in both ways.

The AllTests.php in Kolab_Session demonstrates how to use the init() method.

15 years agoFix Horde_Mime::isChild() for X.0 type MIME IDs
Michael M Slusarz [Wed, 10 Feb 2010 08:42:02 +0000 (01:42 -0700)]
Fix Horde_Mime::isChild() for X.0 type MIME IDs

15 years agoUse content-disposition filename to get/set name of part
Michael M Slusarz [Wed, 10 Feb 2010 08:15:05 +0000 (01:15 -0700)]
Use content-disposition filename to get/set name of part

15 years agoFix constant name.
Michael M Slusarz [Wed, 10 Feb 2010 08:12:02 +0000 (01:12 -0700)]
Fix constant name.

15 years agoFix display of certain attachments
Michael M Slusarz [Wed, 10 Feb 2010 07:58:39 +0000 (00:58 -0700)]
Fix display of certain attachments

15 years agoFix undefined error
Michael M Slusarz [Wed, 10 Feb 2010 07:58:16 +0000 (00:58 -0700)]
Fix undefined error

15 years agoMove contextmenu styles to horde
Michael M Slusarz [Wed, 10 Feb 2010 07:08:42 +0000 (00:08 -0700)]
Move contextmenu styles to horde

15 years agoClose submenu and trigger current element on click
Michael M Slusarz [Wed, 10 Feb 2010 06:59:37 +0000 (23:59 -0700)]
Close submenu and trigger current element on click

15 years agoModest improvements to the prefs UI templates
Michael M Slusarz [Wed, 10 Feb 2010 06:50:50 +0000 (23:50 -0700)]
Modest improvements to the prefs UI templates

15 years agoMake $app optional to Horde::getServiceLink().
Michael M Slusarz [Wed, 10 Feb 2010 06:50:17 +0000 (23:50 -0700)]
Make $app optional to Horde::getServiceLink().

15 years agoSet inferred attributes if using LIST-EXTENDED
Michael M Slusarz [Wed, 10 Feb 2010 06:07:31 +0000 (23:07 -0700)]
Set inferred attributes if using LIST-EXTENDED

15 years agoMake sure all special mailboxes are sent when rebuilding mailbox tree
Michael M Slusarz [Wed, 10 Feb 2010 05:59:13 +0000 (22:59 -0700)]
Make sure all special mailboxes are sent when rebuilding mailbox tree