Michael M Slusarz [Wed, 25 Aug 2010 04:41:27 +0000 (22:41 -0600)]
Revert "We expect an array back, so pass it an array."
This reverts commit
ab3d724ed9c4ef81741600076a87a66e891717cd.
We *do* get an array back when passing the variable name as a string,
and we avoid an unneeded compact() call. And, more important, this
broke display of every mime driver.
Jan Schneider [Tue, 24 Aug 2010 21:09:20 +0000 (23:09 +0200)]
Fix Horde_Menu now expecting Horde_Urls.
Jan Schneider [Tue, 24 Aug 2010 21:08:44 +0000 (23:08 +0200)]
We expect an array back, so pass it an array.
Jan Schneider [Tue, 24 Aug 2010 21:05:03 +0000 (23:05 +0200)]
Fix scope.
Jan Schneider [Tue, 24 Aug 2010 21:02:44 +0000 (23:02 +0200)]
Driver -> Base
Gunnar Wrobel [Tue, 24 Aug 2010 20:26:28 +0000 (22:26 +0200)]
Update package.xml.
Gunnar Wrobel [Tue, 24 Aug 2010 19:06:25 +0000 (21:06 +0200)]
Add a module for generating a development snapshot of a PEAR package.
The package will have the version number provided in package.xml but
appended with a timestamp (
201008242106).
Michael M Slusarz [Tue, 24 Aug 2010 18:34:57 +0000 (12:34 -0600)]
Bug #9011: Fix XSS
slusarz 2010-08-24 18:31:34 UTC
Modified files: (Branch: FRAMEWORK_3)
docs CHANGES
. view.php
Log:
Bug: 9191
Submitted by: nightmare.lmw@anarchynet.org
Fix CSS vulnerability when viewing file data.
Revision Changes Path
1.114.2.58 +2 -0 gollem/docs/CHANGES
1.51.2.7 +3 -5 gollem/view.php
Michael M Slusarz [Tue, 24 Aug 2010 18:21:18 +0000 (12:21 -0600)]
Rework compose attachment hook.
Rename from 'attachmimetype' to 'compose_attach', since more than just
MIME type determination can be done in the hook.
Add virus scanning example to hook.
Jan Schneider [Tue, 24 Aug 2010 16:13:54 +0000 (18:13 +0200)]
Improve changelog loader.
Jan Schneider [Tue, 24 Aug 2010 16:01:34 +0000 (18:01 +0200)]
Fix meaning.
Jan Schneider [Tue, 24 Aug 2010 15:55:36 +0000 (17:55 +0200)]
Fix ajax-loading of changelog.
Jan Schneider [Tue, 24 Aug 2010 15:46:51 +0000 (17:46 +0200)]
Fix HTML
Jan Schneider [Tue, 24 Aug 2010 15:36:00 +0000 (17:36 +0200)]
No colon.
Jan Schneider [Tue, 24 Aug 2010 15:23:45 +0000 (17:23 +0200)]
Fix variable.
Jan Schneider [Tue, 24 Aug 2010 14:47:53 +0000 (16:47 +0200)]
Make Horde_Vcs_File#logs public.
Jan Schneider [Tue, 24 Aug 2010 14:47:14 +0000 (16:47 +0200)]
Provide status in patchsets, don't parse trailing empty line.
Jan Schneider [Tue, 24 Aug 2010 14:04:01 +0000 (16:04 +0200)]
Exit early.
Jan Schneider [Tue, 24 Aug 2010 14:02:30 +0000 (16:02 +0200)]
Only link to cvsgraph.php if we actually have a CVS repo.
Jan Schneider [Tue, 24 Aug 2010 13:54:51 +0000 (15:54 +0200)]
Fix variable name.
Jan Schneider [Tue, 24 Aug 2010 13:52:55 +0000 (15:52 +0200)]
Add doctype header.
Jan Schneider [Tue, 24 Aug 2010 13:50:19 +0000 (15:50 +0200)]
Fix CSS.
Jan Schneider [Tue, 24 Aug 2010 13:48:52 +0000 (15:48 +0200)]
Fix image.
Jan Schneider [Tue, 24 Aug 2010 13:42:42 +0000 (15:42 +0200)]
Don't attach empty onb parameter.
Jan Schneider [Tue, 24 Aug 2010 13:32:48 +0000 (15:32 +0200)]
Use Horde_Url. Always include repository in URL.
Jan Schneider [Tue, 24 Aug 2010 13:09:17 +0000 (15:09 +0200)]
Assume we have a Horde_Url here. Fix encoding of service links.
Jan Schneider [Tue, 24 Aug 2010 12:53:05 +0000 (14:53 +0200)]
Fix passing onb parameter.
Jan Schneider [Mon, 23 Aug 2010 21:50:12 +0000 (23:50 +0200)]
Tweak comment.
Gunnar Wrobel [Tue, 24 Aug 2010 09:10:53 +0000 (11:10 +0200)]
Fix the CI build script. Why did this work before?
Gunnar Wrobel [Tue, 24 Aug 2010 08:07:50 +0000 (10:07 +0200)]
Add a fix to ignore the autoloading of the newer PHPUnit (>= 3.5.0, currently RC).
Also extracted the reduced Autoloading setup for the test suites. This
way I can avoid duplicating code when defining the Autoload.php setup
I use for running single test suites.
Michael M Slusarz [Tue, 24 Aug 2010 07:38:54 +0000 (01:38 -0600)]
Remove folder list caching.
Folder lists are cached in the IMP_Imap_Tree object. No need to cache
this information multiple times.
Michael M Slusarz [Tue, 24 Aug 2010 07:27:25 +0000 (01:27 -0600)]
Re-add saving expand/collapse state in IMP folders page
Michael M Slusarz [Tue, 24 Aug 2010 07:00:24 +0000 (01:00 -0600)]
Trigger events when expanding/collapsing tree elements.
Michael M Slusarz [Tue, 24 Aug 2010 05:58:20 +0000 (23:58 -0600)]
This value needs to be unique to all buffers, not just the current buffer
Michael M Slusarz [Wed, 18 Aug 2010 18:51:07 +0000 (12:51 -0600)]
Use Horde_Tree to render folder/search trees.
This isn't complete yet. TODO list:
1. Auto JSON loading of collapsed->expanded levels.
2. Save expanded/collapse information on folders page.
3. Use tree to render MIMP & Folder drop-down lists.
Michael M Slusarz [Tue, 17 Aug 2010 18:45:05 +0000 (12:45 -0600)]
Implement Iterator in IMP_Imap_Tree::.
Michael M Slusarz [Tue, 24 Aug 2010 05:25:39 +0000 (23:25 -0600)]
Use recursive calls, as it makes things clearer.
Michael M Slusarz [Mon, 23 Aug 2010 23:54:16 +0000 (17:54 -0600)]
Add 'lines_base' option
Michael M Slusarz [Mon, 23 Aug 2010 23:28:08 +0000 (17:28 -0600)]
Simplify getOption()
Michael M Slusarz [Mon, 23 Aug 2010 22:19:01 +0000 (16:19 -0600)]
Horde_Tree cleanups.
Don't hardcode float or other styles.
Use spans for internal elements.
Michael M Slusarz [Mon, 23 Aug 2010 22:00:35 +0000 (16:00 -0600)]
Move HTML-specific code out of base Tree class
Michael M Slusarz [Mon, 23 Aug 2010 22:00:25 +0000 (16:00 -0600)]
Make addNodeParams() driver-specific
Michael M Slusarz [Mon, 23 Aug 2010 21:05:06 +0000 (15:05 -0600)]
Fix static variable access.
Michael M Slusarz [Mon, 23 Aug 2010 20:56:13 +0000 (14:56 -0600)]
Move some more RTL code out of tree renderer
Michael M Slusarz [Mon, 23 Aug 2010 18:29:39 +0000 (12:29 -0600)]
More places to use Horde_Variables::
Gunnar Wrobel [Tue, 24 Aug 2010 05:33:47 +0000 (07:33 +0200)]
Replace Horde_Core_Autoloader with Horde_Autoloader_Default
Chuck Hagenbuch [Mon, 23 Aug 2010 19:30:27 +0000 (15:30 -0400)]
Finish converting Driver -> Base
Jan Schneider [Mon, 23 Aug 2010 16:13:21 +0000 (18:13 +0200)]
Only use language name for locales that don't require the country part.
Gunnar Wrobel [Mon, 23 Aug 2010 15:29:09 +0000 (17:29 +0200)]
Remove the Autoloader here and update the package.xml.
Gunnar Wrobel [Mon, 23 Aug 2010 15:26:52 +0000 (17:26 +0200)]
I don't see a reason to avoid providing the default autoloader within
Horde_Autoloader.
It introduces no additional dependencies and will be required by a any
application that does not derive from Horde_Core.
Jan Schneider [Mon, 23 Aug 2010 14:09:15 +0000 (16:09 +0200)]
Driver -> Transport
Jan Schneider [Mon, 23 Aug 2010 13:48:21 +0000 (15:48 +0200)]
Driver -> Base
Jan Schneider [Mon, 23 Aug 2010 13:24:41 +0000 (15:24 +0200)]
xdiff is a PECL package, not an extension (PEAR Bug 17782).
Jan Schneider [Mon, 23 Aug 2010 13:18:06 +0000 (15:18 +0200)]
Assign result.
Jan Schneider [Mon, 23 Aug 2010 13:07:41 +0000 (15:07 +0200)]
Check if unserialization failed.
Jan Schneider [Mon, 23 Aug 2010 12:57:33 +0000 (14:57 +0200)]
Set maximum height for duplicate list, to make scrolling easier.
Jan Schneider [Mon, 23 Aug 2010 12:54:43 +0000 (14:54 +0200)]
Fix rendering images in inactive forms.
Jan Schneider [Mon, 23 Aug 2010 12:52:06 +0000 (14:52 +0200)]
Fix Horde::img() call.
Jan Schneider [Mon, 23 Aug 2010 12:51:54 +0000 (14:51 +0200)]
Catch non-existant image even if using Horde_Themes_Image.
Jan Schneider [Mon, 23 Aug 2010 12:42:56 +0000 (14:42 +0200)]
Don't cache history entry from last contact.
Jan Schneider [Thu, 19 Aug 2010 13:22:46 +0000 (15:22 +0200)]
Use UTF-8 encoded language names.
Jan Schneider [Thu, 19 Aug 2010 12:07:05 +0000 (14:07 +0200)]
Fix version numbers.
Jan Schneider [Thu, 19 Aug 2010 08:17:22 +0000 (10:17 +0200)]
Tweak
Jan Schneider [Wed, 18 Aug 2010 21:06:24 +0000 (23:06 +0200)]
Change label to Portal here too.
Gunnar Wrobel [Mon, 23 Aug 2010 07:42:38 +0000 (09:42 +0200)]
Added the Installer module to Horde_Element. It allows to install a PEAR based Horde framework package from the repository tree, including its dependencies. Horde dependencies will also be pulled from the current tree, remote dependencies will be downloaded.
This should now allow a continuous integration (CI) setup that tests
the PEAR based Horde framework packages including their
dependencies. While we will support PEAR based releases for Horde4 I
assume from past experiences that the focus will remain on the
applications. As those rely on a fully installed framework it will be
quite easy to overlook PEAR dependency problems. So I feel it is
necessary to include the full installation method via PEAR into the CI
in order to spot problems early.
The general idea of the Horde_Element package is to provide tools for
managing Horde "Elements" which I consider to be PEAR based packages
from the framework (and maybe later also the applications). While I'm
currently focusing on the basics I think it would make sense to later
add methods that allow publishing the elements better than via
pear.horde.org.
Gunnar Wrobel [Sun, 22 Aug 2010 17:33:24 +0000 (19:33 +0200)]
Rename Horde_Qc to Horde_Element. I hope that fits better for what I have in mind for this package of tools.
Gunnar Wrobel [Mon, 5 Jul 2010 06:03:33 +0000 (08:03 +0200)]
Keep order as in branch master.
Gunnar Wrobel [Mon, 5 Jul 2010 03:45:03 +0000 (05:45 +0200)]
Automatic update.
Gunnar Wrobel [Mon, 5 Jul 2010 03:44:04 +0000 (05:44 +0200)]
Make the package.xml handling functional again. Integrate all patches the action has seen.
Gunnar Wrobel [Mon, 5 Jul 2010 03:13:28 +0000 (05:13 +0200)]
Completed option parsing.
Gunnar Wrobel [Wed, 30 Jun 2010 19:40:46 +0000 (21:40 +0200)]
Working option parser.
Gunnar Wrobel [Wed, 30 Jun 2010 08:33:30 +0000 (10:33 +0200)]
Cleanup first draft.
Gunnar Wrobel [Tue, 2 Mar 2010 12:49:51 +0000 (13:49 +0100)]
Intermediate step in refactoring the Quality package.
Gunnar Wrobel [Wed, 24 Feb 2010 12:34:47 +0000 (13:34 +0100)]
Renamed Horde_Packaging to Horde_Qc and started reorganzing into classes/modules.
Gunnar Wrobel [Wed, 30 Jun 2010 06:37:50 +0000 (08:37 +0200)]
Merged.
Michael M Slusarz [Mon, 23 Aug 2010 02:47:51 +0000 (20:47 -0600)]
Fix typo
Chuck Hagenbuch [Mon, 23 Aug 2010 02:18:55 +0000 (22:18 -0400)]
Remove some more references
Chuck Hagenbuch [Mon, 23 Aug 2010 02:17:47 +0000 (22:17 -0400)]
"datatree" is not an application
Chuck Hagenbuch [Mon, 23 Aug 2010 01:54:48 +0000 (21:54 -0400)]
Fix variable name - no tasks were viewable or editable
Chuck Hagenbuch [Sun, 22 Aug 2010 03:44:25 +0000 (23:44 -0400)]
Add Horde_Core_Ui_Layout to package.xml
Chuck Hagenbuch [Sun, 22 Aug 2010 03:42:35 +0000 (23:42 -0400)]
Move Horde_Ui_Layout under the Horde_Core_Ui umbrella
Chuck Hagenbuch [Sun, 22 Aug 2010 03:40:21 +0000 (23:40 -0400)]
Load preview images with GET, and fix bad parameter formatting
Chuck Hagenbuch [Sun, 22 Aug 2010 03:40:04 +0000 (23:40 -0400)]
No need for this snippet to be xhtml
Chuck Hagenbuch [Sun, 22 Aug 2010 03:30:27 +0000 (23:30 -0400)]
Remove unnecessary global
Chuck Hagenbuch [Sun, 22 Aug 2010 03:25:20 +0000 (23:25 -0400)]
Simplify block title when showing all galleries
Chuck Hagenbuch [Sun, 22 Aug 2010 03:24:26 +0000 (23:24 -0400)]
Don't add javascript until we need it. Don't offer gallery filters since getRecentImagesGeodata() isn't written to support them.
Chuck Hagenbuch [Sun, 22 Aug 2010 03:11:19 +0000 (23:11 -0400)]
Make getRandomGallery() actually random
Chuck Hagenbuch [Sun, 22 Aug 2010 02:54:38 +0000 (22:54 -0400)]
Fix variable name
Chuck Hagenbuch [Sun, 22 Aug 2010 02:47:54 +0000 (22:47 -0400)]
Pass $gallery to Ansel::getBreadCrumbs() whenever possible since otherwise we may lose state, like the current date on datemode galleries.
Chuck Hagenbuch [Sun, 22 Aug 2010 02:47:32 +0000 (22:47 -0400)]
WS
Chuck Hagenbuch [Sun, 22 Aug 2010 02:47:23 +0000 (22:47 -0400)]
Simplify
Chuck Hagenbuch [Sun, 22 Aug 2010 02:38:13 +0000 (22:38 -0400)]
Simplify; also fix logic for how isset() usually works vs. empty()
Chuck Hagenbuch [Sun, 22 Aug 2010 02:11:09 +0000 (22:11 -0400)]
CS, whitespace, remove some references, add a type hint or two
Chuck Hagenbuch [Sat, 21 Aug 2010 02:15:19 +0000 (22:15 -0400)]
Fix method name - deleteImage() doesn't exist, we want removeImage()
Chuck Hagenbuch [Sat, 21 Aug 2010 02:13:06 +0000 (22:13 -0400)]
We never want all of the images at all child levels when calling getImages()
That breaks the model of DateMode galleries acting like a collection of separate
galleries, and was causing API-generated lightboxes to have way too much data in
them, and pages like the Sort Images page to load all 2,000+ images in one of my
galleries.
Chuck Hagenbuch [Sat, 21 Aug 2010 01:40:51 +0000 (21:40 -0400)]
ws/style/spelling
Chuck Hagenbuch [Sat, 21 Aug 2010 01:40:29 +0000 (21:40 -0400)]
Need to assign the link() call to this variable, otherwise URLs are incorrect.
Chuck Hagenbuch [Sat, 21 Aug 2010 01:39:44 +0000 (21:39 -0400)]
ws/style
Chuck Hagenbuch [Sat, 21 Aug 2010 01:19:47 +0000 (21:19 -0400)]
Move logic for returning childImageIds to a function
Chuck Hagenbuch [Sat, 21 Aug 2010 01:07:21 +0000 (21:07 -0400)]
Make this public like all the other vars here