tomcat7.0
16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47502
markt [Wed, 2 Dec 2009 00:31:33 +0000 (00:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47502
Don't try and replicate attributes we know to be non-serializable
Patch by Tim Funk

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@886019 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBetter descriptions
markt [Tue, 1 Dec 2009 23:28:49 +0000 (23:28 +0000)]
Better descriptions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@886005 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48296
markt [Tue, 1 Dec 2009 23:21:41 +0000 (23:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48296
Generics and JavaDoc fixes
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885999 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove deprecated commands
markt [Tue, 1 Dec 2009 23:02:36 +0000 (23:02 +0000)]
Remove deprecated commands

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885996 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47453
markt [Tue, 1 Dec 2009 22:52:55 +0000 (22:52 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47453
Handle void return types.
Patch by Tim Funk.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885991 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore memory leak protection. Adds support for:
markt [Tue, 1 Dec 2009 20:04:17 +0000 (20:04 +0000)]
More memory leak protection. Adds support for:
 - optionally stopping threads started by a web app - this is dangerous last resort option for dev environments - not for production
 - clearing ThreadLocals created buy web apps
 - clearing unintentional references in sun.rmi.transport.Target

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885901 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMove from a global system property to a per Context attribute for clearing static...
markt [Tue, 1 Dec 2009 19:33:44 +0000 (19:33 +0000)]
Move from a global system property to a per Context attribute for clearing static references.
Change the default as this should no longer be an issue with modern JVMs and the other memory leak protection provided in Tomcat 7.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885889 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore memory leak protection - this time for the GC Daemon thread.
markt [Tue, 1 Dec 2009 18:44:32 +0000 (18:44 +0000)]
More memory leak protection - this time for the GC Daemon thread.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885860 13f79535-47bb-0310-9956-ffa450edef68

16 years agoProvide a simple way of enabling all cipher suites when testing.
markt [Tue, 1 Dec 2009 14:34:55 +0000 (14:34 +0000)]
Provide a simple way of enabling all cipher suites when testing.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885770 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd code that logs threads started but not stopped by the webapp.
markt [Sun, 29 Nov 2009 19:27:38 +0000 (19:27 +0000)]
Add code that logs threads started but not stopped by the webapp.
I have some highly experimental code to shut those threads down but it a) needs more work and b) needs to be made configurable before I commit it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885260 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefactor prior to adding some more clean-up methods.
markt [Sun, 29 Nov 2009 15:30:40 +0000 (15:30 +0000)]
Refactor prior to adding some more clean-up methods.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885241 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBetter logging of what is going on on Context reload
markt [Sun, 29 Nov 2009 14:32:41 +0000 (14:32 +0000)]
Better logging of what is going on on Context reload

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885233 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd logging when a context fails to unregister a JDBC driver.
markt [Sun, 29 Nov 2009 14:25:04 +0000 (14:25 +0000)]
Add logging when a context fails to unregister a JDBC driver.
Don't unregister the jdbc-obdc bridge driver that is loaded by the system classloader.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885231 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47342
markt [Fri, 27 Nov 2009 22:23:40 +0000 (22:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47342
Make sure replicated context is initialised before accessing fields
Patch provided by Keiichi Fujino

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@885038 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48289
markt [Fri, 27 Nov 2009 18:20:12 +0000 (18:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48289
Javadoc / generics fixes
Patch procided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884938 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48288
markt [Fri, 27 Nov 2009 18:14:19 +0000 (18:14 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48288
Supress some warnings
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884937 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48287
markt [Fri, 27 Nov 2009 18:11:34 +0000 (18:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48287
Eclipse warnings
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884935 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48285
markt [Fri, 27 Nov 2009 18:01:12 +0000 (18:01 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48285
Add handling of Async dispatcher types

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884926 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFurther simplication - delete unused constants
markt [Fri, 27 Nov 2009 17:53:29 +0000 (17:53 +0000)]
Further simplication - delete unused constants

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884924 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTake advantage of revised constants to simplify code
markt [Fri, 27 Nov 2009 17:52:25 +0000 (17:52 +0000)]
Take advantage of revised constants to simplify code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884923 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRe-order the numbering so each dispatcher type always refers to the same bit so we...
markt [Fri, 27 Nov 2009 17:24:47 +0000 (17:24 +0000)]
Re-order the numbering so each dispatcher type always refers to the same bit so we can use bitwise operations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884916 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48282
markt [Fri, 27 Nov 2009 17:17:12 +0000 (17:17 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48282
Correct possible NPE
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884914 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48267
markt [Fri, 27 Nov 2009 17:14:16 +0000 (17:14 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48267
Generics
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884913 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48297
markt [Fri, 27 Nov 2009 16:57:21 +0000 (16:57 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48297
Missing french translations and some weird sentences
Patch provided by Marc Paquette

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884907 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48295
markt [Fri, 27 Nov 2009 16:53:37 +0000 (16:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48295
Correct French translations.
Patch provided by Marc Paquette

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884905 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDouble-check getResource() works as intended after report of issue with Grails (http...
markt [Fri, 27 Nov 2009 14:55:26 +0000 (14:55 +0000)]
Double-check getResource() works as intended after report of issue with Grails (jira.codehaus.org/browse/GRAILS-5038)
All seems OK. Maybe a Grails issue?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884887 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused class
markt [Thu, 26 Nov 2009 19:38:46 +0000 (19:38 +0000)]
Remove unused class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884676 13f79535-47bb-0310-9956-ffa450edef68

16 years agoShouldn't do last-minute changes before a large commit...
costin [Thu, 26 Nov 2009 07:02:53 +0000 (07:02 +0000)]
Shouldn't do last-minute changes before a large commit...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884424 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdded eclipse files, remove unused build helper file
costin [Thu, 26 Nov 2009 06:56:33 +0000 (06:56 +0000)]
Added eclipse files, remove unused build helper file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884422 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTests. Note that you need to have watchdog checked out and built (if it can still...
costin [Thu, 26 Nov 2009 06:55:49 +0000 (06:55 +0000)]
Tests. Note that you need to have watchdog checked out and built (if it can still be built... - probably should checkin the binaries ).
There are a bunch of useful tests in watchdog - I'm not running watchdog, but turned it into JUnit test cases, we just
need the web apps and golden files from there.

At the moment there are about 12 failures (out of ~1000 tests - there are several dups because same tests are run against
different targets )

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884421 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFor downloading deps - used Ant Ivy. The actual deps are declared in a maven pom...
costin [Thu, 26 Nov 2009 06:52:28 +0000 (06:52 +0000)]
For downloading deps - used Ant Ivy. The actual deps are declared in a maven pom.xml ( Ivy is supporting it just fine ).

The maven file can be used to compile and test tomcat-lite in servlet-2.5 mode - I wouldn't recomend to anyone to
use it, but if you have to and can't use build.xml - it does the basic thing.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884420 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFew change to the ObjectManager ( intended for integration with existing frameworks ).
costin [Thu, 26 Nov 2009 06:50:10 +0000 (06:50 +0000)]
Few change to the ObjectManager ( intended for integration with existing frameworks ).
The 'sample/if no other framework around' SimpleObject manager no longer depends on IntrospectionUtils, refactored it ( and parts of modeler )
to DynamicObject.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884419 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMoved the old coyote-specific servlet api impl to coyote/servlet
costin [Thu, 26 Nov 2009 06:48:42 +0000 (06:48 +0000)]
Moved the old coyote-specific servlet api impl to coyote/servlet
Added (10% working) coyote connector that uses the new http impl

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884418 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemoved the 'addons' package, moved the interfaces close to the packages that define...
costin [Thu, 26 Nov 2009 06:47:03 +0000 (06:47 +0000)]
Removed the 'addons' package, moved the interfaces close to the packages that define them, also
some code move around.

The web.xml parsing ( and some incipient 3.0 annotation processing ) is independent of tomcat, indended as
a user-library.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884416 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBased on the code in tomcat.lite, but using the new http connector instead of coyote.
costin [Thu, 26 Nov 2009 06:45:13 +0000 (06:45 +0000)]
Based on the code in tomcat.lite, but using the new http connector instead of coyote.
Also the ObjectManager and properties are no longer used.

This can be compiled against both 3.0 and 2.5 ( with proper exclude ), since one of the goals
of tomcat-lite is to be useable against current servers.

Note that this is mostly for testing and to allow existing servlets to be used _outside_ of a
servlet engine - this is not a servlet engine.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884415 13f79535-47bb-0310-9956-ffa450edef68

16 years agoProxy service - CONNECT doesn't seem to work ( probably because it didn't have a...
costin [Thu, 26 Nov 2009 06:42:49 +0000 (06:42 +0000)]
Proxy service - CONNECT doesn't seem to work ( probably because it didn't have a test ), the rest works
pretty well. Also includes a small socks server I used while testing. Almost all work is non-blocking and
done in the selector thread.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884413 13f79535-47bb-0310-9956-ffa450edef68

16 years agoThe http implementation - it may be hard to recognize the original connector code...
costin [Thu, 26 Nov 2009 06:41:00 +0000 (06:41 +0000)]
The http implementation - it may be hard to recognize the original connector code from tomcat after many iterations.
Changes compared with coyote:
- both server and client mode
- HttpRequest/HttpResponse implement most of methods in the HttpServletRequest - with the addition of setters, for use
in client mode. They don't implement the interfaces - or 'servlet framework' specific methods - but should look
familiar to people using this as a library
- mapping is moved in this package, also support running HttpServices in the selector thread (proxy will run this way)
- MimeHeaders are gone, so are the parameters - replaced with the MultiMap, which is based on MimeHeaders but adds a HashMap
instead of linear scanning
See tests for examples.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884412 13f79535-47bb-0310-9956-ffa450edef68

16 years agoThis is the first draft of the refactored coyote connector.
costin [Thu, 26 Nov 2009 06:35:43 +0000 (06:35 +0000)]
This is the first draft of the refactored coyote connector.
Lots of big changes:
- MessageBytes is gone - BBuffer, CBuffer are used as buffers, BBucket/CBucket are used for wrapping bytes
- C2B/B2C are gone - replaced by nio charsets in IOReader/IOWriter. CBuffer is still needed (instead of a StringBuilder ) to have
access to the raw chars and avoid copy
- speaking of copy, IOChannel uses a list of buffers instead of growing a buffer. For proxy we should be able to move
buffers from in to out.  This works a bit better with the char conversions, etc
- Nio code heavily refactored - I didn't add APR but shouldn't be hard if anyonew wants.
- Ssl is barely working - needs improvements

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884410 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReduce visibility
markt [Thu, 26 Nov 2009 01:02:19 +0000 (01:02 +0000)]
Reduce visibility

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884351 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore memory leak protection. This one is particularly nasty as profilers don't appear...
markt [Wed, 25 Nov 2009 23:56:30 +0000 (23:56 +0000)]
More memory leak protection. This one is particularly nasty as profilers don't appear to show the GC root associated with the leak.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@884341 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48266
markt [Wed, 25 Nov 2009 01:00:07 +0000 (01:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48266
Generics and unused imports.
Patch by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883943 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47836
markt [Tue, 24 Nov 2009 01:27:40 +0000 (01:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47836
Don't keep TLD/listener info between reloads

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883565 13f79535-47bb-0310-9956-ffa450edef68

16 years agoExplicitly close the stream.
markt [Tue, 24 Nov 2009 01:15:19 +0000 (01:15 +0000)]
Explicitly close the stream.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883562 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRest of fix required for https://issues.apache.org/bugzilla/show_bug.cgi?id=48113
markt [Mon, 23 Nov 2009 15:10:20 +0000 (15:10 +0000)]
Rest of fix required for https://issues.apache.org/bugzilla/show_bug.cgi?id=48113
Based on a patch by Quintin Beukes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883362 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48233
markt [Mon, 23 Nov 2009 00:46:20 +0000 (00:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48233
Reduce visibility of loggers
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883204 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=482
markt [Mon, 23 Nov 2009 00:37:36 +0000 (00:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=482
Use volatile since field is accessed by multiple threads

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883203 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48239
markt [Mon, 23 Nov 2009 00:36:10 +0000 (00:36 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48239
HexUtils exposes public array
Based on a patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883201 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48248
markt [Mon, 23 Nov 2009 00:31:43 +0000 (00:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48248
Use volatile since field is accessed by multiple threads

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883200 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48249
markt [Mon, 23 Nov 2009 00:28:03 +0000 (00:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48249
Use volatile since field is accessed by multiple threads

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883199 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd missing property
markt [Mon, 23 Nov 2009 00:23:41 +0000 (00:23 +0000)]
Add missing property

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883198 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix failing SSL test
markt [Mon, 23 Nov 2009 00:11:11 +0000 (00:11 +0000)]
Fix failing SSL test
Prevent NPE in NIO connector when using SSL and the default keystore password

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883196 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48257
markt [Sun, 22 Nov 2009 23:31:18 +0000 (23:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48257
Patch provided by Guillermo GutiĆ©rrez

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883186 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCleanup Javadoc as well as code
markt [Sun, 22 Nov 2009 23:29:05 +0000 (23:29 +0000)]
Cleanup Javadoc as well as code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883184 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse correct attribute name now all the renaming code has been removed
markt [Sun, 22 Nov 2009 23:25:35 +0000 (23:25 +0000)]
Use correct attribute name now all the renaming code has been removed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883183 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48049
markt [Sun, 22 Nov 2009 22:56:53 +0000 (22:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48049
Correct copy and paste error and call correct function

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883177 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClean up
markt [Sun, 22 Nov 2009 22:41:21 +0000 (22:41 +0000)]
Clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883169 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47799
markt [Sun, 22 Nov 2009 22:37:43 +0000 (22:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47799
Unable to configure domain in Membership and DomainFilterInterceptor
Patch provided by Keiichi Fujino

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883165 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47462
markt [Sun, 22 Nov 2009 20:49:04 +0000 (20:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47462
Need to be able to override metadata complete if set in the global web.xml
Patch provided by Keiichi Fujino

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883146 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix some Eclipse warnings
markt [Sun, 22 Nov 2009 20:44:09 +0000 (20:44 +0000)]
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883145 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47997
markt [Sun, 22 Nov 2009 19:59:51 +0000 (19:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47997
Process changes to the naming resources for all JNDI contexts, not just the global one.
Patch by Michael Allman

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883134 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47718
markt [Sun, 22 Nov 2009 19:39:33 +0000 (19:39 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47718
Correct file descriptor leak on context reload/stop
Patch provided by George Sexton

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883130 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
markt [Sun, 22 Nov 2009 19:18:19 +0000 (19:18 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47609
Implment fail-safe EOL conversion for source disributions
Based on a patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883125 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove old comment
markt [Sun, 22 Nov 2009 18:59:06 +0000 (18:59 +0000)]
Remove old comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@883119 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd in DataSource supprot
fhanik [Fri, 20 Nov 2009 21:39:36 +0000 (21:39 +0000)]
Add in DataSource supprot
Add in XA support

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882723 13f79535-47bb-0310-9956-ffa450edef68

16 years agoComplete the FileUpload implementation and use it for the html manager app.
markt [Fri, 20 Nov 2009 19:27:11 +0000 (19:27 +0000)]
Complete the FileUpload implementation and use it for the html manager app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882690 13f79535-47bb-0310-9956-ffa450edef68

16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=48252
fhanik [Fri, 20 Nov 2009 16:57:31 +0000 (16:57 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=48252
Fix potential recursion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882640 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStart to hook-up the commons-file upload port to the Servlet3 file upload API
markt [Fri, 20 Nov 2009 13:46:21 +0000 (13:46 +0000)]
Start to hook-up the commons-file upload port to the Servlet3 file upload API
 - Make sure the upload config is available when required
 - Start to migrate the HTML manager to the upload API

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882550 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix error in previous commit
markt [Fri, 20 Nov 2009 13:42:34 +0000 (13:42 +0000)]
Fix error in previous commit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882547 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImprove workaround for CVE-2009-3555
markt [Thu, 19 Nov 2009 22:06:43 +0000 (22:06 +0000)]
Improve workaround for CVE-2009-3555
On the plus side, it doesn't rely on an async event to close the connection
On the down side, I haven't yet found a way to log client initiated handshakes before they get closed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882320 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix SSL for BIO post refactoring
markt [Thu, 19 Nov 2009 18:00:09 +0000 (18:00 +0000)]
Fix SSL for BIO post refactoring
Make attribute names consistent
Endpoints are now responsible for configuring the SSL "engine"
Basics work but still needs more testing
NIO & APR to follow

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882231 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix Eclipse warning
markt [Thu, 19 Nov 2009 16:05:48 +0000 (16:05 +0000)]
Fix Eclipse warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882186 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix SSL config error as a result of attribute refactoring.
markt [Thu, 19 Nov 2009 15:08:03 +0000 (15:08 +0000)]
Fix SSL config error as a result of attribute refactoring.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882169 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix the Eclipse warnings - no functional change
markt [Thu, 19 Nov 2009 14:05:56 +0000 (14:05 +0000)]
Fix the Eclipse warnings - no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882151 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused code
markt [Thu, 19 Nov 2009 14:01:27 +0000 (14:01 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882148 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48234
markt [Thu, 19 Nov 2009 02:01:57 +0000 (02:01 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48234
Align Javadoc with code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882029 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStatic so sync on class object
markt [Thu, 19 Nov 2009 00:50:04 +0000 (00:50 +0000)]
Static so sync on class object

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882019 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48233
markt [Thu, 19 Nov 2009 00:46:52 +0000 (00:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48233
More loggers to private static final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882017 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix copy/paste error
markt [Thu, 19 Nov 2009 00:20:35 +0000 (00:20 +0000)]
Fix copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882014 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix theorectical sync issue and soem Eclipse warnings
markt [Wed, 18 Nov 2009 23:54:24 +0000 (23:54 +0000)]
Fix theorectical sync issue and soem Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882008 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix NPE
markt [Wed, 18 Nov 2009 23:47:29 +0000 (23:47 +0000)]
Fix NPE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882004 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48172
markt [Wed, 18 Nov 2009 23:33:57 +0000 (23:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48172
Potential threading issues, make fields final where possible

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@882002 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48197
markt [Wed, 18 Nov 2009 23:22:13 +0000 (23:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48197
Reduce visibility where possible
Fix javadoc
Based on a patch by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881996 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48230
markt [Wed, 18 Nov 2009 23:10:53 +0000 (23:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48230
Remove unused imports. Patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881990 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix copy and paste errors
markt [Wed, 18 Nov 2009 22:37:19 +0000 (22:37 +0000)]
Fix copy and paste errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881972 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix more typos
markt [Wed, 18 Nov 2009 21:23:25 +0000 (21:23 +0000)]
Fix more typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881942 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix typos
markt [Wed, 18 Nov 2009 13:39:45 +0000 (13:39 +0000)]
Fix typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881776 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBeing *really* picky. It is a single web app.
markt [Wed, 18 Nov 2009 13:23:51 +0000 (13:23 +0000)]
Being *really* picky. It is a single web app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881765 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48217
markt [Wed, 18 Nov 2009 12:10:12 +0000 (12:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48217
Make logs final and private; add missing @Override markers
Patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881742 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix typo
markt [Wed, 18 Nov 2009 11:53:46 +0000 (11:53 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881735 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdated to match the latest catalina.policy file
kkolinko [Wed, 18 Nov 2009 03:09:12 +0000 (03:09 +0000)]
Updated to match the latest catalina.policy file
Updated the section about implicit permissions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881655 13f79535-47bb-0310-9956-ffa450edef68

16 years agoWrapped long lines. As the text of this file is copy-pasted into security-manager...
kkolinko [Wed, 18 Nov 2009 03:00:57 +0000 (03:00 +0000)]
Wrapped long lines. As the text of this file is copy-pasted into security-manager-howto.html, it will make it more readable.

Added a comment regarding tomcat-juli.jar

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881654 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48196
markt [Tue, 17 Nov 2009 23:03:43 +0000 (23:03 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48196
Reduce visibility. Patch by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881606 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48176
markt [Tue, 17 Nov 2009 23:00:31 +0000 (23:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48176
Make fields final. Patch by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881600 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48175
markt [Tue, 17 Nov 2009 22:59:34 +0000 (22:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48175
Make loggers final. Patch by sebb with minor modification as original patch broke compilation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881599 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse standard modifier order
markt [Tue, 17 Nov 2009 22:55:12 +0000 (22:55 +0000)]
Use standard modifier order

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881596 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48174
markt [Tue, 17 Nov 2009 22:47:39 +0000 (22:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48174
Use final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881591 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48173
markt [Tue, 17 Nov 2009 22:46:41 +0000 (22:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48173
Use final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881590 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48151
markt [Tue, 17 Nov 2009 22:44:58 +0000 (22:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48151
Add missing AL2 headers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881589 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48150
markt [Tue, 17 Nov 2009 22:35:41 +0000 (22:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48150
Correct JavaDoc typos. Patch provided by gingyang.xu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881582 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48149
markt [Tue, 17 Nov 2009 22:33:58 +0000 (22:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48149
Correct JavaDoc typos. Patch provided by gingyang.xu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881578 13f79535-47bb-0310-9956-ffa450edef68