markt [Sat, 16 Jan 2010 13:54:04 +0000 (13:54 +0000)]
TCK failure: Can't use the string representation to test for equality as whitespace must be ignored. Use the parsed nodes instead.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899949
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 16 Jan 2010 12:57:55 +0000 (12:57 +0000)]
TCK failure: Must check to see if property is resolved and throw exception if not.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899935
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 16 Jan 2010 10:50:12 +0000 (10:50 +0000)]
Fix bug in Enum to Enum coercion spotted during code review
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899919
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 16 Jan 2010 10:49:25 +0000 (10:49 +0000)]
Add some test cases for Enum to Enum coercion
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899918
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 16 Jan 2010 10:37:31 +0000 (10:37 +0000)]
TCK failure. Wrong exception on failure.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899916
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Fri, 15 Jan 2010 20:02:36 +0000 (20:02 +0000)]
Make a distinction based on type=javax.sql.DataSource or type=javax.sql.XADataSource, some components, like JIRA actually do an instanceof on the object to determine what it is instead of relying on the configuration.
Make static methods non static for easier extendability
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899796
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 19:55:31 +0000 (19:55 +0000)]
TCK failure. Make sure we throw an ELException, not an IAE.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899792
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 19:44:14 +0000 (19:44 +0000)]
TCK failure. Invalid index should throw PNFE.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899788
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 19:37:46 +0000 (19:37 +0000)]
TCK failure. Make sure an ELException is throw if the conversion fails.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899783
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 19:22:42 +0000 (19:22 +0000)]
Fix TCK failure. Trying to assign an object of the wrong type to an array should throw a ClassCaseException.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899770
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 19:22:12 +0000 (19:22 +0000)]
Fix TCK failure. Trying to assign an object of the wrong type to an array should throw a ClassCaseException.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899769
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 18:04:22 +0000 (18:04 +0000)]
Re-factoring. WebXml is a better fit in o.a.c.deploy
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899737
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 15:40:35 +0000 (15:40 +0000)]
revert r899395
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899668
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 15:00:50 +0000 (15:00 +0000)]
Fix the remaining TCK signature test failures.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899653
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 14:17:22 +0000 (14:17 +0000)]
Fix signature test failures in javax.servlet.jsp package
Move deprecation javadoc to end of block
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899635
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 14:10:11 +0000 (14:10 +0000)]
The spec has a spelling mistake. Align with the spec until it is fixed.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899634
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 11:30:21 +0000 (11:30 +0000)]
Add the bug url
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899601
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 00:38:04 +0000 (00:38 +0000)]
API uses Set rather than EnumSet
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899498
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 00:28:43 +0000 (00:28 +0000)]
Simplify
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899497
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 15 Jan 2010 00:18:24 +0000 (00:18 +0000)]
Simplify
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899493
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 22:45:43 +0000 (22:45 +0000)]
No need to supress these warnings. They cxan be fixed.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899452
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 22:45:02 +0000 (22:45 +0000)]
Updated the generated code after r899450
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899451
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 22:41:41 +0000 (22:41 +0000)]
Remove the Suffix interface and get the Parser to create a MehtodParameters object which allows a cleaner implementation.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899450
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 22:38:57 +0000 (22:38 +0000)]
Add a test case for the final part of the EL 2.2 implementation
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899449
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 22:38:23 +0000 (22:38 +0000)]
Line length
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899448
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 21:33:58 +0000 (21:33 +0000)]
Fix TCK failures with security manager due to fix for bug 47774
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899420
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 20:21:23 +0000 (20:21 +0000)]
zip is for non-windows platforms
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899395
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 19:48:41 +0000 (19:48 +0000)]
Skipping installer shouldn't break package-winzip target
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899380
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 18:37:52 +0000 (18:37 +0000)]
Need to fix line endings for zip distro if building on non-windows
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899348
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Jan 2010 16:43:26 +0000 (16:43 +0000)]
Add missing extension for line-ending conversion in src releases
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899284
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Thu, 14 Jan 2010 08:59:19 +0000 (08:59 +0000)]
Allow compliance with SRV.15.2.22.1 to be controlled separately from STRICT_SERVLET_COMPLIANCE,
and turn it on by default.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899124
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Thu, 14 Jan 2010 08:26:37 +0000 (08:26 +0000)]
Revert examples app patch of r893496
Setting org.apache.catalina.STRICT_SERVLET_COMPLIANCE=true also provides this feature,
and, I think, better than this patch does.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@899109
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 22:10:49 +0000 (22:10 +0000)]
Implement the new ValueExpression.getValueReference() method.
Add some plumbing for MethodExpression.isParametersProvided()
Add some more generics where we can without breaking the code generation
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898969
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 22:08:54 +0000 (22:08 +0000)]
Add a test case for the new ValueExpression.getValueReference() method.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898967
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 13 Jan 2010 19:34:31 +0000 (19:34 +0000)]
Fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898913
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 13 Jan 2010 19:32:51 +0000 (19:32 +0000)]
Up the version num
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898912
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 13 Jan 2010 19:23:53 +0000 (19:23 +0000)]
Force a unconditional disconnect when an error happens, like dropped connections to a firewall
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898906
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 19:20:42 +0000 (19:20 +0000)]
Implement remainder of EL 2.2. API changes
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898902
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 19:19:25 +0000 (19:19 +0000)]
Jasper Parser change so methods with parameters aren't mistaken for functions
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898900
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 19:18:08 +0000 (19:18 +0000)]
Tab police, fix Eclipse warnings, add @since Javadoc
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898897
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 13 Jan 2010 19:08:09 +0000 (19:08 +0000)]
Remove a dependency on Java 6 that accidentally got introduced
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898889
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 18:05:59 +0000 (18:05 +0000)]
Updated autogenerated code after r898864
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898865
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 18:02:36 +0000 (18:02 +0000)]
Implement method invocation with parameters
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898864
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 18:01:26 +0000 (18:01 +0000)]
Add a test for method invocation with parameters
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898863
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 18:00:24 +0000 (18:00 +0000)]
Up the timeout. 100s isn't always long enough when stepping through why a failing test.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898862
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 17:53:36 +0000 (17:53 +0000)]
If the method is found, mark the property as resolved
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898860
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 13 Jan 2010 17:00:26 +0000 (17:00 +0000)]
Following changes
1. Default bufferSize is 0 - rely on system behavior
2. bufferSize of <0 will automatically flush the writer on each write
3. autoFlush for printWriter is false, otherwise we are duplicating the effort
4. date is a volatile variable so that a write to the variable gets propagated properly
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898836
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 11:18:10 +0000 (11:18 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48532
Better documentation of the SSL connector defaults
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898718
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 13 Jan 2010 10:26:58 +0000 (10:26 +0000)]
Add TODO
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898703
13f79535-47bb-0310-9956-
ffa450edef68
costin [Wed, 13 Jan 2010 02:07:25 +0000 (02:07 +0000)]
Moved the connection pool to a top level class and started to add more code. Still missing is evicting kept-alive connections and
queueing to limit the number of active requests per host ( and probably more ).
Started to make spdy more like a part of a http request - i.e. upgrade if supported by both ends, etc. Now load
tests seem to work - no more OOM. Due to compression spdy it's using more memory per connection, current tests don't enable compression
( it's accepted for incoming connections ).
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898619
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 22:43:23 +0000 (22:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48516
Fix possible NPE when user does not exist in directory
Patch provided by Kevin Conaway
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898558
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 22:36:15 +0000 (22:36 +0000)]
Improved fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=47774
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898555
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 22:15:31 +0000 (22:15 +0000)]
Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=47774
Better fix to follow
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898551
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 22:03:32 +0000 (22:03 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48530
Add info on the Server Status page to the Manager How-To
Based on a patch by Arnaud Espy
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898543
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 21:36:49 +0000 (21:36 +0000)]
Fix bug 48004. Allow applications to set the server header.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898527
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 19:25:40 +0000 (19:25 +0000)]
JULI needs to be on class path
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898475
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 19:06:48 +0000 (19:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48421
Clean up a web application's logs and handlers when it stops. This involved modifying the fix that prevented log messages being lost in shutdown.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898468
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 18:27:33 +0000 (18:27 +0000)]
Make logging consistent for HTML and text interfaces
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898457
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 18:23:27 +0000 (18:23 +0000)]
Use string manager for log messages
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898456
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 17:57:55 +0000 (17:57 +0000)]
Fix the Eclipse warnings for the host-manager
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898443
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 13:33:58 +0000 (13:33 +0000)]
Update the comment. We don't want or need another full EL parser.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898318
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 12:03:07 +0000 (12:03 +0000)]
Avoid NPE if bundle is missing
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898297
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 11:42:46 +0000 (11:42 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48524
Remove unused keys. Fix case issue for jsp.error.usebean.noSession.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898289
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 11:09:18 +0000 (11:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48523
Resolve duplicate keys
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898279
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 10:31:03 +0000 (10:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48517
Reduce scope of @SupressWarnings and document reasoning
Based on a patch by sebb
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898275
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 08:59:08 +0000 (08:59 +0000)]
Make the check case insensitive. A strict reading of the specification requires case sensitivity but be pragmatic.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898256
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Jan 2010 00:10:46 +0000 (00:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47977
Using a body with tags specified to have empty body content should cause an error
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898126
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Mon, 11 Jan 2010 23:42:20 +0000 (23:42 +0000)]
Rename TCN_RECOMMENDED_MIN -> TCN_RECOMMENDED_MINOR
to match the naming of TCN_REQUIRED_MINOR and to resolve ambiguity, because "min" usually means "minimum".
This field does not exist in tc6.0.x code.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@898115
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Jan 2010 14:59:35 +0000 (14:59 +0000)]
Using localhost should allow this to work with IPv4 and/or IPv6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897888
13f79535-47bb-0310-9956-
ffa450edef68
mturk [Mon, 11 Jan 2010 07:14:16 +0000 (07:14 +0000)]
By default use released 1.1.19
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897776
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 23:04:41 +0000 (23:04 +0000)]
Update generated code after r897728
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897729
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 23:03:13 +0000 (23:03 +0000)]
Remove the BADLY_ESCAPED_STRING_LITERAL - it could cause mistakes to be silently swallowed
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897728
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 13:11:52 +0000 (13:11 +0000)]
Fix the remaining Eclipse warnings in the non-generated classes
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897635
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 12:52:20 +0000 (12:52 +0000)]
\$ and \# are not valid escapes. The Parser will throw an error before this code is ever called but remove them anyway for clarity.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897632
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 12:51:13 +0000 (12:51 +0000)]
Update generated code after r897629
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897631
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 12:47:49 +0000 (12:47 +0000)]
Fix a bug found during review.
Whilst the old version is what is defined in the spec, the definition in the spec does not agree with the description and associatedcomments in the spec. I have raised this as https://uel.dev.java.net/issues/show_bug.cgi?id=10
Modify the parser on the basis that the textual description and comments in the spec are correct and the production for StringLiteral is wrong
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897629
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 12:44:31 +0000 (12:44 +0000)]
Add tests for a bug found whilst reviewing the ELParser
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897627
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 11:54:34 +0000 (11:54 +0000)]
Rename
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897621
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 11:47:48 +0000 (11:47 +0000)]
Fix generics warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897620
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 11:37:16 +0000 (11:37 +0000)]
Add a test case for bug36923
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897619
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 11:13:10 +0000 (11:13 +0000)]
Add mising tests.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897616
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 11:12:42 +0000 (11:12 +0000)]
Better coverage for JSP attribute parsing
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897615
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Jan 2010 11:10:36 +0000 (11:10 +0000)]
Re-work EL attribute parsing. The underlying issue was complete independence of attribute and EL parsing. The attribute parser would generate the same result - ${1+1} - after parsing ${1+1} and \${+1} and the EL had no way to differentiate between the first (that should be treated as an expression) and the second (that should be treated as a literal). The attribute parser has been modified to output any literals that would be mi-interpreted by the EL parser as EL literals. ie \ is output as ${'\\'} or #{'\\'}, $ as ${'$'} or #{'$'} and # as ${'#'} or #{'#'}.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897614
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Jan 2010 13:14:58 +0000 (13:14 +0000)]
Rename to fit expected naming convention
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897442
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sat, 9 Jan 2010 04:30:14 +0000 (04:30 +0000)]
Update documentation
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897381
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sat, 9 Jan 2010 03:59:59 +0000 (03:59 +0000)]
Followup for r816252/r891328
Allow to disable buffering in JULI FileHandler
The previous implementation did not work as expected because of buffering performed by OutputStreamWriter
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897380
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sat, 9 Jan 2010 02:25:44 +0000 (02:25 +0000)]
Trivial: move first line of the resource file to be below the license header
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897370
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sat, 9 Jan 2010 02:13:19 +0000 (02:13 +0000)]
Correction for the README pages:
Tomcat 7 requires Java 6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897368
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Jan 2010 18:59:19 +0000 (18:59 +0000)]
Now the EL parser doesn't unquote stuff it shouldn't (r896589), remove the attributeValueWithEL() method as it is causing more problems than it is solving. There are still a couple of test failures but the solution I have in mind for them won't require this method.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897300
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Fri, 8 Jan 2010 04:37:23 +0000 (04:37 +0000)]
followup to r896892
Additional message updates for JSP 2.2
Commented-out the untranslated strings in the French file, so that the English ones could be used
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897093
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 20:24:57 +0000 (20:24 +0000)]
Add another edge case
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@897005
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 18:23:14 +0000 (18:23 +0000)]
Add another test case. This one passes at the moment but would fail with some of the ideas I have had to fix the tests that currently fail.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896953
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 18:09:33 +0000 (18:09 +0000)]
Correct tests. Remaining failures shoudl now be Jasper/EL bugs
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896949
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 17:36:27 +0000 (17:36 +0000)]
Add the tag library definition so the tests actually do what they are supposed to.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896937
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 16:35:49 +0000 (16:35 +0000)]
Remove comments
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896920
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 16:22:24 +0000 (16:22 +0000)]
Add missing license headers
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896916
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 16:06:45 +0000 (16:06 +0000)]
Add various EL test cases, mostly extracted from local test JSPs I have used for individual issues.
Thanks to kkolinko and the numerous bug reporters that provided the basis for many of these.
At present, although this is Tomcat 7, the tests only cover JSP 2.1 functionality.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896913
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 7 Jan 2010 14:20:30 +0000 (14:20 +0000)]
Update for JSP 2.2
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896892
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jan 2010 19:04:32 +0000 (19:04 +0000)]
Prevent NPE in emebedded case when no web.xml is provided at all
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896622
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 6 Jan 2010 18:51:24 +0000 (18:51 +0000)]
Add a test case for bug 48112 (note this passes - need to check when used in a JSP)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@896620
13f79535-47bb-0310-9956-
ffa450edef68