tomcat7.0
14 years agoRemove unnecessary code, fix a Findbugs warning
markt [Fri, 18 Feb 2011 20:43:46 +0000 (20:43 +0000)]
Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072138 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code, fix a Findbugs warning
markt [Fri, 18 Feb 2011 20:39:48 +0000 (20:39 +0000)]
Remove unnecessary code, fix a Findbugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072136 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50743
markt [Fri, 18 Feb 2011 16:53:08 +0000 (16:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50743
Cache CheckStyle results between builds to speed up validation. Patch provided by Oliver.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072057 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50189
markt [Fri, 18 Feb 2011 16:24:36 +0000 (16:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50189
Once the application has finished writing to the response, prevent further reads from the request since this causes various problems in the connectors which do not expect this.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072042 13f79535-47bb-0310-9956-ffa450edef68

14 years agoline length
markt [Fri, 18 Feb 2011 15:30:57 +0000 (15:30 +0000)]
line length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1072024 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50802
markt [Thu, 17 Feb 2011 20:38:49 +0000 (20:38 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50802
Ensure that ServletContext.getResourcePaths() includes static resources packaged in JAR files in its output.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071774 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate ignore list with the full set
fhanik [Thu, 17 Feb 2011 19:42:05 +0000 (19:42 +0000)]
Update ignore list with the full set

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071757 13f79535-47bb-0310-9956-ffa450edef68

14 years agoignore list
fhanik [Thu, 17 Feb 2011 18:22:23 +0000 (18:22 +0000)]
ignore list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071735 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate version numbers
fhanik [Thu, 17 Feb 2011 18:16:22 +0000 (18:16 +0000)]
Update version numbers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071734 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrectly use the readFully method. Add a utility method to sort absolute order
fhanik [Thu, 17 Feb 2011 16:23:44 +0000 (16:23 +0000)]
Correctly use the readFully method. Add a utility method to sort absolute order

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071677 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50780
markt [Thu, 17 Feb 2011 16:08:08 +0000 (16:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50780
Fix memory leak in APR implementation of AJP connector introduced by the refactoring for bug 49884

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071671 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code.
markt [Thu, 17 Feb 2011 14:11:41 +0000 (14:11 +0000)]
Remove unnecessary code.
I don't see a code path that could result in the socket being in the map at this point

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071617 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary code.
markt [Thu, 17 Feb 2011 14:04:37 +0000 (14:04 +0000)]
Remove unnecessary code.
I don't see a code path that could result in the socket being in the map at this point

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071614 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix NPEs on shutdown. Loop is prevented above when the child is removed.
markt [Thu, 17 Feb 2011 13:10:36 +0000 (13:10 +0000)]
Fix NPEs on shutdown. Loop is prevented above when the child is removed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071601 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTypo? Copy and paste error?
markt [Thu, 17 Feb 2011 12:11:36 +0000 (12:11 +0000)]
Typo? Copy and paste error?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071592 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo
markt [Thu, 17 Feb 2011 12:10:32 +0000 (12:10 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071591 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50789
markt [Thu, 17 Feb 2011 10:32:07 +0000 (10:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50789
Provide an option to enable ServletRequestListeners for forwards as required by some CDI frameworks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071565 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50790
markt [Thu, 17 Feb 2011 09:59:30 +0000 (09:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50790
Improve method resolution in EL expressions
Add test cases for this bug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071561 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove duplicate code.
rjung [Thu, 17 Feb 2011 09:51:17 +0000 (09:51 +0000)]
Remove duplicate code.

The implementation in the base class is identical and all other http11 implementations also inherit it from there.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071560 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent NPE in unit tests as a result of r1067718
markt [Thu, 17 Feb 2011 09:46:52 +0000 (09:46 +0000)]
Prevent NPE in unit tests as a result of r1067718

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071559 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix test failure now r1069056 has added stricter checks for state transitions
markt [Thu, 17 Feb 2011 09:29:58 +0000 (09:29 +0000)]
Fix test failure now r1069056 has added stricter checks for state transitions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071557 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent NPE in unit tests as a result of r1067718
markt [Thu, 17 Feb 2011 09:20:16 +0000 (09:20 +0000)]
Prevent NPE in unit tests as a result of r1067718

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071556 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrep for next release
markt [Wed, 16 Feb 2011 17:56:03 +0000 (17:56 +0000)]
Prep for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071329 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50793
markt [Wed, 16 Feb 2011 17:35:24 +0000 (17:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50793
Correctly fire request init/destroy events for astnc requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071321 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove test outside the loop
markt [Wed, 16 Feb 2011 14:18:12 +0000 (14:18 +0000)]
Move test outside the loop

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071262 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50713
markt [Wed, 16 Feb 2011 13:43:39 +0000 (13:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50713
Remove roles command from Manager application

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1071243 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Tue, 15 Feb 2011 17:00:05 +0000 (17:00 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070967 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50700
markt [Mon, 14 Feb 2011 19:05:25 +0000 (19:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50700
Ensure that the override attribute of context parameters is correctly followed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070609 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrectly test for no attributes
markt [Mon, 14 Feb 2011 09:53:24 +0000 (09:53 +0000)]
Correctly test for no attributes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070420 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50771
kfujino [Mon, 14 Feb 2011 08:47:49 +0000 (08:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50771
Ensure HttpServletRequest#getAuthType() returns the name of the authentication scheme
if request has already been authenticated.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070409 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1069836
kfujino [Mon, 14 Feb 2011 02:04:06 +0000 (02:04 +0000)]
Followup to r1069836
Remove unused managerClassName attribute from mbeans-descriptors.xml.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070365 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50726
markt [Sat, 12 Feb 2011 19:35:26 +0000 (19:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50726
Ensure that the use of the genStringAsCharArray does not result in String constants that are too long for valid Java code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1070139 13f79535-47bb-0310-9956-ffa450edef68

14 years agodoco and version update
fhanik [Fri, 11 Feb 2011 16:42:05 +0000 (16:42 +0000)]
doco and version update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069876 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50759
fhanik [Fri, 11 Feb 2011 16:32:41 +0000 (16:32 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50759
Update validation timestamp if using an external validator.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069864 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove deprecated code
markt [Fri, 11 Feb 2011 15:39:52 +0000 (15:39 +0000)]
Remove deprecated code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069844 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove deprecated code
markt [Fri, 11 Feb 2011 15:29:34 +0000 (15:29 +0000)]
Remove deprecated code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069836 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused deprecated method
markt [Fri, 11 Feb 2011 15:27:06 +0000 (15:27 +0000)]
Remove unused deprecated method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069835 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd additional information to assist with tracking down the root cause of https:...
markt [Fri, 11 Feb 2011 15:21:54 +0000 (15:21 +0000)]
Add additional information to assist with tracking down the root cause of https://issues.apache.org/bugzilla/show_bug.cgi?id=50737

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069832 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
markt [Fri, 11 Feb 2011 14:49:41 +0000 (14:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
Don't try to retrieve attributes if we don't need to. If anonymous bind is not allowed, the login will always fail.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069824 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
markt [Fri, 11 Feb 2011 12:24:47 +0000 (12:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
Correct typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069770 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Fri, 11 Feb 2011 12:16:31 +0000 (12:16 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069768 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd unit test that demonstrates use of a custom SSL implementation that extends the...
markt [Fri, 11 Feb 2011 12:08:55 +0000 (12:08 +0000)]
Add unit test that demonstrates use of a custom SSL implementation that extends the default JSSE implementation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069766 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a test case (already passes) for bug50753
markt [Thu, 10 Feb 2011 19:42:34 +0000 (19:42 +0000)]
Add a test case (already passes) for bug50753

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069540 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50720
markt [Thu, 10 Feb 2011 18:59:43 +0000 (18:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50720
Ensure that the use of non-ISO-8859-1 character sets for web.xml does not trigger an error when Jasper parses the web.xml file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069531 13f79535-47bb-0310-9956-ffa450edef68

14 years agoremove retry from the API.
fhanik [Thu, 10 Feb 2011 18:59:08 +0000 (18:59 +0000)]
remove retry from the API.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069530 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Javadoc warnings
markt [Thu, 10 Feb 2011 18:40:37 +0000 (18:40 +0000)]
Fix Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069516 13f79535-47bb-0310-9956-ffa450edef68

14 years agoremove unused import
markt [Thu, 10 Feb 2011 18:38:50 +0000 (18:38 +0000)]
remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069514 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50721
markt [Wed, 9 Feb 2011 23:41:32 +0000 (23:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50721
Correctly handle URL decoding where the URL ends in %nn.
Patch (for fix) provided by Christof Marti.
Additional test cases added.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069170 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnsure NamingResources follows correct lifecycle
markt [Wed, 9 Feb 2011 23:13:00 +0000 (23:13 +0000)]
Ensure NamingResources follows correct lifecycle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069166 13f79535-47bb-0310-9956-ffa450edef68

14 years agoThe bug number changed
markt [Wed, 9 Feb 2011 22:00:08 +0000 (22:00 +0000)]
The bug number changed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069135 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
markt [Wed, 9 Feb 2011 21:56:14 +0000 (21:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50747
Allow the content length header to be set up to the point the response is committed when a writer is used.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069131 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect the package name
markt [Wed, 9 Feb 2011 19:50:37 +0000 (19:50 +0000)]
Correct the package name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069060 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd further checks that LifecycleBase sub-classes are correctly changing state.
markt [Wed, 9 Feb 2011 19:46:49 +0000 (19:46 +0000)]
Add further checks that LifecycleBase sub-classes are correctly changing state.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069056 13f79535-47bb-0310-9956-ffa450edef68

14 years agoadd some arrows to the diagram
markt [Wed, 9 Feb 2011 19:01:20 +0000 (19:01 +0000)]
add some arrows to the diagram

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069032 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBetter comments
markt [Wed, 9 Feb 2011 18:25:48 +0000 (18:25 +0000)]
Better comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1069016 13f79535-47bb-0310-9956-ffa450edef68

14 years agoremove loop that should not be used at all.
fhanik [Wed, 9 Feb 2011 17:47:13 +0000 (17:47 +0000)]
remove loop that should not be used at all.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068996 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50667
fhanik [Wed, 9 Feb 2011 17:39:24 +0000 (17:39 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
Move the callback outside try/catch to avoid duplicate callbacks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068989 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent duplicate event messages
markt [Wed, 9 Feb 2011 12:26:24 +0000 (12:26 +0000)]
Prevent duplicate event messages

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068862 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1068549 - add annotations.
kkolinko [Wed, 9 Feb 2011 09:35:16 +0000 (09:35 +0000)]
Followup to r1068549 - add annotations.

I thought about moving ErrorHandler instance creation outside the retry loop, but actually that is not needed: looping happens only when asyncReply==false and ErrorHandler is created only when asyncReply==true. Thus it is created only once.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068808 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd release date. Move recent changes into the new version.
kkolinko [Wed, 9 Feb 2011 06:39:25 +0000 (06:39 +0000)]
Add release date. Move recent changes into the new version.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068762 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStart a new version, place fix in correct version
fhanik [Tue, 8 Feb 2011 22:49:35 +0000 (22:49 +0000)]
Start a new version, place fix in correct version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068658 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog with latest tribes fixes
fhanik [Tue, 8 Feb 2011 20:34:16 +0000 (20:34 +0000)]
Update changelog with latest tribes fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068560 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50667
fhanik [Tue, 8 Feb 2011 20:18:19 +0000 (20:18 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
Allow a replier to get confirmation if the reply message was sent successfully or if it failed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068549 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo - thanks Konstantin
markt [Tue, 8 Feb 2011 17:05:56 +0000 (17:05 +0000)]
Fix typo - thanks Konstantin

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068480 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove ServerLifecycleListener
markt [Tue, 8 Feb 2011 14:32:38 +0000 (14:32 +0000)]
Remove ServerLifecycleListener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068420 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake NamingResources implement MBeanLifecycle
markt [Tue, 8 Feb 2011 14:30:17 +0000 (14:30 +0000)]
Make NamingResources implement MBeanLifecycle
Environments, Resources and ResourceLinks are once again available via JMX

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068416 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove comments
markt [Tue, 8 Feb 2011 14:28:30 +0000 (14:28 +0000)]
Improve comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1068415 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove for now since I can't get it working with Jira (my primary motivation for...
markt [Sun, 6 Feb 2011 23:18:02 +0000 (23:18 +0000)]
Remove for now since I can't get it working with Jira (my primary motivation for writing it)
It will return once I find the time to do the detailed debugging with Jira to figure out why it doesn't work.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067804 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest a quick hack to get this working with Jira
markt [Sun, 6 Feb 2011 22:56:22 +0000 (22:56 +0000)]
Test a quick hack to get this working with Jira

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067797 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReview from kkolinko
markt [Sun, 6 Feb 2011 21:00:52 +0000 (21:00 +0000)]
Review from kkolinko
1. Matcher not thread safe
2. >1 UA header -> not a bot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067759 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIt isn't working. Add some debug logging.
markt [Sun, 6 Feb 2011 20:30:38 +0000 (20:30 +0000)]
It isn't working. Add some debug logging.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067747 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix the expiration logic
markt [Sun, 6 Feb 2011 20:17:58 +0000 (20:17 +0000)]
Fix the expiration logic

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067743 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFirst attempt at a valve to limit session creation by web crawlers.
markt [Sun, 6 Feb 2011 19:28:48 +0000 (19:28 +0000)]
First attempt at a valve to limit session creation by web crawlers.
Docs etc to follow once it is confirmed working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067734 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTweak defaults. Document.
markt [Sun, 6 Feb 2011 19:08:13 +0000 (19:08 +0000)]
Tweak defaults. Document.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067732 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove attribute name definitions to AccessLog interface
markt [Sun, 6 Feb 2011 18:46:42 +0000 (18:46 +0000)]
Move attribute name definitions to AccessLog interface
AccessLog implementations need to be aware of attributes since they aren't always set (e.g. if request is rejected early in the connector)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067725 13f79535-47bb-0310-9956-ffa450edef68

14 years agoInitial attempt to fix RemoteIp issues observed with ASF Jira
markt [Sun, 6 Feb 2011 18:11:52 +0000 (18:11 +0000)]
Initial attempt to fix RemoteIp issues observed with ASF Jira
Docs, filter and changelog commits to follow once it works

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067718 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBump version
markt [Fri, 4 Feb 2011 12:46:06 +0000 (12:46 +0000)]
Bump version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067170 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix hanging Servlet 3 asynchronous requests when using the APR based AJP connector.
markt [Fri, 4 Feb 2011 12:18:00 +0000 (12:18 +0000)]
Fix hanging Servlet 3 asynchronous requests when using the APR based AJP connector.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067161 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDo not send flush packet if explicit is false
mturk [Fri, 4 Feb 2011 11:16:14 +0000 (11:16 +0000)]
Do not send flush packet if explicit is false

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067151 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix security exception when running under a SecurityManager
markt [Fri, 4 Feb 2011 11:07:18 +0000 (11:07 +0000)]
Fix security exception when running under a SecurityManager

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067147 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollow up to r1067039
markt [Fri, 4 Feb 2011 10:38:09 +0000 (10:38 +0000)]
Follow up to r1067039

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067139 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50709
markt [Fri, 4 Feb 2011 10:30:36 +0000 (10:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50709
Make ApplicationContextFacade non-final to enable extension.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067134 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog
markt [Fri, 4 Feb 2011 10:02:38 +0000 (10:02 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067127 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign server.xml installed by the Windows installer with the one bundled in zip/tar...
kkolinko [Fri, 4 Feb 2011 03:22:53 +0000 (03:22 +0000)]
Align server.xml installed by the Windows installer with the one bundled in zip/tar.gz files.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067075 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix NPE in CoyoteAdapter when postParseRequest() call fails.
kkolinko [Fri, 4 Feb 2011 03:07:37 +0000 (03:07 +0000)]
Fix NPE in CoyoteAdapter when postParseRequest() call fails.

That was caused by mappingData.context being null.
This NPE occurence in 7.0.7 was reported on the users list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067072 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReduce severity level. The ASF Jira instance logs were filling with these
markt [Thu, 3 Feb 2011 23:56:55 +0000 (23:56 +0000)]
Reduce severity level. The ASF Jira instance logs were filling with these

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067039 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBump version number
markt [Thu, 3 Feb 2011 10:35:53 +0000 (10:35 +0000)]
Bump version number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066774 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake sure flush packet is not send after END_RESPONSE packet. Should handle BZ49929
mturk [Thu, 3 Feb 2011 10:23:20 +0000 (10:23 +0000)]
Make sure flush packet is not send after END_RESPONSE packet. Should handle BZ49929

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066772 13f79535-47bb-0310-9956-ffa450edef68

14 years agoHmm. Can't see a way (without changing the connector code) to test SSL renegotiation...
markt [Thu, 3 Feb 2011 09:20:34 +0000 (09:20 +0000)]
Hmm. Can't see a way (without changing the connector code) to test SSL renegotiation failure if the JVM supports RFC5746. Need to think about this some more. In the meantime, get the tests working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066766 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFactor out support code prior to splitting up the TestSsl class
markt [Thu, 3 Feb 2011 08:44:37 +0000 (08:44 +0000)]
Factor out support code prior to splitting up the TestSsl class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066759 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove/rename to better location
markt [Thu, 3 Feb 2011 08:36:03 +0000 (08:36 +0000)]
Move/rename to better location

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066756 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Wed, 2 Feb 2011 18:35:29 +0000 (18:35 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066571 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix javadoc niggle
markt [Wed, 2 Feb 2011 18:33:06 +0000 (18:33 +0000)]
Fix javadoc niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066569 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMissed one place where socket needed to replace socket wrapper in r1063774
markt [Wed, 2 Feb 2011 18:29:26 +0000 (18:29 +0000)]
Missed one place where socket needed to replace socket wrapper in r1063774

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066568 13f79535-47bb-0310-9956-ffa450edef68

14 years agoClarify
markt [Wed, 2 Feb 2011 14:55:36 +0000 (14:55 +0000)]
Clarify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066489 13f79535-47bb-0310-9956-ffa450edef68

14 years agor1057694 broke display of ROOT/index.jsp in MSIE.
kkolinko [Wed, 2 Feb 2011 06:13:26 +0000 (06:13 +0000)]
r1057694 broke display of ROOT/index.jsp in MSIE.
Use JSP comments in the license instead of HTML comments,
like we already do elsewhere.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066338 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect documentation for the PersistentManager class:
kkolinko [Wed, 2 Feb 2011 05:37:52 +0000 (05:37 +0000)]
Correct documentation for the PersistentManager class:
there is no "randomClass" attribute, but several others were added.
Move attributes defined in the Manager interface into the Common Attributes section.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066329 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1066310.
kkolinko [Wed, 2 Feb 2011 03:45:05 +0000 (03:45 +0000)]
Followup to r1066310.
Simplify: call stopAwait() unconditionally.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066321 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1066310. Simplify.
kkolinko [Wed, 2 Feb 2011 03:24:50 +0000 (03:24 +0000)]
Followup to r1066310. Simplify.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066320 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix http://issues.apache.org/bugzilla/show_bug.cgi?id=50673
kkolinko [Wed, 2 Feb 2011 02:45:46 +0000 (02:45 +0000)]
Fix issues.apache.org/bugzilla/show_bug.cgi?id=50673
Improve Catalina shutdown when running as a service. Do not call System.exit().

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066310 13f79535-47bb-0310-9956-ffa450edef68