markt [Tue, 8 Mar 2011 15:39:29 +0000 (15:39 +0000)]
Add release dates
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079399 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 15:37:36 +0000 (15:37 +0000)]
Add the CVE info for 7.0.10
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079398 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 15:19:19 +0000 (15:19 +0000)]
Align SSL init for BIO and NIO.
Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=48208 for NIO.
Adds support for keyPass, truststoreProvider & keystoreProvider
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079387 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 14:21:41 +0000 (14:21 +0000)]
Remove some unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079367 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 14:03:20 +0000 (14:03 +0000)]
Add the hooks (no implementation yet) for BIO and NIO to share the code that is currently in JSSESocketFactory
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079360 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 14:02:03 +0000 (14:02 +0000)]
Fix build failure and don't tie NIO connector to a single SSL implementation
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079359 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 13:50:46 +0000 (13:50 +0000)]
Better Javadoc
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079355 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 13:50:07 +0000 (13:50 +0000)]
Remove JSSEFactory. Now we no longer need to support older JSSE versions, this layer of abstraction is not required.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079354 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 12:10:44 +0000 (12:10 +0000)]
Don't swallow exceptions when they are not expected
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079337 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 11:28:15 +0000 (11:28 +0000)]
Add missing message
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079329 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 11:15:37 +0000 (11:15 +0000)]
Refactor to address https://issues.apache.org/bugzilla/show_bug.cgi?id=48208#c13
Don't configure a TrustManagerFactory instance if it isn't going to be used.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079323 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 8 Mar 2011 11:04:38 +0000 (11:04 +0000)]
Restore the ability to register the Tomcat jndi URL handler via the java.protocol.handler.pkgs system property.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1079320 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 7 Mar 2011 22:18:02 +0000 (22:18 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078981 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 7 Mar 2011 17:42:52 +0000 (17:42 +0000)]
Fix some warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078863 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 7 Mar 2011 16:46:45 +0000 (16:46 +0000)]
Fix Eclipse and FindBugs warnings
Removed unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078850 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 7 Mar 2011 14:55:22 +0000 (14:55 +0000)]
Code cleanup
- remove unused code
- fix FindBugs warnings
- fix Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078798 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 7 Mar 2011 14:24:08 +0000 (14:24 +0000)]
Fix Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078780 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 7 Mar 2011 11:56:19 +0000 (11:56 +0000)]
Another FindBugs false positive
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078754 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 22:12:10 +0000 (22:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=26701
Provide a mechanism for users to register their own URLStreamHandlerFactory objects.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078601 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 22:02:28 +0000 (22:02 +0000)]
Clean-up, mainly unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078595 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 17:37:30 +0000 (17:37 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078523 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 17:35:12 +0000 (17:35 +0000)]
Make more efficient / fix FindBugs nag
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078522 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 09:33:26 +0000 (09:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48208
Add custom trust manager support
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078436 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 07:58:26 +0000 (07:58 +0000)]
Refactoring for re-use
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078416 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 07:47:17 +0000 (07:47 +0000)]
Update comments/test case name
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078414 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 07:33:58 +0000 (07:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50855
Fix NPE on HttpServletRequest.logout() when debug logging is enabled.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078412 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 07:17:07 +0000 (07:17 +0000)]
Fix threading issue reported on dev list
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078409 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 06:27:30 +0000 (06:27 +0000)]
Prep for next release
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078404 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Mar 2011 06:26:46 +0000 (06:26 +0000)]
Add missing entry.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078403 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 16:49:14 +0000 (16:49 +0000)]
Code clean-up
- fix FindBugs warnings
- remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078049 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 15:54:28 +0000 (15:54 +0000)]
Now there is always an authenticator, need to allow for the extra MBean
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078024 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 15:52:01 +0000 (15:52 +0000)]
Code clean-up
- fix FindBugs warnings
- remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078022 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 15:31:04 +0000 (15:31 +0000)]
Avoid npe
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1078004 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 15:17:22 +0000 (15:17 +0000)]
@ServletSecurity
Servlets added via addServlet() should not be processed unless created via craeteServlet. Need to delay scanning until urlPatterns are known
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1077995 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 11:23:43 +0000 (11:23 +0000)]
Check metadata-complete=true leads to @ServletSecurity being ignored
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1077883 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Mar 2011 11:17:06 +0000 (11:17 +0000)]
Check web.xml takes precedence over @ServletSecurity
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1077881 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 3 Mar 2011 19:20:38 +0000 (19:20 +0000)]
Add missing files and license header
Add NOTICE/LICENSE to all JAR files
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076736 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Mar 2011 19:13:52 +0000 (19:13 +0000)]
Test that individual roles are correctly handled
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076731 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Mar 2011 12:56:07 +0000 (12:56 +0000)]
@ServletSecurity
Refactor to reduce duplication in test code
Add tests for method constraints
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076606 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Mar 2011 11:31:56 +0000 (11:31 +0000)]
@ServletSecurity support
Add tests for subclasses
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076589 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Mar 2011 11:24:35 +0000 (11:24 +0000)]
Fix typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076587 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Mar 2011 11:16:51 +0000 (11:16 +0000)]
[SECURITY]
Start of fix for issue reported on users list that @ServletSecurity annotations were ignored.
This fix is not yet complete. This first part:
- Triggers the loading of the Wrapper before the constraints are processed to ensure that any @ServletSecurity annotations are taken account of
- Makes sure the constraints collection is thread-safe given new usage
- Adds scanning for @ServletSecurity when a Servlet is loaded
- Ensure there is always an authenticator when using the embedded Tomcat class so that @ServletSecurity will have an effect
- Adds a simple unit test to check @ServletSecurity annotations are processed
Further commits will add additional test cases and any changes required for those test cases to pass
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076586 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 2 Mar 2011 21:18:18 +0000 (21:18 +0000)]
Doco update
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076385 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 2 Mar 2011 21:15:07 +0000 (21:15 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50857
Timeouts have to be trapped, and properly handled
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076380 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 15:19:58 +0000 (15:19 +0000)]
Speed up shut down when ThreadLocalLeakPreventionListener is enabled
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076249 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 13:55:19 +0000 (13:55 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076222 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 13:48:16 +0000 (13:48 +0000)]
Fix Javadoc
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076218 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 13:23:37 +0000 (13:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=27988
Improve reporting of missing files
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076212 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 13:17:37 +0000 (13:17 +0000)]
Update change log
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076206 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 12:42:34 +0000 (12:42 +0000)]
Better test for APR
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076197 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 12:03:05 +0000 (12:03 +0000)]
Correct issues in the SSL renegotiation tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076182 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 2 Mar 2011 11:43:06 +0000 (11:43 +0000)]
Save a few cycles
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076178 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Tue, 1 Mar 2011 23:59:36 +0000 (23:59 +0000)]
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
1) Be more strict when ignoring the warning:
ignore only when it is the "lib" directory and when it does not exist
2) Warn about JARs created from expanding the GLOB pattern as well
3) s/new File(f.getCanonicalPath())/f.getCanonicalFile()/ for efficiency
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076059 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Tue, 1 Mar 2011 23:24:33 +0000 (23:24 +0000)]
Correct several typos
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076047 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 1 Mar 2011 20:34:00 +0000 (20:34 +0000)]
Make sure we also validate the content that is sent and received
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076015 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 1 Mar 2011 20:04:26 +0000 (20:04 +0000)]
Implement renegotiation for SSL cert authentication
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076008 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 1 Mar 2011 19:58:55 +0000 (19:58 +0000)]
Correctly determine if a buffer has data or not
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1076004 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 1 Mar 2011 18:24:03 +0000 (18:24 +0000)]
propagate all exceptions through IOExceptions
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075964 13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 1 Mar 2011 18:13:38 +0000 (18:13 +0000)]
Simple implementation of a forced and blocking renegotiation with a SSL client
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075956 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 14:13:16 +0000 (14:13 +0000)]
Move outside of loop as per kkolinko's review
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075823 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 13:35:24 +0000 (13:35 +0000)]
Missed a keystore in the refactoring
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075816 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 13:24:31 +0000 (13:24 +0000)]
Fix bug in unit test due to some Lifecycle refactoring
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075811 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 12:32:25 +0000 (12:32 +0000)]
Improve handling of SSL renegotiation by failing earlier when the request body contains more bytes than maxSavePostSize.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075792 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 11:12:22 +0000 (11:12 +0000)]
Remove the init from references to handshake since the same fields/methods will be used for renegotiation
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075776 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 10:16:36 +0000 (10:16 +0000)]
Extract the client-cert tests into a separate test
Check maxPostSize works as expected with client-cert
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075762 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 09:33:57 +0000 (09:33 +0000)]
Clear remainder of current FindBugs issues in unit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075742 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 09:13:18 +0000 (09:13 +0000)]
More entries
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075737 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 09:12:51 +0000 (09:12 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075736 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 09:02:52 +0000 (09:02 +0000)]
Fix Findbugs nag
Reduce visibility
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075725 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 09:01:30 +0000 (09:01 +0000)]
Grr. This worked if 20 bytes were read in one go
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075724 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 09:00:01 +0000 (09:00 +0000)]
Better fix, we actually need to read 20 byres for the test to pass
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075719 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 08:56:48 +0000 (08:56 +0000)]
Fix FindBugs warning
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075718 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 08:50:40 +0000 (08:50 +0000)]
More explicit failure message - fixed FindBugs nags
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075713 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 08:44:29 +0000 (08:44 +0000)]
FindBugs fixes - make constants static
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075708 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 08:36:57 +0000 (08:36 +0000)]
Comment tweaks
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075699 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 01:23:31 +0000 (01:23 +0000)]
Revert SSL renegotiation for NIO - implementation is broken
Reverts r1074675 and r1075030
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075606 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 1 Mar 2011 01:15:11 +0000 (01:15 +0000)]
Start of an SSL re-negotiation test. Need to expand it to handle request bodies and the other issues highlighted by Filip.
Switch to using a CA since it makes the code cleaner and it is easier to get CLIENT-CERT working than will all self-signed certs.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075604 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 28 Feb 2011 19:03:31 +0000 (19:03 +0000)]
Should have moved the keys when I moved the SSL tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075487 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 28 Feb 2011 18:43:44 +0000 (18:43 +0000)]
Fix an Eclipse nag
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075474 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 28 Feb 2011 18:15:48 +0000 (18:15 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
Add URL encoding where missing to parameters in URLs presented by Ant tasks to the Manager application.
Based on a patch by Stephane Bailliez.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075458 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 28 Feb 2011 17:24:00 +0000 (17:24 +0000)]
Clarify auth process for CLIENT-CERT
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075435 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 28 Feb 2011 14:14:41 +0000 (14:14 +0000)]
Prep for next release
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075338 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 28 Feb 2011 13:35:41 +0000 (13:35 +0000)]
Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
- consistently pass absolute paths to validateFile()
- handle non-absolute catalina home/base
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075320 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 23:08:45 +0000 (23:08 +0000)]
Fix Eclipse warnings
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075176 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 22:59:10 +0000 (22:59 +0000)]
Clear remaining FindBugs issues from javax.*
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075175 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 15:53:45 +0000 (15:53 +0000)]
Misc clean-up
- remove unused code
- suppress FindBugs false positives
- add javadoc
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075083 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 14:34:19 +0000 (14:34 +0000)]
Another false positive
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075063 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 14:31:27 +0000 (14:31 +0000)]
Couple more false positives
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075062 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 14:29:07 +0000 (14:29 +0000)]
Misc clean-up
- Suppress Eclipse warnings
- Remove unused code
- Correct Javadoc
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075061 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 14:26:55 +0000 (14:26 +0000)]
Remove unused code
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075060 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 14:12:39 +0000 (14:12 +0000)]
Revert r1075050
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075058 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 13:19:22 +0000 (13:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31027
Trim whitespace from names and values obtained from $CATALINA_BASE/conf/catalina.properties to avoid hard to diagnose errors on startup.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075050 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 11:28:01 +0000 (11:28 +0000)]
Block whilst waiting for data from client in NIO SSL-rehandshake rather than spinning the CPU
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075030 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 11:00:12 +0000 (11:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
Better documentation of the meaning of Lifecycle.isAvailable() and correct a couple of cases where this could incorrectly return true.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075022 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Feb 2011 10:31:49 +0000 (10:31 +0000)]
Another false positive
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1075019 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 26 Feb 2011 20:44:34 +0000 (20:44 +0000)]
Fix FindBugs identified error in Servlet 2.2 jspFile handling
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1074919 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 26 Feb 2011 20:40:25 +0000 (20:40 +0000)]
Fix what looks like a copy/paste error
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1074918 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 26 Feb 2011 20:07:00 +0000 (20:07 +0000)]
No need to call stop if the app didn't start
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1074915 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 26 Feb 2011 20:01:10 +0000 (20:01 +0000)]
Ensure a web application is taken out of service if the web.xml file is not valid.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1074914 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 26 Feb 2011 19:37:13 +0000 (19:37 +0000)]
Fix FindBugs warning
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1074911 13f79535-47bb-0310-9956-
ffa450edef68
projects / tomcat7.0 / log