tomcat7.0
15 years agoMore review comments form mturk. Tighten up handling of ps output.
markt [Tue, 28 Sep 2010 21:30:27 +0000 (21:30 +0000)]
More review comments form mturk. Tighten up handling of ps output.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002362 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRespond to mturk's review. Make rm more robust. Avoid potential issues with (...).
markt [Tue, 28 Sep 2010 21:20:06 +0000 (21:20 +0000)]
Respond to mturk's review. Make rm  more robust. Avoid potential issues with (...).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002359 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49195
markt [Tue, 28 Sep 2010 20:43:32 +0000 (20:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49195
Avoid error message when shutting down Windows service when the shutdown port is disabled.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002349 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
markt [Tue, 28 Sep 2010 17:23:05 +0000 (17:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
Better handling for missing TLD files. Report JSP filename and location.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002274 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate
markt [Tue, 28 Sep 2010 17:02:33 +0000 (17:02 +0000)]
Update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002264 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49728
markt [Tue, 28 Sep 2010 16:59:54 +0000 (16:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49728
Improve PID file handling, particularly when another process creates it and Tomcat is unable to write to the file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002263 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49657
markt [Tue, 28 Sep 2010 14:43:03 +0000 (14:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49657
Correctly handle CGI executables with spaces in the name/path

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002185 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49625
markt [Tue, 28 Sep 2010 12:08:53 +0000 (12:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49625
Ensure Vary header is set if response may be compressed rather than only setting it if it is compressed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002133 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd license header
kkolinko [Tue, 28 Sep 2010 11:37:14 +0000 (11:37 +0000)]
Add license header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002120 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMoved all Eclipse specific files into res/ide-support/eclipse.
timw [Tue, 28 Sep 2010 09:36:08 +0000 (09:36 +0000)]
Moved all Eclipse specific files into res/ide-support/eclipse.
Removed spaces from launch target filenames.
Corrected launch targets to run in output/build instead of root directory (still not sure if they're a good idea)
Added an Ant ide-eclipse target to prepare the working copy to be built with Eclipse and create Eclipse project files.
Updated the Building docs to document new Eclipse setup method.
Added descriptions of how to configure Eclipse to respect Tomcat coding conventions to the Building guide.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002073 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdding myself to active devs list.
timw [Tue, 28 Sep 2010 09:28:30 +0000 (09:28 +0000)]
Adding myself to active devs list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1002070 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate
markt [Mon, 27 Sep 2010 23:09:54 +0000 (23:09 +0000)]
Update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001958 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49209
markt [Mon, 27 Sep 2010 23:06:08 +0000 (23:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49209
Prevent possible AccessControlException during undeployment when running with a security manager
Patch provided by Sylvain Laurent

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001955 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate
markt [Mon, 27 Sep 2010 22:31:03 +0000 (22:31 +0000)]
Update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001941 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemaining fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 22:29:30 +0000 (22:29 +0000)]
Remaining fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001939 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 22:22:02 +0000 (22:22 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001938 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 22:17:30 +0000 (22:17 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001934 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 22:16:26 +0000 (22:16 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001933 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 22:12:05 +0000 (22:12 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001932 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 22:01:45 +0000 (22:01 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001923 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 21:32:25 +0000 (21:32 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001915 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 20:52:49 +0000 (20:52 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001904 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
markt [Mon, 27 Sep 2010 20:24:18 +0000 (20:24 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Don't catch Throwable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001899 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix comment typo
markt [Mon, 27 Sep 2010 12:58:06 +0000 (12:58 +0000)]
Fix comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001719 13f79535-47bb-0310-9956-ffa450edef68

15 years agogit-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001718 13f79535-47bb-0310...
markt [Mon, 27 Sep 2010 12:56:38 +0000 (12:56 +0000)]
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001718 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49884
markt [Mon, 27 Sep 2010 12:13:32 +0000 (12:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49884

This required a major re-factoring of the async implementation. In summary:
- Moved state management to the Coyote Processor
- Added a SocketWrapper to the APR socket
- Added syncs to ensure only one async state change at a time
- Added syncs to ensure only one thread changing a socket's state at a time

A number of new bugs were also uncovered and fixed by this re-factoring:
- delay processing complete() and dispatch() until request where startAsync() is called finished processing
- onAsyncStart listener event

Currently the test case for bug 49884 passes with the security manager enabled using "ab -n 5000 -c 150 -k ..." (it broke with "ab -n 50 -c 10 ..." previously)

The unit tests pass for all three HTTP connectors.

The AJP connectors have only been modified to ensure the code compiles.

The following work remains:
- Testing all connectors (HTTP and AJP) with TCK + security manager and fixing whatever is broken
- Further clean-up
- There is further scope for reducing code duplication between the connectors / aligning the code so it is easier to maintain.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001698 13f79535-47bb-0310-9956-ffa450edef68

15 years agoChange method name so it is easier to distinguish between async and comet processing...
markt [Mon, 27 Sep 2010 00:17:26 +0000 (00:17 +0000)]
Change method name so it is easier to distinguish between async and comet processing. No so important here since comet isn't supported, but need to change it to align with changes to be made in NIO and APR

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001564 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove some unused code.
markt [Sun, 26 Sep 2010 22:58:38 +0000 (22:58 +0000)]
Remove some unused code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001553 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore NPE avoidance.
markt [Sun, 26 Sep 2010 22:50:30 +0000 (22:50 +0000)]
More NPE avoidance.
Keep process methods aligned.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001552 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix a handful of Eclipse warnings
markt [Sun, 26 Sep 2010 22:46:35 +0000 (22:46 +0000)]
Fix a handful of Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001548 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSince SocketStatus is always OPEN or TIMEOUT for BIO, remove the test.
markt [Sun, 26 Sep 2010 22:38:14 +0000 (22:38 +0000)]
Since SocketStatus is always OPEN or TIMEOUT for BIO, remove the test.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001546 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd some Javadoc.
markt [Sun, 26 Sep 2010 22:37:31 +0000 (22:37 +0000)]
Add some Javadoc.
Use SocketStatus.OPEN rather than STOP since the BIO connector treats them the same way and it reduces code complexity. It also simplifies async re-factoring I have in the works,

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001545 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter Javadoc.
markt [Sun, 26 Sep 2010 22:22:25 +0000 (22:22 +0000)]
Better Javadoc.
If endpoint is shutting down, return false so connection to client is closed immediately.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001538 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean-up. Reduce whitespace, unnecessary comments
markt [Sun, 26 Sep 2010 21:26:08 +0000 (21:26 +0000)]
Clean-up. Reduce whitespace, unnecessary comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001525 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police
markt [Sun, 26 Sep 2010 17:57:07 +0000 (17:57 +0000)]
Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001485 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFixing Tomcat startup class in building instructions.
timw [Sun, 26 Sep 2010 07:46:27 +0000 (07:46 +0000)]
Fixing Tomcat startup class in building instructions.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1001383 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Bz #49993 by checking the JAVA_HOME/JRE_HOME environment variables
mturk [Fri, 24 Sep 2010 06:00:00 +0000 (06:00 +0000)]
Fix Bz #49993 by checking the JAVA_HOME/JRE_HOME environment variables

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000718 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReduce timeout from 60s to 3s to speed up async tests
markt [Thu, 23 Sep 2010 21:08:14 +0000 (21:08 +0000)]
Reduce timeout from 60s to 3s to speed up async tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000625 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a comment.
kkolinko [Thu, 23 Sep 2010 12:46:50 +0000 (12:46 +0000)]
Add a comment.
I guess it is too late to change it now, as the code is more than 3 years old.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000433 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTake care of line endings for the two files added in r1000392
kkolinko [Thu, 23 Sep 2010 12:15:56 +0000 (12:15 +0000)]
Take care of line endings for the two files added in r1000392

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000423 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49102
timw [Thu, 23 Sep 2010 10:38:56 +0000 (10:38 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102

Protecting AJP code -> header/method lookup arrays with getters.
No measurable slowdown (especially after a profiling JIT gets done with it).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000400 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49955
timw [Thu, 23 Sep 2010 10:15:16 +0000 (10:15 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955

Improvements and corrections for the Building Tomcat guide, plus
sample Eclipse launch targets.

Based on contribution from Wesley Acheson.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000392 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdding a description for build-docs task
timw [Thu, 23 Sep 2010 10:14:54 +0000 (10:14 +0000)]
Adding a description for build-docs task

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000391 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Javadoc warnings highlighted by buildbot
markt [Thu, 23 Sep 2010 00:30:53 +0000 (00:30 +0000)]
Fix Javadoc warnings highlighted by buildbot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000284 13f79535-47bb-0310-9956-ffa450edef68

15 years agoParameterize the APR location for the unit tests
markt [Thu, 23 Sep 2010 00:19:20 +0000 (00:19 +0000)]
Parameterize the APR location for the unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000283 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrectly define the ROOT context in unit tests
markt [Wed, 22 Sep 2010 22:59:55 +0000 (22:59 +0000)]
Correctly define the ROOT context in unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000269 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd the missing onStartAsync event
markt [Wed, 22 Sep 2010 20:04:32 +0000 (20:04 +0000)]
Add the missing onStartAsync event

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000164 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImproving the documentation for logging configuration in Apache Tomcat
kkolinko [Wed, 22 Sep 2010 14:48:53 +0000 (14:48 +0000)]
Improving the documentation for logging configuration in Apache Tomcat

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1000003 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo
markt [Wed, 22 Sep 2010 14:47:16 +0000 (14:47 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999995 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNeed ant-launcher.jar to compile JSPs with Ant rather than ECJ
markt [Wed, 22 Sep 2010 14:34:23 +0000 (14:34 +0000)]
Need ant-launcher.jar to compile JSPs with Ant rather than ECJ

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999980 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse *modern* types of nsis install/uninstall icons
mturk [Wed, 22 Sep 2010 14:29:07 +0000 (14:29 +0000)]
Use *modern* types of nsis install/uninstall icons

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999976 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd connector wait for shutdown to changelog
mturk [Wed, 22 Sep 2010 14:22:48 +0000 (14:22 +0000)]
Add connector wait for shutdown to changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999972 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDelete reference to option that was previously removed.
markt [Wed, 22 Sep 2010 14:18:48 +0000 (14:18 +0000)]
Delete reference to option that was previously removed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999966 13f79535-47bb-0310-9956-ffa450edef68

15 years agoadd release date for 7.0.2 beta,
kkolinko [Wed, 22 Sep 2010 13:15:46 +0000 (13:15 +0000)]
add release date for 7.0.2 beta,
from announcement on tomcat.apache.org

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999929 13f79535-47bb-0310-9956-ffa450edef68

15 years agocorrect a typo
kkolinko [Tue, 21 Sep 2010 18:21:38 +0000 (18:21 +0000)]
correct a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999523 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code as identified by UCDetector
markt [Sat, 18 Sep 2010 21:41:44 +0000 (21:41 +0000)]
Remove unused code as identified by UCDetector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998554 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused constructor
markt [Sat, 18 Sep 2010 21:20:00 +0000 (21:20 +0000)]
Remove unused constructor

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998549 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factor JIO end point to look more like NIO end point. Moving stuff around, process...
markt [Sat, 18 Sep 2010 18:09:48 +0000 (18:09 +0000)]
Re-factor JIO end point to look more like NIO end point. Moving stuff around, processing order should remain the same.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998509 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused imports
markt [Sat, 18 Sep 2010 18:08:25 +0000 (18:08 +0000)]
Remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998506 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore refactoring. This one very simple.
markt [Sat, 18 Sep 2010 15:04:40 +0000 (15:04 +0000)]
More refactoring. This one very simple.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998479 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up
markt [Sat, 18 Sep 2010 13:47:49 +0000 (13:47 +0000)]
Code clean-up
Use a single method for unlockAccept

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998468 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up
markt [Sat, 18 Sep 2010 11:53:19 +0000 (11:53 +0000)]
Code clean-up
Align end-point behaviours. Should then be easier to apply async chnages.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998446 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up.
markt [Fri, 17 Sep 2010 18:27:49 +0000 (18:27 +0000)]
Code clean-up.
Align BIO and NIO to make Async refactoring easier

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998236 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNothing was reading this. Remove it. It can always be added back in later if we need...
markt [Fri, 17 Sep 2010 16:43:33 +0000 (16:43 +0000)]
Nothing was reading this. Remove it. It can always be added back in later if we need it for something.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998195 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlso handle NPEs (seen during testing of new async re-factoring) and ignore them...
markt [Fri, 17 Sep 2010 16:30:54 +0000 (16:30 +0000)]
Also handle NPEs (seen during testing of new async re-factoring) and ignore them if the endpoint is shutting down.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998190 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMisc Eclipse and FindBugs warnings
markt [Fri, 17 Sep 2010 15:02:45 +0000 (15:02 +0000)]
Misc Eclipse and FindBugs warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998168 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused import
markt [Fri, 17 Sep 2010 14:56:58 +0000 (14:56 +0000)]
Remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998164 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unnecessary code. Superclass method does exactly the same thing.
markt [Fri, 17 Sep 2010 14:56:28 +0000 (14:56 +0000)]
Remove unnecessary code. Superclass method does exactly the same thing.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998161 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up.
markt [Fri, 17 Sep 2010 14:40:05 +0000 (14:40 +0000)]
Code clean-up.
Align BIO and NIO to make Async refactoring easier

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998153 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove more START/STOP actions and started attribute. They aren't adding anything.
markt [Fri, 17 Sep 2010 14:11:03 +0000 (14:11 +0000)]
Remove more START/STOP actions and started attribute. They aren't adding anything.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998145 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove START/STOP actions and started attribute. They aren't adding anything.
markt [Fri, 17 Sep 2010 14:08:10 +0000 (14:08 +0000)]
Remove START/STOP actions and started attribute. They aren't adding anything.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998143 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNIO and APR processors don't use START/STOP so this code is unnecessary
markt [Fri, 17 Sep 2010 14:00:10 +0000 (14:00 +0000)]
NIO and APR processors don't use START/STOP so this code is unnecessary

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998141 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49909
markt [Fri, 17 Sep 2010 11:05:39 +0000 (11:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49909
Re-enable JSTL. This was a regression in the fix for bz 47950

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998071 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove empty dir
markt [Wed, 15 Sep 2010 14:03:13 +0000 (14:03 +0000)]
Remove empty dir

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997341 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix niggle
markt [Wed, 15 Sep 2010 13:39:08 +0000 (13:39 +0000)]
Fix niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997331 13f79535-47bb-0310-9956-ffa450edef68

15 years agoInclude the suffix in the version number
markt [Wed, 15 Sep 2010 13:34:42 +0000 (13:34 +0000)]
Include the suffix in the version number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997329 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Javadoc
markt [Wed, 15 Sep 2010 13:29:47 +0000 (13:29 +0000)]
Fix Javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997326 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate changelog
markt [Wed, 15 Sep 2010 13:26:12 +0000 (13:26 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997323 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49584
markt [Wed, 15 Sep 2010 13:24:14 +0000 (13:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49584
Move the offering of a new thread on release from the abandoned connection code to the release code to eliminate the possibility of a blocked thread on release.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997321 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAddress a concern raised in https://issues.apache.org/bugzilla/show_bug.cgi?id=49584
markt [Wed, 15 Sep 2010 11:42:55 +0000 (11:42 +0000)]
Address a concern raised in https://issues.apache.org/bugzilla/show_bug.cgi?id=49584
Re-factor code to clarify con is never null when release is called.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@997291 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore re-factoring: AsyncContext will throw exception
markt [Tue, 14 Sep 2010 12:38:53 +0000 (12:38 +0000)]
More re-factoring: AsyncContext will throw exception

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996871 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore re-factoring: expose the Executor
markt [Tue, 14 Sep 2010 12:09:50 +0000 (12:09 +0000)]
More re-factoring: expose the Executor

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996861 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore re-factoring prior to large async changes
markt [Tue, 14 Sep 2010 11:47:57 +0000 (11:47 +0000)]
More re-factoring prior to large async changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996852 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up and a little preparatory re-factoring prior to large async changes
markt [Tue, 14 Sep 2010 11:43:22 +0000 (11:43 +0000)]
Code clean-up and a little preparatory re-factoring prior to large async changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996850 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix most of the warnings in this package
markt [Tue, 14 Sep 2010 07:55:26 +0000 (07:55 +0000)]
Fix most of the warnings in this package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996780 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49924
kfujino [Tue, 14 Sep 2010 07:49:33 +0000 (07:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49924
When non-primary node changes into a primary node, make sure isPrimarySession is changed to true.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996778 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd @Override markers to package
markt [Tue, 14 Sep 2010 07:23:19 +0000 (07:23 +0000)]
Add @Override markers to package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996771 13f79535-47bb-0310-9956-ffa450edef68

15 years agoConvert ActionCode to an enum.
markt [Mon, 13 Sep 2010 20:23:22 +0000 (20:23 +0000)]
Convert ActionCode to an enum.
Shorten all the names by removing ACTION_ from the beginning. We have to use ActionCode.XXX to ACTION_ is just wasted screen space.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996677 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring the connectors. Remove large chunks of duplicated code in the Processors...
markt [Mon, 13 Sep 2010 20:03:17 +0000 (20:03 +0000)]
Re-factoring the connectors. Remove large chunks of duplicated code in the Processors. Some minor changes elsewhere to support the re-factoring.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996672 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up
markt [Mon, 13 Sep 2010 17:28:53 +0000 (17:28 +0000)]
Code clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996608 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Eclipse warnings prior to working on bz49884 refactoring
markt [Sun, 12 Sep 2010 08:05:35 +0000 (08:05 +0000)]
Fix Eclipse warnings prior to working on bz49884 refactoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996261 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typos. Remove attributes that don't exist. Add a missing attribute.
markt [Sun, 12 Sep 2010 01:38:30 +0000 (01:38 +0000)]
Fix typos. Remove attributes that don't exist. Add a missing attribute.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996235 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFurther work for https://issues.apache.org/bugzilla/show_bug.cgi?id=49234
markt [Sun, 12 Sep 2010 01:25:03 +0000 (01:25 +0000)]
Further work for https://issues.apache.org/bugzilla/show_bug.cgi?id=49234
GSOC 2010. Enable the creation of Services, Engines, Connectors, Hosts and Contexts via JMX from a minimal server.xml that contains only a Server element.
Based on a patch by Chamith Buddhika. I added the additional changes to pass the parent class loader down the hierarchy.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996231 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate commons pool to 1.5.5
markt [Sat, 11 Sep 2010 16:32:02 +0000 (16:32 +0000)]
Update commons pool to 1.5.5

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996163 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate changelog
markt [Sat, 11 Sep 2010 15:47:01 +0000 (15:47 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996159 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix an issue where <Context .../> elements defined in server.xml did not use the...
markt [Sat, 11 Sep 2010 10:44:50 +0000 (10:44 +0000)]
Fix an issue where <Context .../> elements defined in server.xml did not use the configClass specified by the parent <Host .../> element

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996117 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r996112. At least some of that config is required.
markt [Sat, 11 Sep 2010 10:17:07 +0000 (10:17 +0000)]
Revert r996112. At least some of that config is required.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996114 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unnecessary digester configuration
markt [Sat, 11 Sep 2010 09:48:32 +0000 (09:48 +0000)]
Remove unnecessary digester configuration
hostConfigClass and engineConfigClass were removed before 6.0.x

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@996112 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove pointless comment.
markt [Fri, 10 Sep 2010 21:35:55 +0000 (21:35 +0000)]
Remove pointless comment.
Schema validation moved to the context

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@995991 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean up
markt [Thu, 9 Sep 2010 21:08:50 +0000 (21:08 +0000)]
Code clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@995577 13f79535-47bb-0310-9956-ffa450edef68